From: Shubham Chakraborty <chakrabortyshubham66@gmail.com>
To: gregkh@linuxfoundation.org
Cc: dan.carpenter@linaro.org, dtwlin@gmail.com, johan@kernel.org,
elder@kernel.org, greybus-dev@lists.linaro.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Shubham Chakraborty <chakrabortyshubham66@gmail.com>
Subject: [PATCH v2] staging: greybus: uart: add descriptive lock comments
Date: Fri, 27 Feb 2026 12:22:20 +0530 [thread overview]
Message-ID: <20260227065220.8039-1-chakrabortyshubham66@gmail.com> (raw)
In-Reply-To: <aZ_9V7cldGzWNDrb@stanley.mountain>
Replace vague lock comments with specific descriptions of
what data each lock protects:
- read_lock: protects iocount and oldcount
- write_lock: protects write_fifo and credits
- mutex: protects disconnected state
Signed-off-by: Shubham Chakraborty <chakrabortyshubham66@gmail.com>
---
drivers/staging/greybus/uart.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c
index fe554eba555a..1e51818e34a8 100644
--- a/drivers/staging/greybus/uart.c
+++ b/drivers/staging/greybus/uart.c
@@ -50,12 +50,12 @@ struct gb_tty {
unsigned int minor;
unsigned char clocal;
bool disconnected;
- spinlock_t read_lock; /* protects read operations */
- spinlock_t write_lock; /* protects write operations */
+ spinlock_t read_lock; /* protects iocount and oldcount */
+ spinlock_t write_lock; /* protects write_fifo and credits */
struct async_icount iocount;
struct async_icount oldcount;
wait_queue_head_t wioctl;
- struct mutex mutex; /* serializes port operations */
+ struct mutex mutex; /* protects disconnected state */
u8 ctrlin; /* input control lines */
u8 ctrlout; /* output control lines */
struct gb_uart_set_line_coding_request line_coding;
--
2.53.0
next prev parent reply other threads:[~2026-02-27 6:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 18:38 [PATCH 1/2] staging: greybus: uart: fix style issues Shubham Chakraborty
2026-02-25 18:38 ` [PATCH 2/2] staging: greybus: uart: convert to XArray Shubham Chakraborty
2026-02-25 18:47 ` Greg Kroah-Hartman
2026-02-26 18:25 ` Shubham Chakraborty
2026-02-25 18:43 ` [PATCH 1/2] staging: greybus: uart: fix style issues Greg Kroah-Hartman
2026-02-26 7:59 ` Dan Carpenter
2026-02-26 17:58 ` Shubham Chakraborty
2026-02-27 6:52 ` Shubham Chakraborty [this message]
2026-02-27 9:03 ` [PATCH v2] staging: greybus: uart: add descriptive lock comments Dan Carpenter
2026-02-27 15:48 ` [PATCH v2] staging: greybus: uart: improve " Shubham Chakraborty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260227065220.8039-1-chakrabortyshubham66@gmail.com \
--to=chakrabortyshubham66@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=dtwlin@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®