From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7C98329E7D for ; Fri, 27 Feb 2026 11:57:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772193481; cv=none; b=htoRaxEGOvgHnfEwPNzD7A1ZebJVyHDIKuFGW/6eZFs58XSoqoQMWbxxYrhhn79J3OdliBKw43wC6rqo0xSxj91OxazqNQf1Vddr5szMIiKzWBJUawtatgalKRFd+5FQAFeC0xAJpJI1gT5S1DlYyBj9xB4tXzZ7w8KyXNj48AA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772193481; c=relaxed/simple; bh=Rmbcntvi8Gh/PYvMReKTEGA3PpfcJW5rsxJIhfxKsBY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iKMvg8l82IfmZlQMjXIouT2uOMy7J8xJZt5prhOa6SsnidZ5rLTF0SRnja/vAL+nQFhzonX7ZyYCAFt4I1Z6j+9XVdPr3JBwUTlz5PjNkPqN+MOxHbgWwR2lNwew/IYw6POcMB5Rgi56oOXTE2yz1yy4DUkNGF8oC3VSEc1Z//s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=FSYjsw3l; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="FSYjsw3l" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=AHz/CBHhOuGRCT/m/eoiNHyXNAIOp1jotzca1OHxBys=; b=FSYjsw3lN7EcWZf3jswIG992WX RnSUlknPd1rLGZ/HA1WRCQrp9nniTs/QS4AFG6W7IKBV7rfyPzt2AZ08OOQe+7NIFXeXenvnzhmHS x/08ZYXJi/ZoFPzGv/CLJvOlECFujGf7yq7b4LPihaN+ERqnaT87MGxeVbWDsyv8psFQFo9JlpRW8 Q34tYsjM+CnHMojX2FmTE+TiJPFlcIUc+ISkJaT3lm77PT8KXx50YdWu3Bt5GkSbkM2PW/vRqk0GU +K9Acr1wEbIXP8m2leZ4RLF0UyUwZa9KXg0/S7EPNa2W2cLBnbrme7/yb8zMBvLGSkpKLgxf/64R/ k99196vw==; Received: from 2001-1c00-8d85-5700-266e-96ff-fe07-7dcc.cable.dynamic.v6.ziggo.nl ([2001:1c00:8d85:5700:266e:96ff:fe07:7dcc] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1vvwTi-00000004Vhv-3GGL; Fri, 27 Feb 2026 11:57:54 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 16B16300CDE; Fri, 27 Feb 2026 12:57:54 +0100 (CET) Date: Fri, 27 Feb 2026 12:57:54 +0100 From: Peter Zijlstra To: Kyle Meyer Cc: x86@kernel.org, tglx@kernel.org, linux-kernel@vger.kernel.org, tim.c.chen@linux.intel.com, yu.c.chen@intel.com, vinicius.gomes@intel.com, brgerst@gmail.com, hpa@zytor.com, kprateek.nayak@amd.com, patryk.wlazlyn@linux.intel.com, rafael.j.wysocki@intel.com, russ.anderson@hpe.com, zhao1.liu@intel.com, tony.luck@intel.com Subject: Re: [RFC][PATCH 3/6] x86/topo: Add __num_nodes_per_package Message-ID: <20260227115754.GC1395266@noisy.programming.kicks-ass.net> References: <20260226104909.675623579@infradead.org> <20260226105052.472660569@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Feb 26, 2026 at 11:46:15AM -0600, Kyle Meyer wrote: > > --- a/arch/x86/kernel/cpu/topology.c > > +++ b/arch/x86/kernel/cpu/topology.c > > @@ -497,11 +497,18 @@ void __init topology_init_possible_cpus( > > set_nr_cpu_ids(allowed); > > > > cnta = domain_weight(TOPO_PKG_DOMAIN); > > + cntb = domain_weight(TOPO_NUMA_DOMAIN); > > We'll need to check CONFIG_NUMA here. > > TOPO_NUMA_DOMAIN is undeclared when CONFIG_NUMA is not set. Indeed.