From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53E1733263A for ; Fri, 27 Feb 2026 14:55:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772204138; cv=none; b=jiHNLaH8AEDeK48ONXJElBhFDjtVwwTQA5IzevplQ0qm+WjZDy/lrgWJq1FS57Ed+TrDn5QR1oTw/XKDy9spBO9PbEPb5Q7AMtcLUNPj6M/mGyPVTOpB/C9EH9QSg40ESRcaeMBspxeNIBJ2L3iiRlVzJkdBxX7Y5pGjb8ndVr0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772204138; c=relaxed/simple; bh=hiz00qRo+gJPIyqDDN8X4PSaiW0SmJY5V53PRQYG2fk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=e7t6ITNe0UFGg8bNjTpn8LXZOtcMGc8anWYewRmpWp6cOV9rgqHwA8v9InZn8Lrh019bHmsQ50oUy68XENEGduBE2OVCrlrJ+x7gB2ZEEZg09EXVx43NOV2x5dl380mtsKETJttTkXzX5W3f8C8xpjG70WKBFzlZr4wM3huhjMM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=bddOLB6w; arc=none smtp.client-ip=209.85.222.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="bddOLB6w" Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-8cb39647a70so196772685a.0 for ; Fri, 27 Feb 2026 06:55:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1772204136; x=1772808936; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hiz00qRo+gJPIyqDDN8X4PSaiW0SmJY5V53PRQYG2fk=; b=bddOLB6wkQaWPkJgSS8OVql4r2GQjgyhxFJXCAb8gWam2lewjWDeIdtbcEQWFv3GgB 2GdflMo8YFOApBbs8h4o7bWRQcRDq66BH1Q1hAstkOJ1ZHxVqhtjmcIKU8p3aIH+ssfM 2hbkiLrFZ70/NrCj0oMFJD4jAiJbFTxNAiAmqAFr48EFTG7ozhyRO286xT5+8xT2Iq7w Q4ziVJlv8tdxcclcAEZ/xBETdT8LbIIWBwh/iNRPg9xSH7XQu8mnE2j8QXuFmrJUawi0 zIqbjJoGTlwi4gGPb8jhR500khIykUXWrX5bSDAS4H+DV4y6vn6W6WTLKx+Ii9qBSq80 RJlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772204136; x=1772808936; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hiz00qRo+gJPIyqDDN8X4PSaiW0SmJY5V53PRQYG2fk=; b=vOaJ777z+ThYgcn6vepfE2UHYCJUfXgCIbRDV80rOUnBxdfFZCh+BEtb7lH4iq6OYv pe9JRxpwjL6Wcw6C7lCwKScMfdaed5nreugCL28i+yCQpzIhtAMoLSMWC5//IZHasrMa gm8j4tgpqrHmXpG1+z9aUScv4nhQR1XZ6j85IpdzN5awywRq2kewclPsr+dkyaMEtxIJ BoCLue7XSKgiFUzpX7vnZ1pa7Ch08neICmoL7Xdp0C7qtBfeL6iYC5Xv3QMK8jtAP+ph NIZ6S0cMymXRTStBm6eIJO9zYbK9U5nvmVl1gvzDxZuBYnZKQ5+EZv4WNNu1Z/d1JE16 Jabg== X-Forwarded-Encrypted: i=1; AJvYcCXn7gFz7+F6evOoih8zR92P9EBgtc5sMW2VUkBFfaZVn6f4HYRUmvl9cAu4rVOYyHSs0s6QOl2hTCSKKAE=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4MNlfLrICXgYxECxWOXb5l1TCscUD7M0+tpuoilt23mHMnGVi FSQsNHa/qkaNW1Hrf+DtGIpZDZJ1/DFk0BdtV642acKSbDkUZ2t9OiQjxQwUv/Ph7BA= X-Gm-Gg: ATEYQzxD+MPGFAQxVvKWVqXLHF39wWQTjd3cEJH7yRzRocS/QO933b4cnk7JGsVOiHS mp71QHtZSY9opeOQBRQf9YyaEDzNTmp4+SB4SmmC0IdXXSrml37xveTFNteA3zFo7QSy58Qfh5k kFSecYg6ltKtzHCdJf78TGwrmDod7zwovjOICLrytt91o8E+hJduNH6qSJtjsG3YqrHsCLu1fkK jKGzdWM1Ysjhk0Mx6Egv8/QmmqboTDxFHGQQXE/J+VgcJoLgwGp2xt5GWa+UoIrm0wI55KMrmzj InSIdWK7o0imEcCLp4quUMBcS7l6pYiYbZjOh6+k3+rXa+7sS7RR5lUB9c98M2IlZKHmEz6xOO1 JNBi3tKWqKg0+3DOkQlcvGmBApSqwvT+wo7eD3N3SCvfC7q9gfyJnrnIAoKlpmpWA7e94gdOSUS Go8Yobd+kDHpW0vO+WczoB1/z6DcEK9RNhM5WO77Md1oyPLrtA1RjJ9iT3nprH9JIDStn5k2vyu OgT0IljaYmGte4Dtxc= X-Received: by 2002:a05:620a:2892:b0:8ca:1240:4991 with SMTP id af79cd13be357-8cbc8df1e6amr380289985a.45.1772204136082; Fri, 27 Feb 2026 06:55:36 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-112-119.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.112.119]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8cbbf71a8cesm491603885a.38.2026.02.27.06.55.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 06:55:35 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1vvzFe-000000016PX-3Q45; Fri, 27 Feb 2026 10:55:34 -0400 Date: Fri, 27 Feb 2026 10:55:34 -0400 From: Jason Gunthorpe To: Leon Romanovsky Cc: Cheng Xu , "Li,Rongqing(ACG CCN)" , Kai Shen , "linux-rdma@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: =?utf-8?B?562U5aSNOiBb5aSW6YOo6YKu5Lu2?= =?utf-8?B?XSBSZTogW1BBVENIXVtyZG1hLW5leHQ=?= =?utf-8?Q?=5D?= RDMA/erdma: Use NUMA-aware allocation for MTT tables Message-ID: <20260227145534.GL44359@ziepe.ca> References: <20260225085143.1721-1-lirongqing@baidu.com> <7cfd31d3-fe40-8b2d-cea8-14748db5f35b@linux.alibaba.com> <81eac7dd27d344b59da16bd4cef7bc77@baidu.com> <39e148d1-6a56-863f-8126-e92d452b3106@linux.alibaba.com> <20260226070954.GC12611@unreal> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260226070954.GC12611@unreal> On Thu, Feb 26, 2026 at 09:09:54AM +0200, Leon Romanovsky wrote: > So why do we need this patch? The xxx_node() functions are useful when you > need to force allocation on a specific NUMA node. In most cases, a plain > kmalloc() will allocate memory on the same node as 'struct erdma_dev *dev', > which typically matches the PCI device's NUMA node. I think a naked kmalloc allocates memory on the numa node of the thread that calls it, which is not the dev's node. IMHO it is best practice to allocate DMA'able memory from the NUMA node of the struct device. Jason