From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f98.google.com (mail-dl1-f98.google.com [74.125.82.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F238E3346A6 for ; Sat, 28 Feb 2026 07:28:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.98 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772263684; cv=none; b=ulmsk2JTq7ko8p3VAS1kqPpagS7LjS8ZHX93dxYHO5skHv2F3qR9MDw8CBVE9UME/ms8qGQMqCmGdSKNsbZEpAJeqvqXbqTggXftLIZk0KpaQmhki2MwzYC6HEqgjgOY8fW8vy/xf0FOUl/NcyBaA3SHQVGXWbcnnmeRaNANA9U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772263684; c=relaxed/simple; bh=JxO81/weFyc459OMqAugvZdWK5EbJ/Ld7je/eSdGL+A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hBWhoXsXdSV6jFOuBmaf6bos9ysqRI7OwZ79n8JvtT3ZX4UXJywV0ErmoIiwKJLipp2dlnWZ0/dAXueCntYG0V8s00zSS84J1Up+kH9N+aYxaToxzfUwL/ARAFETHMZ9Ili0XxvQxuJ2347UajK6f57cePbFsYbWjYcLDRV9Fic= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=UwNk9hhx; arc=none smtp.client-ip=74.125.82.98 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="UwNk9hhx" Received: by mail-dl1-f98.google.com with SMTP id a92af1059eb24-12732165d1eso3035021c88.1 for ; Fri, 27 Feb 2026 23:28:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772263682; x=1772868482; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FLbZWpd5u/NFnfx5DlhA19ecuXsYw/JuQ0/iZQbB610=; b=YdTyoQXnSvxUSs3Z9cHpdsUWz5nYDtgw91GkM0CnOc8XWmujYSbxbIuYPrqnmC5pNI VDpCntXfFE0A3HuvjLvea1f6Hdn57CA8fQdLWM95oYRXXVXLYcj54NZ2tceU0bdcC42n UgEZg7/1p1n51K1Ncq4QmmIcpX+0oNIQC3fjUsxsXlzUDhtqWIgL6FJrQ753/0Bz4qUq q6bJvM8C498DkiOcSGvoFTdDe6wUm/3azmaK6yedNMe2Pq/FboSL9MusKajjS5uF3yL9 zYkGtgn9jwE5X0r/DjRvUrVxhtXZZ27FK2avmH6QP6E24b4luYmwvQPWaxIgVwexBGGD HVJQ== X-Forwarded-Encrypted: i=1; AJvYcCXbFA/0nybgqo6RhXgxoDUGCrso327OQ6ZA3Smbkb34aCaFJno2fxIXFW/sACy9j7B0b/1iGIUirwkObLI=@vger.kernel.org X-Gm-Message-State: AOJu0YwcFgK0Vb4o/9aQSRpcgw7adXXFU4h5/NyI6bqOVFU+ozubrHJW Ztgy4CfhRjwCJlXf5WU9uPcwkxFNffh7gxgoc6ppV2VnYO8/66g8qaLCqN4x/uO0hDhU4Zrygpz tYuRnGZUMun80d0N344Y4pvoB+hMb0pf6jjRgvvk94wqugmVLY4j40DgV1L/0LIR3we3kpn7zGz fbY0CA10Y7C212JUzi3LVR72NRHSwSXPmpEONsmglVm+0FtMw+zMs9r1Vb58hUHEVMh3i6Mw+l/ l4zXAjaxT7e4bCFRrSaJ4TSRQ== X-Gm-Gg: ATEYQzzU7EZ6ImZwfAzVgUV7a4mffPQ3p4TBOvkJ2Q0mvjm4gJq34XzBxW2JKoFgVk6 nssfIa8GWd0ouAe+1/YXtl5zDTFTjr5pKxibLm1WIIJ/TK7v74RMniHklvobN2I1YGRfNR5MPH0 696bVPiTd1RcUa45XnPp3PQUI4WsI9Th6m7EGw6FSlkHlN2suhLuiivdoSMZ9Ci9/Mmcirwa330 Qi0UL2TvgeN3uhaPuPcLDvKG6KWZ3yhVdaWUIAtbspewrqfjOknYEAyCwyHagD+/qw7oVRk+Lf6 P2IXU5wTAqYC989IxxfeYbJKTNfqKc+UrNsoTjysil9vnQD8bTNf8kkbg1rRs1iXriZidGJagLa jeVjMGkjsiwwDOafZL0UfTH20/1kHlsIq+98Tb0shhBtPfNnGB/GvANYXk2ThuN35LisNi+8nrT GDrLaBRjP+q0KX6NIBZ9OBYOAfnjL4tgfUJfWnpFoSbzvrVr9nrMYgphv5oZ8o7Zu31A== X-Received: by 2002:a05:7022:90c:b0:119:e56b:989b with SMTP id a92af1059eb24-1278fbf2698mr2026244c88.2.1772263681772; Fri, 27 Feb 2026 23:28:01 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-103.dlp.protect.broadcom.com. [144.49.247.103]) by smtp-relay.gmail.com with ESMTPS id 5a478bee46e88-2bdd1f7eeb3sm840960eec.9.2026.02.27.23.28.01 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Feb 2026 23:28:01 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c70b75aea3aso1539950a12.0 for ; Fri, 27 Feb 2026 23:28:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1772263680; x=1772868480; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FLbZWpd5u/NFnfx5DlhA19ecuXsYw/JuQ0/iZQbB610=; b=UwNk9hhxpBboU/7fH1zZh2Ntg/PE+IyOh3sfkhk4VKgww4iD2D4uU//QlItvgKt0Jy wS5Ok6mVwfkgLhfEziRNU2IeRQxSopMb8N4jDDqns7l46MCBXnySYoxd98WVEioYoPal G3fsYVzeX/d79WHsVO7rn5SeXbJEo/EqdK+fM= X-Forwarded-Encrypted: i=1; AJvYcCUy2Odgum627lLJxonPdS6hjxzkYPR8DyyfOElNrKtrry/t/0E/jaG1Nu3NpqJLdbL4yZ3HWA05483HVTs=@vger.kernel.org X-Received: by 2002:a05:6a00:f04:b0:81f:2b25:ca73 with SMTP id d2e1a72fcca58-8274d9eabbemr5703034b3a.38.1772263679746; Fri, 27 Feb 2026 23:27:59 -0800 (PST) X-Received: by 2002:a05:6a00:f04:b0:81f:2b25:ca73 with SMTP id d2e1a72fcca58-8274d9eabbemr5703022b3a.38.1772263679189; Fri, 27 Feb 2026 23:27:59 -0800 (PST) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82739ff1ca9sm6809267b3a.36.2026.02.27.23.27.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 23:27:58 -0800 (PST) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy , Ajit Kumar Khaparde Subject: [PATCH net-next v3 1/8] bng_en: add per-PF workqueue, timer, and slow-path task Date: Sat, 28 Feb 2026 12:57:08 +0530 Message-ID: <20260228072715.1632280-2-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260228072715.1632280-1-bhargava.marreddy@broadcom.com> References: <20260228072715.1632280-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Add a dedicated single-thread workqueue and a timer for each PF to drive deferred slow-path work such as link event handling and stats collection. The timer is stopped via timer_delete_sync() when interrupts are disabled and restarted on open. The open and close paths now start and drain these resources. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta Reviewed-by: Ajit Kumar Khaparde --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 87 ++++++++++++++++++- .../net/ethernet/broadcom/bnge/bnge_netdev.h | 13 ++- 2 files changed, 98 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c index a20dc3ca640..ee77b29f5b9 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -101,6 +101,45 @@ static int bnge_alloc_ring_stats(struct bnge_net *bn) return rc; } +static void bnge_timer(struct timer_list *t) +{ + struct bnge_net *bn = timer_container_of(bn, t, timer); + struct bnge_dev *bd = bn->bd; + + if (!netif_running(bn->netdev) || + !test_bit(BNGE_STATE_OPEN, &bd->state)) + return; + + /* Periodic work added by later patches */ + + mod_timer(&bn->timer, jiffies + bn->current_interval); +} + +static void bnge_sp_task(struct work_struct *work) +{ + struct bnge_net *bn = container_of(work, struct bnge_net, sp_task); + struct bnge_dev *bd = bn->bd; + + set_bit(BNGE_STATE_IN_SP_TASK, &bn->state); + /* Ensure sp_task state is visible before checking BNGE_STATE_OPEN */ + smp_mb__after_atomic(); + if (!test_bit(BNGE_STATE_OPEN, &bd->state)) { + clear_bit(BNGE_STATE_IN_SP_TASK, &bn->state); + return; + } + + /* Event handling work added by later patches */ + + /* Ensure all sp_task work is done before clearing the state */ + smp_mb__before_atomic(); + clear_bit(BNGE_STATE_IN_SP_TASK, &bn->state); +} + +static bool bnge_drv_busy(struct bnge_net *bn) +{ + return test_bit(BNGE_STATE_IN_SP_TASK, &bn->state); +} + static void bnge_free_nq_desc_arr(struct bnge_nq_ring_info *nqr) { struct bnge_ring_struct *ring = &nqr->ring_struct; @@ -2507,6 +2546,9 @@ static int bnge_open_core(struct bnge_net *bn) bnge_enable_int(bn); bnge_tx_enable(bn); + + mod_timer(&bn->timer, jiffies + bn->current_interval); + return 0; err_free_irq: @@ -2542,6 +2584,12 @@ static void bnge_close_core(struct bnge_net *bn) bnge_tx_disable(bn); clear_bit(BNGE_STATE_OPEN, &bd->state); + /* Ensure BNGE_STATE_OPEN is cleared before checking drv_busy */ + smp_mb__after_atomic(); + while (bnge_drv_busy(bn)) + msleep(20); + + timer_delete_sync(&bn->timer); bnge_shutdown_nic(bn); bnge_disable_napi(bn); bnge_free_all_rings_bufs(bn); @@ -2690,6 +2738,23 @@ static void bnge_init_ring_params(struct bnge_net *bn) bn->netdev->cfg->hds_thresh = max(BNGE_DEFAULT_RX_COPYBREAK, rx_size); } +static struct workqueue_struct * +bnge_create_workqueue_thread(struct bnge_dev *bd, const char *thread_name) +{ + struct workqueue_struct *wq; + char *wq_name; + + wq_name = kasprintf(GFP_KERNEL, "%s-%s", thread_name, + dev_name(bd->dev)); + if (!wq_name) + return NULL; + + wq = create_singlethread_workqueue(wq_name); + kfree(wq_name); + + return wq; +} + int bnge_netdev_alloc(struct bnge_dev *bd, int max_irqs) { struct net_device *netdev; @@ -2774,6 +2839,17 @@ int bnge_netdev_alloc(struct bnge_dev *bd, int max_irqs) if (bd->tso_max_segs) netif_set_tso_max_segs(netdev, bd->tso_max_segs); + INIT_WORK(&bn->sp_task, bnge_sp_task); + timer_setup(&bn->timer, bnge_timer, 0); + bn->current_interval = BNGE_TIMER_INTERVAL; + + bn->bnge_pf_wq = bnge_create_workqueue_thread(bd, "bnge_pf_wq"); + if (!bn->bnge_pf_wq) { + netdev_err(netdev, "Unable to create workqueue.\n"); + rc = -ENOMEM; + goto err_netdev; + } + bn->rx_ring_size = BNGE_DEFAULT_RX_RING_SIZE; bn->tx_ring_size = BNGE_DEFAULT_TX_RING_SIZE; bn->rx_dir = DMA_FROM_DEVICE; @@ -2789,11 +2865,13 @@ int bnge_netdev_alloc(struct bnge_dev *bd, int max_irqs) rc = register_netdev(netdev); if (rc) { dev_err(bd->dev, "Register netdev failed rc: %d\n", rc); - goto err_netdev; + goto err_free_workq; } return 0; +err_free_workq: + destroy_workqueue(bn->bnge_pf_wq); err_netdev: free_netdev(netdev); return rc; @@ -2802,8 +2880,15 @@ int bnge_netdev_alloc(struct bnge_dev *bd, int max_irqs) void bnge_netdev_free(struct bnge_dev *bd) { struct net_device *netdev = bd->netdev; + struct bnge_net *bn; + + bn = netdev_priv(netdev); unregister_netdev(netdev); + + cancel_work_sync(&bn->sp_task); + destroy_workqueue(bn->bnge_pf_wq); + free_netdev(netdev); bd->netdev = NULL; } diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h index 70f1a7c2481..b00d2e3922d 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -224,6 +224,13 @@ struct bnge_tpa_info { #define BNGE_NQ_HDL_TYPE(hdl) (((hdl) & BNGE_NQ_HDL_TYPE_MASK) >> \ BNGE_NQ_HDL_TYPE_SHIFT) +enum bnge_net_state { + BNGE_STATE_NAPI_DISABLED, + BNGE_STATE_IN_SP_TASK, +}; + +#define BNGE_TIMER_INTERVAL HZ + struct bnge_net { struct bnge_dev *bd; struct net_device *netdev; @@ -281,13 +288,17 @@ struct bnge_net { u32 stats_coal_ticks; unsigned long state; -#define BNGE_STATE_NAPI_DISABLED 0 u32 msg_enable; u16 max_tpa; __be16 vxlan_port; __be16 nge_port; __be16 vxlan_gpe_port; + + unsigned int current_interval; + struct timer_list timer; + struct workqueue_struct *bnge_pf_wq; + struct work_struct sp_task; }; #define BNGE_DEFAULT_RX_RING_SIZE 511 -- 2.47.3