From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f225.google.com (mail-yw1-f225.google.com [209.85.128.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C890F36CE0D for ; Sat, 28 Feb 2026 07:28:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.225 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772263714; cv=none; b=FlOPR8bgfjJ+QYwrF9oyv57gi4ws3c//KHCneOp4vpKRGbSufj3+G+wxrE7J+k211J8vSyLpOr2/2wT7y3mxrNKbkmRCiLcFx40WjlF3vQvcOWKy6zxCrTfsBXe7i4HhttP43TztOZJtkxCufE+Xg78cnvitN54oOuIBzmKvQUQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772263714; c=relaxed/simple; bh=ASJM102y1jQFLW2GfzBOmODT1mo/QBTC8rGfxdp0bGE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=trM3Nf86VQacfAngTRp5VIn1XSXFI4AiALw47yzWDbKdD02yin24a3NB/tBWhfRfuj+iZZo421gnrd97H6MUoKbPC6u5HNiLIo1JQqMpSZcthPnqxU1rxtOVZUH5fYRkJ2Y4zLjmPLsa3VOJRuzm/Q8+SJHvf57V5BkvS1UyBW0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=Zo+tnzz2; arc=none smtp.client-ip=209.85.128.225 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Zo+tnzz2" Received: by mail-yw1-f225.google.com with SMTP id 00721157ae682-7986e0553b0so25675417b3.2 for ; Fri, 27 Feb 2026 23:28:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772263712; x=1772868512; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lDjphwjEKVTy/r//tJDIih4JMCHQoRzkSENJ5Jl96Jc=; b=PX3+kNNTgQPIC72UNrAou580JO+sHEjtNq2ub7jwZ4hV/qFPljJa5JFPz0LmxTENkc STH21xOpNUeKIYLuxe1cU1wZ3ZHgqnNB4jDiY0cCZb/s5Kea7EDfWsv1YF9I3QDmizLL cHq5jnLJOoawF40FxelfiEFPTwwcUfGDO/SNIeE9zTpB3qA1EuSgurMitnoudKMyUlTP +a5W6eE4LKQbobfSgVariV1uNQKC+hjDhzy7s8kuapklVVJ/B2vCxdhRgtPRmvK7zMhy MBmJrjcf98xBT84x0q7wLMHxZWRiZZcQirKoKl6jwt413nAb8CdJUSWEWMTq3J+r7kej owlQ== X-Forwarded-Encrypted: i=1; AJvYcCVxdm1+IYojo5jbM+K7dxL6E1uCXW+CS0xNtnm28Vobk/T8b0KfqVOn9Zp86c+591Sh8e++w1dM0S62z9U=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2PjpegzaWDyaTQTMKlWLgT2gHiXJ0LlU0d8sJxYVFJof+22wD ByZWmG4hOT4dv7FllhuJOtmwxXTeQmE9+Dreq+QwiMgqwbh2ONYGFHPFAnka6xVm1oOuzqlSZ6T 2Tns1D7U2Gx1xcRjJVC9v7i1y3dTiQ5RTeDu0Rk9hqyWM3qetrPe+EnJCrEcBhHMAGYqI/0tdFC 8ajSdS0/6D11zyAvXxgiNfjN/0cVS/emeULHDWojk5L8udRwOcXNIImA1rnXgMhEP+jvWk83uyM KWoT6upo99Qp/L++NIN8GwIeg== X-Gm-Gg: ATEYQzzlRFsbC+Q70Y4jWuMfdyBzF+8V2AW2kllAH4K1goJRUyl9vyIYjpI+6zmZ4w7 eZIVuG88wRhVFk5VJCyOe02FfMCB3bsJ/uaH5tyqewxwHUPLFFxE1R7zCjGYCUH11c7zOq8YEVW fAJfhTta1pqyCwjvVnOCckZmlHYXFislBTod0rWO5zs+uHk+QwlvxmPKjYpcK1q1x0qu8Ud5Mbj TFyUbv0Rci5sWuw98H0y5HjRvH+HFY08iSLC1rTWnzE25GnVkZ/i8RacsXd7vZzS0iDajJVZJiO tazvGBoyq5omrazf871GzVmjav6Rsw6EMvyOz74k590EWUQZw+ZGuQUwQPB0keqfgN08XaVkzZO 3f2eMf/ZpmxaNjWeZlQrkwzyxroBcpN+iwqqlOQ2eskbfBRlhQNvF700wHTNykt1YEXUhlq3K64 Tfv0IJHCy8odHf4yfRDBhpdAmwzaJ3i6wiJcLWNoJxm2tWJXh5S8rSOxa9TtBD X-Received: by 2002:a05:690c:e3ed:b0:796:312a:b817 with SMTP id 00721157ae682-7988545eb44mr52124977b3.9.1772263711790; Fri, 27 Feb 2026 23:28:31 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-0.dlp.protect.broadcom.com. [144.49.247.0]) by smtp-relay.gmail.com with ESMTPS id 00721157ae682-79876aba1a1sm8546037b3.6.2026.02.27.23.28.30 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Feb 2026 23:28:31 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-824af3c6c0cso1233745b3a.3 for ; Fri, 27 Feb 2026 23:28:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1772263710; x=1772868510; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lDjphwjEKVTy/r//tJDIih4JMCHQoRzkSENJ5Jl96Jc=; b=Zo+tnzz26aJjMldvZT2H7JQP9roOqbma9S1vm1/Bsmh285PWDTui82urEmfJjmmYt6 YOhLf59Lew280B53Gdt2ZCauV9olEoAb2ujymBqoz9YORfSmJ1iRouRykqCu9EnPZKiX iYSguEcNTo/iVi9Ple/DObJhFP+/n7qtP7xC0= X-Forwarded-Encrypted: i=1; AJvYcCXvUjCOgOKGMzuEgzzI98nhn3WBT2c6qAkGISvY4cEeIJn12BaiSHpqnXN2D11AcjnCKIyEFif7pLimpUQ=@vger.kernel.org X-Received: by 2002:a05:6a00:9295:b0:7e8:43f5:bd39 with SMTP id d2e1a72fcca58-8274d9e66c5mr5957398b3a.37.1772263709799; Fri, 27 Feb 2026 23:28:29 -0800 (PST) X-Received: by 2002:a05:6a00:9295:b0:7e8:43f5:bd39 with SMTP id d2e1a72fcca58-8274d9e66c5mr5957383b3a.37.1772263709395; Fri, 27 Feb 2026 23:28:29 -0800 (PST) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82739ff1ca9sm6809267b3a.36.2026.02.27.23.28.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 23:28:29 -0800 (PST) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy , Ajit Kumar Khaparde Subject: [PATCH net-next v3 8/8] bng_en: implement ndo_get_stats64 Date: Sat, 28 Feb 2026 12:57:15 +0530 Message-ID: <20260228072715.1632280-9-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260228072715.1632280-1-bhargava.marreddy@broadcom.com> References: <20260228072715.1632280-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Implement the ndo_get_stats64 callback to report aggregate network statistics. The driver gathers these by accumulating the per-ring counters into the provided rtnl_link_stats64 structure. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta Reviewed-by: Ajit Kumar Khaparde --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 110 +++++++++++++++++- .../net/ethernet/broadcom/bnge/bnge_netdev.h | 1 + 2 files changed, 109 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c index 29c072e38a7..017bb68f71f 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -2924,6 +2924,102 @@ static int bnge_shutdown_nic(struct bnge_net *bn) return 0; } +static void bnge_get_ring_stats(struct bnge_dev *bd, + struct rtnl_link_stats64 *stats) +{ + struct bnge_net *bn = netdev_priv(bd->netdev); + int i; + + for (i = 0; i < bd->nq_nr_rings; i++) { + struct bnge_napi *bnapi = bn->bnapi[i]; + struct bnge_nq_ring_info *nqr = &bnapi->nq_ring; + u64 *sw = nqr->stats.sw_stats; + + stats->rx_packets += BNGE_GET_RING_STATS64(sw, rx_ucast_pkts); + stats->rx_packets += BNGE_GET_RING_STATS64(sw, rx_mcast_pkts); + stats->rx_packets += BNGE_GET_RING_STATS64(sw, rx_bcast_pkts); + + stats->tx_packets += BNGE_GET_RING_STATS64(sw, tx_ucast_pkts); + stats->tx_packets += BNGE_GET_RING_STATS64(sw, tx_mcast_pkts); + stats->tx_packets += BNGE_GET_RING_STATS64(sw, tx_bcast_pkts); + + stats->rx_bytes += BNGE_GET_RING_STATS64(sw, rx_ucast_bytes); + stats->rx_bytes += BNGE_GET_RING_STATS64(sw, rx_mcast_bytes); + stats->rx_bytes += BNGE_GET_RING_STATS64(sw, rx_bcast_bytes); + + stats->tx_bytes += BNGE_GET_RING_STATS64(sw, tx_ucast_bytes); + stats->tx_bytes += BNGE_GET_RING_STATS64(sw, tx_mcast_bytes); + stats->tx_bytes += BNGE_GET_RING_STATS64(sw, tx_bcast_bytes); + + stats->rx_missed_errors += + BNGE_GET_RING_STATS64(sw, rx_discard_pkts); + + stats->multicast += BNGE_GET_RING_STATS64(sw, rx_mcast_pkts); + + stats->tx_dropped += BNGE_GET_RING_STATS64(sw, tx_error_pkts); + + stats->rx_dropped += + nqr->sw_stats->rx.rx_netpoll_discards + + nqr->sw_stats->rx.rx_oom_discards; + } +} + +static void bnge_add_prev_stats(struct bnge_net *bn, + struct rtnl_link_stats64 *stats) +{ + struct rtnl_link_stats64 *prev_stats = &bn->net_stats_prev; + + stats->rx_packets += prev_stats->rx_packets; + stats->tx_packets += prev_stats->tx_packets; + stats->rx_bytes += prev_stats->rx_bytes; + stats->tx_bytes += prev_stats->tx_bytes; + stats->rx_missed_errors += prev_stats->rx_missed_errors; + stats->multicast += prev_stats->multicast; + stats->rx_dropped += prev_stats->rx_dropped; + stats->tx_dropped += prev_stats->tx_dropped; +} + +static void bnge_get_stats64(struct net_device *dev, + struct rtnl_link_stats64 *stats) +{ + struct bnge_net *bn = netdev_priv(dev); + struct bnge_dev *bd = bn->bd; + + rcu_read_lock(); + if (!test_bit(BNGE_STATE_OPEN, &bd->state)) { + rcu_read_unlock(); + *stats = bn->net_stats_prev; + return; + } + + bnge_get_ring_stats(bd, stats); + bnge_add_prev_stats(bn, stats); + + if (bn->flags & BNGE_FLAG_PORT_STATS) { + u64 *rx = bn->port_stats.sw_stats; + u64 *tx = bn->port_stats.sw_stats + + BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + + stats->rx_crc_errors = + BNGE_GET_RX_PORT_STATS64(rx, rx_fcs_err_frames); + stats->rx_frame_errors = + BNGE_GET_RX_PORT_STATS64(rx, rx_align_err_frames); + stats->rx_length_errors = + BNGE_GET_RX_PORT_STATS64(rx, rx_undrsz_frames) + + BNGE_GET_RX_PORT_STATS64(rx, rx_ovrsz_frames) + + BNGE_GET_RX_PORT_STATS64(rx, rx_runt_frames); + stats->rx_errors = + BNGE_GET_RX_PORT_STATS64(rx, rx_false_carrier_frames) + + BNGE_GET_RX_PORT_STATS64(rx, rx_jbr_frames); + stats->collisions = + BNGE_GET_TX_PORT_STATS64(tx, tx_total_collisions); + stats->tx_fifo_errors = + BNGE_GET_TX_PORT_STATS64(tx, tx_fifo_underruns); + stats->tx_errors = BNGE_GET_TX_PORT_STATS64(tx, tx_err); + } + rcu_read_unlock(); +} + static void bnge_close_core(struct bnge_net *bn) { struct bnge_dev *bd = bn->bd; @@ -2931,14 +3027,23 @@ static void bnge_close_core(struct bnge_net *bn) bnge_tx_disable(bn); clear_bit(BNGE_STATE_OPEN, &bd->state); - /* Ensure BNGE_STATE_OPEN is cleared before checking drv_busy */ - smp_mb__after_atomic(); + /* No explicit barrier needed - synchronize_rcu() provides full + * ordering between clear_bit() above and drv_busy() below. + */ + synchronize_rcu(); while (bnge_drv_busy(bn)) msleep(20); timer_delete_sync(&bn->timer); bnge_shutdown_nic(bn); bnge_disable_napi(bn); + + /* Save ring stats before shutdown */ + if (bn->bnapi) { + bnge_get_ring_stats(bd, &bn->net_stats_prev); + bnge_get_ring_err_stats(bn, &bn->ring_err_stats_prev); + } + bnge_free_all_rings_bufs(bn); bnge_free_irq(bn); bnge_del_napi(bn); @@ -2988,6 +3093,7 @@ static const struct net_device_ops bnge_netdev_ops = { .ndo_open = bnge_open, .ndo_stop = bnge_close, .ndo_start_xmit = bnge_start_xmit, + .ndo_get_stats64 = bnge_get_stats64, .ndo_features_check = bnge_features_check, }; diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h index f160ba9b69c..5a2defa970c 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -382,6 +382,7 @@ struct bnge_net { u64 flags; + struct rtnl_link_stats64 net_stats_prev; struct bnge_total_ring_err_stats ring_err_stats_prev; struct bnge_stats_mem port_stats; -- 2.47.3