From: Andrew Morton <akpm@linux-foundation.org>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: Baoquan He <bhe@redhat.com>, Vivek Goyal <vgoyal@redhat.com>,
Dave Young <dyoung@redhat.com>,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crash_dump: Remove redundant less-than-zero check
Date: Sat, 28 Feb 2026 11:02:49 -0800 [thread overview]
Message-ID: <20260228110249.8a4d13b872e7cf3ca75e11d0@linux-foundation.org> (raw)
In-Reply-To: <20260228085136.861971-2-thorsten.blum@linux.dev>
On Sat, 28 Feb 2026 09:51:36 +0100 Thorsten Blum <thorsten.blum@linux.dev> wrote:
> 'key_count' is an 'unsigned int' and cannot be less than zero. Remove
> the redundant condition.
>
umm. OK.
> --- a/kernel/crash_dump_dm_crypt.c
> +++ b/kernel/crash_dump_dm_crypt.c
> @@ -115,7 +115,7 @@ static int restore_dm_crypt_keys_to_thread_keyring(void)
>
> addr = dm_crypt_keys_addr;
> dm_crypt_keys_read((char *)&key_count, sizeof(key_count), &addr);
> - if (key_count < 0 || key_count > KEY_NUM_MAX) {
> + if (key_count > KEY_NUM_MAX) {
> kexec_dprintk("Failed to read the number of dm-crypt keys\n");
> return -1;
> }
iirc Linus has said "this is OK". The compiler will eliminate it and
the code still works if the type is later changed to signed.
prev parent reply other threads:[~2026-02-28 19:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-28 8:51 Thorsten Blum
2026-02-28 19:02 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260228110249.8a4d13b872e7cf3ca75e11d0@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=dyoung@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thorsten.blum@linux.dev \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®