From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B562A424E72; Sat, 28 Feb 2026 17:46:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772300785; cv=none; b=D1widm/6krh2k6fErS5jA3JypEzAPDHp45P84LHIiS/AKuoP8TStc+R4rYQDgjv6WS6BUHkNcHQMQTYozUzhmA6cHLttBnOtFCpyagqHnx4ewnv6x3s89uTkUR1UGgysuCgxSb5tQk8Ga0bE6+6uiHVzln6s63gdqu2c66YCh6Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772300785; c=relaxed/simple; bh=THbQHgaq61jho7D5uWewRwo0XMnNLOZ1XtokK5cfmRY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oFXQr27WXZPOLTd3V1GoZ5h+AgQCUsM+T+nOHNohVkEyE2J1YH2bl2sqYMDla9iq2hJ3cvEG6yq3EObZwYN/NgWo3nj39J8tYTToWXu3Ib0LEt2pW2UjoRdvRoi1qWmUEBwFVGXmfExRGy/ptckl6hUDDkMgy3ib9kHFryWNPbA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CIvw8Pqk; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CIvw8Pqk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7627C19424; Sat, 28 Feb 2026 17:46:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772300785; bh=THbQHgaq61jho7D5uWewRwo0XMnNLOZ1XtokK5cfmRY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CIvw8Pqks0Rd71lpJzVHUGyjnRZw9HNHYcOnMiJpIgr8CTA6/RNIir4Wu6nR+Unfx yBRx7jo+VvrkSlRsrFMwfF3rGgXPmTVk0hniIvvxk74ayiUxzH/lvDTpvv5AUw6bnb 3RLNpscfvUGm8eG32C1UYW1KmlOd4aYnporpgfSizD0LSSyxR1BWo7JRveATxdvqmb z+WCbBMnDqd1B+zD/tQ0uYhHU9she1amtmjk+7SGOb+au+m38OqQlCuOlvITxmj5Ly 9yqV/KQ7+uCe7erdUahDeoFDwRG9UqUMlhbKeVS//yVo6+pj7jNIzb/h1XYPQGiAPO LcuT+0o7vsi2Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Ethan Tidmore , Bartosz Golaszewski , Sasha Levin Subject: [PATCH 6.19 817/844] gpio: nomadik: Add missing IS_ERR() check Date: Sat, 28 Feb 2026 12:32:10 -0500 Message-ID: <20260228173244.1509663-818-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260228173244.1509663-1-sashal@kernel.org> References: <20260228173244.1509663-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Ethan Tidmore [ Upstream commit 58433885ee99e8c96757e82ccf6d50646c4dfe09 ] The function gpio_device_get_desc() can return an error pointer and is not checked for one. Add check for error pointer. Fixes: ddeb66d2cb10f ("gpio: nomadik: don't print out global GPIO numbers in debugfs callbacks") Cc: stable@vger.kernel.org Signed-off-by: Ethan Tidmore Link: https://patch.msgid.link/20260214044531.43539-1-ethantidmore06@gmail.com Signed-off-by: Bartosz Golaszewski Signed-off-by: Sasha Levin --- drivers/gpio/gpio-nomadik.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpio/gpio-nomadik.c b/drivers/gpio/gpio-nomadik.c index 97c5cd33279d5..e22b713166d71 100644 --- a/drivers/gpio/gpio-nomadik.c +++ b/drivers/gpio/gpio-nomadik.c @@ -430,6 +430,9 @@ void nmk_gpio_dbg_show_one(struct seq_file *s, struct pinctrl_dev *pctldev, #ifdef CONFIG_PINCTRL_NOMADIK if (mode == NMK_GPIO_ALT_C && pctldev) { desc = gpio_device_get_desc(chip->gpiodev, offset); + if (IS_ERR(desc)) + return; + mode = nmk_prcm_gpiocr_get_mode(pctldev, desc_to_gpio(desc)); } #endif -- 2.51.0