From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEC9642A7B8; Sat, 28 Feb 2026 17:46:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772300797; cv=none; b=IXNmh6leUZQkpkYaZZe4XxbDnpI2k/FK+zuDOXP3qKRmGG7I3BPGvm59JZ0iPkTH9Nn0WWKd0yMB9PABL4yrkASyUJT01uyVriwXSXBMZEsJ3F+BByShC75Nwt1HycDE0SVhCrfQLdlC5P6CekvGpxqGvqzakwSLdbaMGggieuQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772300797; c=relaxed/simple; bh=FoIjzdS00i5VPlniV9Kw+gfba6hiPgszo8/fC9hnjXc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cjqE8AKKNRo8cbMi5tLzuPYYFXbt+hXRnXxNx8OH02+1Jh/MDvBwJYb2VeYqqgD2mmmvT+3KmjN+iCA1MbQag9Anc7PlQXFzVhI22I3cBkXLC53/Y9I1Mxxf2H/rVFphGaQ1a3M1jjeUElYC/++leIHdDAi9atBi4VlMstigK00= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lx3iMF5Y; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lx3iMF5Y" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E99CC19423; Sat, 28 Feb 2026 17:46:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772300797; bh=FoIjzdS00i5VPlniV9Kw+gfba6hiPgszo8/fC9hnjXc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lx3iMF5YpLjv0q/ObAm9Z7z0RcKy3WhI/uJPV+9///1LO/2Q87jtRjwzBO+w/ANaQ 3LK1PFh84jE1d41gHu3tFCKCnreY1JO4ETIdmERs0cBfkXfV7qxC5ARjAgfwfiZJDY aqSn7NH70zlBam+R3jEceu9LWORGwcyMbRR8RW+MPKPVCCO6z4OLW3sPeHdUDPHZZ8 fwC9XqhYZmdGjoVmTysjVoAHdbqUslnrSjH9KEvxHhBHzJNENQ6LvyoMP/YluI9jpt KMuLCtOfeHC4ShVK7fO7BelGK6xiu+hgPXOss7xLDQaDZJM9rMZC0FJRl7LTufh5WN auCI/U49FOGGQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Benno Lossin , Miguel Ojeda , Sasha Levin Subject: [PATCH 6.19 830/844] rust: pin-init: replace clippy `expect` with `allow` Date: Sat, 28 Feb 2026 12:32:23 -0500 Message-ID: <20260228173244.1509663-831-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260228173244.1509663-1-sashal@kernel.org> References: <20260228173244.1509663-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Benno Lossin [ Upstream commit a58b8764aed9648357b1c5b6368c9943ba33b7f9 ] `clippy` has changed behavior in [1] (Rust 1.95) where it no longer warns about the `let_and_return` lint when a comment is placed between the let binding and the return expression. Nightly thus fails to build, because the expectation is no longer fulfilled. Thus replace the expectation with an `allow`. [ The errors were: error: this lint expectation is unfulfilled --> rust/pin-init/src/lib.rs:1279:10 | 1279 | #[expect(clippy::let_and_return)] | ^^^^^^^^^^^^^^^^^^^^^^ | = note: `-D unfulfilled-lint-expectations` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unfulfilled_lint_expectations)]` error: this lint expectation is unfulfilled --> rust/pin-init/src/lib.rs:1295:10 | 1295 | #[expect(clippy::let_and_return)] | ^^^^^^^^^^^^^^^^^^^^^^ - Miguel ] Link: https://github.com/rust-lang/rust-clippy/pull/16461 [1] Signed-off-by: Benno Lossin Cc: stable@vger.kernel.org # Needed in 6.18.y and later. Link: https://patch.msgid.link/20260215132232.1549861-1-lossin@kernel.org Signed-off-by: Miguel Ojeda Signed-off-by: Sasha Levin --- rust/pin-init/src/lib.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rust/pin-init/src/lib.rs b/rust/pin-init/src/lib.rs index 8dc9dd5ac6fd3..3da65db9e2dd3 100644 --- a/rust/pin-init/src/lib.rs +++ b/rust/pin-init/src/lib.rs @@ -1276,13 +1276,13 @@ unsafe fn __pinned_init(self, slot: *mut T) -> Result<(), E> { /// /// - `*mut U` must be castable to `*mut T` and any value of type `T` written through such a /// pointer must result in a valid `U`. -#[expect(clippy::let_and_return)] pub const unsafe fn cast_pin_init(init: impl PinInit) -> impl PinInit { // SAFETY: initialization delegated to a valid initializer. Cast is valid by function safety // requirements. let res = unsafe { pin_init_from_closure(|ptr: *mut U| init.__pinned_init(ptr.cast::())) }; // FIXME: remove the let statement once the nightly-MSRV allows it (1.78 otherwise encounters a // cycle when computing the type returned by this function) + #[allow(clippy::let_and_return)] res } @@ -1292,13 +1292,13 @@ unsafe fn __pinned_init(self, slot: *mut T) -> Result<(), E> { /// /// - `*mut U` must be castable to `*mut T` and any value of type `T` written through such a /// pointer must result in a valid `U`. -#[expect(clippy::let_and_return)] pub const unsafe fn cast_init(init: impl Init) -> impl Init { // SAFETY: initialization delegated to a valid initializer. Cast is valid by function safety // requirements. let res = unsafe { init_from_closure(|ptr: *mut U| init.__init(ptr.cast::())) }; // FIXME: remove the let statement once the nightly-MSRV allows it (1.78 otherwise encounters a // cycle when computing the type returned by this function) + #[allow(clippy::let_and_return)] res } -- 2.51.0