From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f45.google.com (mail-qv1-f45.google.com [209.85.219.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06FB71F4C8E for ; Sun, 1 Mar 2026 00:55:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772326523; cv=none; b=fRhhzJiKWi8moIGJSIBVkxX2Llv9oKw9GI0273LLLpAz2zljp30COQTRhqvHH2GPehzbWFqB0JgXe94lQwB9U3CVgA1m5QxeB+tqeJ39bYjlevskoPCm+nzIUzDsONegmDarD9D3CyyzYzMLiEkx7X7cc//AGzVjJsDpkF7GYv4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772326523; c=relaxed/simple; bh=GdYUHD4puWeOoOKtztcQ2Lq8iRfJfz7+aLgPfZpNVpg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=szoeO7aQwrtDdC6k/BIT62hm97g30ozGrb/ZWkpLNvfLSna29sKe0Twc+pOJ/te5zEle4rY0P/y+mvNdmhmzB+aVpDd3n+cL69i5rsdmhNhLjP4meCRxs99fDhXoJv+CSwaNb5xyWeq0vJuxIMTD6AReNC5+HdtGoz0gJ6yMnos= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gHhAFrQQ; arc=none smtp.client-ip=209.85.219.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gHhAFrQQ" Received: by mail-qv1-f45.google.com with SMTP id 6a1803df08f44-899c3441177so57044456d6.0 for ; Sat, 28 Feb 2026 16:55:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772326521; x=1772931321; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TT6X3GNyl/4X3+3IlxkqRIyQryOUKSzRU583uCJbsXE=; b=gHhAFrQQa8h9Ab4CUL9jfGUjn4OFg6tSGcwY/fYEZLMzQgCZjnSyFpdtE1yR6XBfRG TLTAJK4N71f5gKon1Qj9RGlmn9le376s8BR14sA06DFgWEUgmngXJLbPIaOFhmLiqC1A +eyDCSxOYCaz33PJUz1LyztVgUM79jm88G0DCNoJRnNrIGv6kVQbzC8V5eYo9SVu+4OC TZfleXbyfCfW4ZgerM9D+kEtrDA0MBd75pZG3xb4a05MWsNDOuJva9D9wcSPu+cwgb+Q n3q2ohemrifla7CMCT4y+UdUJ3GMNx1ff+C70UkQMoiHlIxZTeJ4POUB5vh/ARh4fd3t bwsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772326521; x=1772931321; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TT6X3GNyl/4X3+3IlxkqRIyQryOUKSzRU583uCJbsXE=; b=oR9jGdmaMJf1xF938Pael5oFNr+S1fxjneJmQIs6blEWrQFwfgaM4QvzcVm7grqZjQ KxYGORm007x/AYeuOLlIdAMJr+cmHQdGYCJexy3JFo9FtWpjCyuZ6hl608froElhjqBN U17H2Y1aQEPacgBcANQxoFWNpsY6Bj12JXtZOB+Nh+yaIPGHSGKMsrIXzUu2CEJgLZQg LNCgmDhoJxsF1+kK3a5tGCudhvYsm334wuUOzf3TiueqHOng7K+xt9FnVM9yvlFGJGOp WZJyItkmBvzlcc16LKXf0FMd2CuubBqC8Y0ZQPWS8BMHSybwiFQFzVhCTmsQrFWiEFw+ 6xyw== X-Forwarded-Encrypted: i=1; AJvYcCW10zUYvPfTj+W7wAY3TWPLGu5MR9W6VbcweeDVEWhRZdyjfKsIlhsFWb1iqIR6Yq3S+d7PiwTdprxsZsQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyVBweIAQiDpEzJcLiS8lEjr6Zmam/709w0F2uWecIS+6W9I3dj D13Sehs9yNfm9HNUPtgarkI02o3VbFdn/2vwVD221GSptdFB6NA3n58aSyPVeBkGojo= X-Gm-Gg: ATEYQzzt2umyk4+7ayEhNVfTXDXRq/ewIcmbH5+X5OX7eRQcjdXPVD7yIiz0qZK8Pyt m26C5XJMtU+r+wcbxpszRhicrdSW6+C4AJpSHQZzU8czQVtHuVzWPvzggfBso8UW/wKM7nYjL9W wONxRk1iqgrB5OAsib10Mk2BttizVPVZZ1o90JUC56qQ4SnIaINV3edtf5iqcdAqAATOwiPX7kc DDHixUHxl/1gP/OUFc9JxKDvKoIOFLWsgNzqYFPsIWf6qdEPW7DQ6A7l+p2zon6+vJKZLOQwcFP uz0oS0mY3hLbeT6EPGBUFWD7CQuAGVh3PgfkrodiSXXm8r15cqcLOiHsms7YmeazGIkubtkcNFe S+C6IqyxSDTIWW3dzGbV3xxkt5w3m0/h4XHq0x8MgrgcyuC1eLrQM9PmelyaBVUaTUXURvbLK0w H1LISNcXnuAfgZPBuB5P6ozj1M9pBtIrO1vpF6effhFANHtu1UU/y6pALMuZZt6ap2DLvk7YGbT qB87DiSJDLa7FU= X-Received: by 2002:a05:6214:226c:b0:894:823e:7708 with SMTP id 6a1803df08f44-899d1e97ccemr109024686d6.63.1772326520987; Sat, 28 Feb 2026 16:55:20 -0800 (PST) Received: from instance-20260207-1316.vcn12250046.oraclevcn.com ([150.136.248.187]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8cbbf66f325sm815840985a.16.2026.02.28.16.55.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Feb 2026 16:55:20 -0800 (PST) From: Josh Law X-Google-Original-From: Josh Law To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Josh Law Subject: [PATCH 2/3] staging: axis-fifo: use dev_err_probe() for IRQ error handling Date: Sun, 1 Mar 2026 00:55:18 +0000 Message-ID: <20260301005519.2512706-2-objecting@objecting.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260301005519.2512706-1-objecting@objecting.org> References: <20260301005519.2512706-1-objecting@objecting.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Simplify the error handling in the probe function by using dev_err_probe() instead of dev_err() when devm_request_irq() fails. Signed-off-by: Josh Law --- drivers/staging/axis-fifo/axis-fifo.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c index fc8e35696b31..28268881cda2 100644 --- a/drivers/staging/axis-fifo/axis-fifo.c +++ b/drivers/staging/axis-fifo/axis-fifo.c @@ -484,11 +484,9 @@ static int axis_fifo_probe(struct platform_device *pdev) rc = devm_request_irq(fifo->dt_device, irq, &axis_fifo_irq, 0, DRIVER_NAME, fifo); - if (rc) { - dev_err(fifo->dt_device, "couldn't allocate interrupt %i\n", - irq); - return rc; - } + if (rc) + return dev_err_probe(fifo->dt_device, rc, + "couldn't allocate interrupt %i\n", irq); fifo->id = ida_alloc(&axis_fifo_ida, GFP_KERNEL); if (fifo->id < 0) -- 2.43.0