From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E7E61FC0EF for ; Sun, 1 Mar 2026 00:55:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772326523; cv=none; b=I5EziW5LPB7kupQFuHIOHjoetckRLH9NWFzmDUbV5AfBYQb8GBLHSIp1XH0pBG6C4Fv2w8vL6uyJ0hulLpH3gPLQdfnUrH4R2vrwhbf9udn3Ng1BAmbaHb4gx8oRct/dq8/NE8kffP5RWLTRtfK7meIbEuCmABXtc0OpZrCc4K0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772326523; c=relaxed/simple; bh=bLyRPIhmVFkUqLi3y3bQPnpKuj3wK5zHZeruxl/aTkA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pefLoVvA2+doA5fJNofwvZN5zUEgqrj/oL9YTBcSYXcOstzD30oK6dASXIfJre3/KtqLaWs0B3bbAOdgUIzhW+Frue5GG4INi0sG8UL7kjnTGLAGLgW4pGf359w5ZD17mqcK7XABNCPr4e5JwZOKVWDNdnjhePnwSTNnTa0mC3g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lii2xgWP; arc=none smtp.client-ip=209.85.222.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lii2xgWP" Received: by mail-qk1-f173.google.com with SMTP id af79cd13be357-8cb39f64348so324534685a.0 for ; Sat, 28 Feb 2026 16:55:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772326522; x=1772931322; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EdhvuZH63NuTrmGD4re+jHGZxpdfReAQOfxr8ryWUCM=; b=lii2xgWPgHsKsgPu9+9cP+sWfson7unYIMTmkDP4HYBUcnXod6yYxx5JPZ8fLGjG2q jKOsp0BnttLUjya3s792bdaUj828i2Y0lj/Qp/8PktTfQZodHXvxV3K2U0irzWmhXsus YUYrXVJ0SdxUeZKkQL9PgJNxfJDwxNmAH7EoRXzlOaTr0ThLxIZUleYNSQZ1g3RvWalm vrNl6WoT8m76qRFA3fI5OK6AsRbVZE7T5sMo5ew3OsdRZiWgRX772UlQC3vMJz3ub9Yr GRWReevY28Fjr3siUIz20pMXxNlEgE6V0IToSO3bP3/l/RL0Wkchl2B8HfW/wkpezvRC kuyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772326522; x=1772931322; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=EdhvuZH63NuTrmGD4re+jHGZxpdfReAQOfxr8ryWUCM=; b=OxBNRm/XydOymLrOh31V6ejhMKIsCRNiNWaA9mBuiEpe/D6eN+OubfLECEZQjPR/Sm nTSMhFauB1yGMtmTuxrydYDwkip2y7HuvmS1Dl3FfFPezYZHA2ri30eKVkeZFZN1xn+/ Jq7+EckNwXmu9hvNFALABuj5OoDzcEEhUEJviBiTnxNZUlrBYU2g86BDSIyEynHl0Tjq LwXRNWiN9td/57oEb1nK98fiCFr8NS1e6h1LeZChv1MPKtoicRvMotu6AtCW4xMoEvDC Z/wi5tub7V4PZMZYuX8tov9kujxjwYijr7krbdJA5v6c9eKmIxawgg08I1d5u2Qal8MT EcEA== X-Forwarded-Encrypted: i=1; AJvYcCUyVTNoY0zsqUR1VvND1Nxg2nmxbRBLgHpc+lBmomzv6pp/kGV2c8zVmSJdzLeL9GJG9MaE/DaIh3HCcys=@vger.kernel.org X-Gm-Message-State: AOJu0YxcfSq08592JkdChOmU1arCgsprTelpekPXvbraveS2trNCtBFD q/84yuVUBxfji7CHi6YDDoGKRiSby5haoHPaUY0ivcEqGCeEk8KaARtsOADK7tzZ1vo= X-Gm-Gg: ATEYQzzdVmxyAViHliokXIPwwKJyIA+N+8CVoXtmoy261Vkw5s+loiwDBQXVrHoN9Ol VfoenuQDZYtICwE8olac6hJqtR6YG1vRTJZFZXsBzPn5Js9SHeK+nooLS4R6rkL6CTiYqtzUFp2 kvY0nOBPU/aw5OkbWiZg37pY583QEqJKgILSygkhs50Hh2G3824HG4V12RK2V0SOqW0RYLfO16Z s94SJHdXeWDqqhKD6S7gi+azjZH6rl1mY/5Y419KY7AAiFr+a0k/q2feDYQRo2Z5Sz0OBL6jcLb B27tniCc1jsOjz84144CnX/B9/f6yMwnlzUiUtrChPlGl6C7c8zZv8bkjGqqMvR7zg0HbVpDqtT U2lB4rv17Q7ObwmP/CziWtVVjS6qJ/kW/wkEPa/lE6jMnttVzWhob8BvjE7bX+jnsh+REH/Dl/e QsbZaeJMi/qX9FoaLDp3WelMBRWHySgWb+ZkDGx7e6N6rrTGbKX23RKAnmUJHud943bEFaTy/uT PZE X-Received: by 2002:a05:620a:400f:b0:85b:cd94:71fe with SMTP id af79cd13be357-8cbc8d9fe65mr995119785a.33.1772326521568; Sat, 28 Feb 2026 16:55:21 -0800 (PST) Received: from instance-20260207-1316.vcn12250046.oraclevcn.com ([150.136.248.187]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8cbbf66f325sm815840985a.16.2026.02.28.16.55.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Feb 2026 16:55:21 -0800 (PST) From: Josh Law X-Google-Original-From: Josh Law To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Josh Law Subject: [PATCH 3/3] staging: axis-fifo: improve IRQ handler Date: Sun, 1 Mar 2026 00:55:19 +0000 Message-ID: <20260301005519.2512706-3-objecting@objecting.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260301005519.2512706-1-objecting@objecting.org> References: <20260301005519.2512706-1-objecting@objecting.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Return IRQ_NONE when no interrupts were triggered to avoid spurious interrupt storms, and only clear the active interrupts instead of blindly clearing all interrupts by writing 'intr' to the ISR instead of XLLF_INT_CLEAR_ALL. Signed-off-by: Josh Law --- drivers/staging/axis-fifo/axis-fifo.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c index 28268881cda2..aad2206b481a 100644 --- a/drivers/staging/axis-fifo/axis-fifo.c +++ b/drivers/staging/axis-fifo/axis-fifo.c @@ -302,6 +302,9 @@ static irqreturn_t axis_fifo_irq(int irq, void *dw) isr = ioread32(fifo->base_addr + XLLF_ISR_OFFSET); intr = ier & isr; + if (!intr) + return IRQ_NONE; + if (intr & XLLF_INT_RC_MASK) wake_up(&fifo->read_queue); @@ -324,7 +327,7 @@ static irqreturn_t axis_fifo_irq(int irq, void *dw) dev_err(fifo->dt_device, "transmit length mismatch error interrupt\n"); - iowrite32(XLLF_INT_CLEAR_ALL, fifo->base_addr + XLLF_ISR_OFFSET); + iowrite32(intr, fifo->base_addr + XLLF_ISR_OFFSET); return IRQ_HANDLED; } -- 2.43.0