From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com [209.85.219.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E02E30F958 for ; Sun, 1 Mar 2026 15:53:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772380404; cv=none; b=t0mVGfRD0cNO7zmN1575ebNAfZeOF47LIjOvr8GjLge3IQA/HOxuwf+ZmloZ/impgeFz1qRpHuTdkMUd+DXVGbByp1Zvx3xKNwVZA1yhUto+RG0ruGo5lBA1sm2yeHEWkPCtRqiIwrsUS90LRhatyb50NN+mb5JOg2G20mk9bR4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772380404; c=relaxed/simple; bh=4CLluQJZJe2UFWmhu6vqbrtGj3pK+/lNOzpqz1CRzh8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MZ1/aPoAGaHvCAEmdwmBX9D87Ob+RpUm4wPxeXDCQCaCBGNuRmRpqT2i2RY9nuUkwisLPpabqBaNFmYgud3Kljm0d8ycieyVw1X7JOBllHcGiL2BXbL0w+vdGMV2GF/ekIXzfWnAnHAnhBHn3fn0I3mk2vJaI8qKA9Lbxkw3Ppo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=h3pS21OP; arc=none smtp.client-ip=209.85.219.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h3pS21OP" Received: by mail-qv1-f48.google.com with SMTP id 6a1803df08f44-899a917a4feso66617486d6.1 for ; Sun, 01 Mar 2026 07:53:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772380402; x=1772985202; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8piR2oQzjWhhPzsrfJoM5iuWyu9p3jO48h603VTIcNs=; b=h3pS21OPDunU6FHp4yynElLJSOmLJ1ZvDiqEc4zHDwkiNazAFnG8e1lhDHVJ4u/ix/ UYaXP+Z0Z2xSYkEsz8IZpefMPZPqPvd4dmpx9McMKz6y8I/2DgF6/BgfFpjFuBX+lcJe z3DNzRTcw83IuYLeqM1TuobaAVIWy3mFEMGREIRup5CntvGO8F4z7+1gqsgZ65aT077s aIJgqtqrR6frNNi2k9jttBsETa2wu/L+GHoN85DlhzbtoWqQvf/u63VvaPAFwQMLZKe3 8psfrHs+Owho0rcwpWi4zNSXDDvopk6tCweXrM4DuUkeiRtJO09Pn6oVr0YbM/l4AhQS 860Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772380402; x=1772985202; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8piR2oQzjWhhPzsrfJoM5iuWyu9p3jO48h603VTIcNs=; b=gZQtpJTIvQtJ+9ACzV6C84bxrIDpZIQBTmzUMfubOLA+nTllT5lwBZr/hfbhvxrCOM TpdDtcgEfcqX0NVrSg450nscg2CQm5cZem8T5Vra9MNcOnlpryuTB9zcYsM5aFInuktc bO7CpiLc6/GmpbGuKjIA+YiTY42lItdbbEExNfnw3n7TRa884w7YVfSpqOZdfqanChQR zikxBHTI49rqxoaOMI+3ifE9tAdJg8441ajnmN9hyEOgs18RBWMjst5Oe0dt1J22+8BQ fHmlHtIYH1BaZ/BQpEsL2YgSArMptuc4NkjQq1Ei3vJjuNQyfabOhn1XYG/hoHg/kOqn /79w== X-Forwarded-Encrypted: i=1; AJvYcCWXfW3M811catNDONpfqu6UZ5hNgKgEgCybrS8T3EJdm8hmf1niDjnvlqwzaW4b42lq7WG7HAvq4ooC3L0=@vger.kernel.org X-Gm-Message-State: AOJu0Yzr3QDrF37yyRkhxqAzLCi2w+OZAxHDLS+D5I4L8gmvvpjxPn+W PVBP8uh2L+on2xD1QWmnN9DgfV/NdUya2JWbMYLAAIp0+rItq2J8qvft X-Gm-Gg: ATEYQzyt8oGepOHegHQxxsPn/m0ejSUp9kYGoTT5NVL8oYJLpmy3kiQynWkYG3nVru3 v7fR5YdZ/LQM78LY3CI91X1k+JLJt4eeyJ8P9lfEBq8gchwiLt4RuieO1a3odgGckScAhN4ddn3 sv1jVWATOMPmEcvJUKIyoFYmIiC3NouTXgfaHIPoGYDrgesjEOWQrRd2cNVYxwnZMf/ljlKFKkl RnzfDoQTV+vMupdTwYcGfTZnAUfIRdXoXBjCquOyokpOD9D0dKfVDNyYP9ivzbc6dgBzl+7i8zD repm6T6v2aRtD8AcKcXGF7l4MKSvkekErghHI5gN1jYcDPkx0SE4Sy2dQ95x1Tg+pjRA5/atMVY XFa4q8ZLppOhRWi47Gnsep5wjxwlx2hGTusKN9ZV7t5sso0LJrf5W4g/TWDF+65BiPhsAFV60Y9 xVT86i/OUZ9lCZitSA0CYDlx/k4gBo5RAFDpwiIF++WTocaRxZR82nIy8MKjHRhOhdGGauot/UT yQ6 X-Received: by 2002:a05:6214:2481:b0:899:b42f:9dea with SMTP id 6a1803df08f44-899d1db1605mr137903056d6.25.1772380402355; Sun, 01 Mar 2026 07:53:22 -0800 (PST) Received: from instance-20260207-1316.vcn12250046.oraclevcn.com ([150.136.248.187]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-899efc810e6sm21128516d6.5.2026.03.01.07.53.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Mar 2026 07:53:21 -0800 (PST) From: Josh Law X-Google-Original-From: Josh Law To: Greg Kroah-Hartman Cc: Ovidiu Panait , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Josh Law Subject: [PATCH 4/4] staging: axis-fifo: simplify error returns in axis_fifo_parse_dt() Date: Sun, 1 Mar 2026 15:53:18 +0000 Message-ID: <20260301155318.2596519-4-objecting@objecting.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260301155318.2596519-1-objecting@objecting.org> References: <20260301155318.2596519-1-objecting@objecting.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace redundant 'ret = -EIO; return ret;' patterns with direct 'return -EIO;' statements, and change the final 'return ret;' to 'return 0;' since success is the only path that reaches it. Signed-off-by: Josh Law --- drivers/staging/axis-fifo/axis-fifo.c | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c index 7ca0404b0875..9aeb16d8a71f 100644 --- a/drivers/staging/axis-fifo/axis-fifo.c +++ b/drivers/staging/axis-fifo/axis-fifo.c @@ -403,8 +403,7 @@ static int axis_fifo_parse_dt(struct axis_fifo *fifo) return ret; } else if (value != 32) { dev_err(fifo->dt_device, "xlnx,axi-str-rxd-tdata-width only supports 32 bits\n"); - ret = -EIO; - return ret; + return -EIO; } ret = of_property_read_u32(node, "xlnx,axi-str-txd-tdata-width", @@ -414,43 +413,38 @@ static int axis_fifo_parse_dt(struct axis_fifo *fifo) return ret; } else if (value != 32) { dev_err(fifo->dt_device, "xlnx,axi-str-txd-tdata-width only supports 32 bits\n"); - ret = -EIO; - return ret; + return -EIO; } ret = of_property_read_u32(node, "xlnx,rx-fifo-depth", &fifo->rx_fifo_depth); if (ret) { dev_err(fifo->dt_device, "missing xlnx,rx-fifo-depth property\n"); - ret = -EIO; - return ret; + return -EIO; } ret = of_property_read_u32(node, "xlnx,tx-fifo-depth", &fifo->tx_fifo_depth); if (ret) { dev_err(fifo->dt_device, "missing xlnx,tx-fifo-depth property\n"); - ret = -EIO; - return ret; + return -EIO; } ret = of_property_read_u32(node, "xlnx,use-rx-data", &fifo->has_rx_fifo); if (ret) { dev_err(fifo->dt_device, "missing xlnx,use-rx-data property\n"); - ret = -EIO; - return ret; + return -EIO; } ret = of_property_read_u32(node, "xlnx,use-tx-data", &fifo->has_tx_fifo); if (ret) { dev_err(fifo->dt_device, "missing xlnx,use-tx-data property\n"); - ret = -EIO; - return ret; + return -EIO; } - return ret; + return 0; } static int axis_fifo_probe(struct platform_device *pdev) -- 2.43.0