From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1F8E28B4E2 for ; Sun, 1 Mar 2026 21:48:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772401722; cv=none; b=jktcIcOlNp4E61wIG1CPDbfs4HN48uXIowaXvQIZszlfkaklKydqZzYqeR0gUYgGHMB4ZoS98r61Cs8u5EvJgstkUixMNBo9sAuqpm+k85fWqjxTEzmpJlr8ZMtyo60jB1zuUOSLdUuGsseIlt0sVdLKAq+knxlr5eZYAs5SdCY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772401722; c=relaxed/simple; bh=lW/mkx2vACArB2sTuZKI0zjzBNqCR7VnKMR6hwmJO1I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kJ2dltCGBHAZUNx4/WnOkXNaZq58PeOCvxKgGuJoh1JKYUGYS1SqtQouv4YISW4ThRshrI74rOpHp2bJm7HKu4TjKtGuk5N+mlxLVHhcBzBXErpFe3uP1/bJEvGPfH8WBxY+tQ8w55W/RHzb2YTbNalPdu0yyIbJnck92yqF2ag= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RjcCnxI8; arc=none smtp.client-ip=209.85.219.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RjcCnxI8" Received: by mail-qv1-f52.google.com with SMTP id 6a1803df08f44-899fa7d0780so2865896d6.3 for ; Sun, 01 Mar 2026 13:48:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772401713; x=1773006513; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TBBLSV4AWNmKnxg+io3XidW2g81aHafZMIfnXiFjmPY=; b=RjcCnxI8uUCJXxC8KNlpCo/aLhmKIW7wPmfwuRyGf1VIB5VSFDbwse/EdKezpYj7XJ W9nMHILU2Tw1+204gV9QM7oMEWcFSIPJDYRhQF//Rubj9nmSwsduZga25e9sWdz18BAC Bmm7xrnNNRyEo6JiMrIX56RhYBGron+VnymxKXyItkQCGikDYk0Uzpbm/tZekg8YDh12 vpYbTnPQ0G0122Yq0YnIU6BXLlj4/hxEFkzGSu3/VIfna1jUnmp5Id/Hza79ZWkpHcF8 U+/pwz9Bz3RavAYmMX3go243wDNBRxM5vAC1R8mAyvB/+xv05W4L9nC/F254HLuIc4Ux MKZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772401713; x=1773006513; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TBBLSV4AWNmKnxg+io3XidW2g81aHafZMIfnXiFjmPY=; b=N6FDJj/lx2RdgKGfHVbjMCg/AEKB06qYvXbImTe3IBS7cGPLnV8zGIymh3NkLTr1ip GHW0zbcFm7Tqwkp4tDIczPg3/BajiNn4o1b+k5ilrbL/WtnInlRvyxtW5FjFhPTJMaHd NUHj5lP+gQcvIqheaZ4Cw1QigFxZMefkNinwQ1CJq2E1zJdcP94Hgefpdh7FDLDoEEVI DAzrdZubsuz7XBA6Hxp1X3GT26kWkZTHKSNOWj0oaBcQi1bsSlmi0v6aUo4x2xTzZ4jr +5D1iayAk+R2nU17R15JlfjU2kdRD3KYIClDeOolSWWSTeYtiWfYabClcGD+Do/5eJQo hI2A== X-Forwarded-Encrypted: i=1; AJvYcCWG7o1R9iAmgI3rRTb0PA5XzGhJw8ayldLXz5aoz4Bs2lZznMEcQbBx8qZuCi40X6jijEq9AEkTvly+LbY=@vger.kernel.org X-Gm-Message-State: AOJu0YxHXs2I1YRcLftSXsY+SgZlGxV4pyD/FAze1PVbKHEwJowJI4io 56qzAs3qVrbn0SwZFX/n2VCRbZzb0WTEackfT9SM/asX5ZwEGxFde3mX X-Gm-Gg: ATEYQzwlPPhjQ40L8VT/XtIYI43lw7Nh4N3ukIDWNAU4liF3Dsz2lg6SAmO8R4orYKd oPFAwsDRzCyjxiZ09RJquxlG14fe/9dIHS52CzGF0Qfqgy5GpyRrObXcl37hyoA7k0tWrZNPKcT lQGkSUVZfi6yh/QNimvLiFOSyl+s707NPo5UYv6w1PMB9UkSVGmDOB++9XG8JBQJVlXGmAd7N4p WuBLN77/7UPr5TGK1mHJzrVrF7mvW1EVKbnW3mUQDoFfd+1qGp5HhZDDh8Wc42n+C1Ia80Dsy+h Cm0I0ZsT6fC7UP8kF25g0ZmAVF+zI7sieO0Rg631SaYCCClTGa5CBsISjtAUO4GB8tMJLjEy7Ml lka2CJddqwAwiYa+XGFb6yVzcyFgxz62S80PnIEWuYx3xb1jPRJMR5lgRTWOmteDjo6wNFwMz/O 3v/Epv7zABTm22Yidtg2I8u7sRdwXbdYCgJidXg3njzGqlnvsmDz2QVXr11pUHttT4E8PDnGvoO HGD X-Received: by 2002:ad4:5947:0:b0:899:f929:d85b with SMTP id 6a1803df08f44-899f929ddc8mr24850906d6.61.1772401713605; Sun, 01 Mar 2026 13:48:33 -0800 (PST) Received: from instance-20260207-1316.vcn12250046.oraclevcn.com ([150.136.248.187]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8cbbf6f948dsm1006700085a.30.2026.03.01.13.48.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Mar 2026 13:48:33 -0800 (PST) From: Josh Law X-Google-Original-From: Josh Law To: Greg Kroah-Hartman , Ovidiu Panait Cc: Gabriel Shahrouzi , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Josh Law Subject: [PATCH v2 10/10] staging: axis-fifo: simplify error returns in axis_fifo_parse_dt() Date: Sun, 1 Mar 2026 21:48:15 +0000 Message-ID: <20260301214815.2628942-10-objecting@objecting.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260301214815.2628942-1-objecting@objecting.org> References: <20260301214815.2628942-1-objecting@objecting.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Josh Law Replace redundant 'ret = -EIO; return ret;' patterns with direct 'return -EIO;' statements, and change the final 'return ret;' to 'return 0;' since success is the only path that reaches it. Signed-off-by: Josh Law --- drivers/staging/axis-fifo/axis-fifo.c | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c index 7ca0404b0875..9aeb16d8a71f 100644 --- a/drivers/staging/axis-fifo/axis-fifo.c +++ b/drivers/staging/axis-fifo/axis-fifo.c @@ -403,8 +403,7 @@ static int axis_fifo_parse_dt(struct axis_fifo *fifo) return ret; } else if (value != 32) { dev_err(fifo->dt_device, "xlnx,axi-str-rxd-tdata-width only supports 32 bits\n"); - ret = -EIO; - return ret; + return -EIO; } ret = of_property_read_u32(node, "xlnx,axi-str-txd-tdata-width", @@ -414,43 +413,38 @@ static int axis_fifo_parse_dt(struct axis_fifo *fifo) return ret; } else if (value != 32) { dev_err(fifo->dt_device, "xlnx,axi-str-txd-tdata-width only supports 32 bits\n"); - ret = -EIO; - return ret; + return -EIO; } ret = of_property_read_u32(node, "xlnx,rx-fifo-depth", &fifo->rx_fifo_depth); if (ret) { dev_err(fifo->dt_device, "missing xlnx,rx-fifo-depth property\n"); - ret = -EIO; - return ret; + return -EIO; } ret = of_property_read_u32(node, "xlnx,tx-fifo-depth", &fifo->tx_fifo_depth); if (ret) { dev_err(fifo->dt_device, "missing xlnx,tx-fifo-depth property\n"); - ret = -EIO; - return ret; + return -EIO; } ret = of_property_read_u32(node, "xlnx,use-rx-data", &fifo->has_rx_fifo); if (ret) { dev_err(fifo->dt_device, "missing xlnx,use-rx-data property\n"); - ret = -EIO; - return ret; + return -EIO; } ret = of_property_read_u32(node, "xlnx,use-tx-data", &fifo->has_tx_fifo); if (ret) { dev_err(fifo->dt_device, "missing xlnx,use-tx-data property\n"); - ret = -EIO; - return ret; + return -EIO; } - return ret; + return 0; } static int axis_fifo_probe(struct platform_device *pdev) -- 2.43.0