From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f181.google.com (mail-dy1-f181.google.com [74.125.82.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 399F12F3C13 for ; Mon, 2 Mar 2026 16:21:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772468501; cv=none; b=TK6oYzJK2U+WOIidaT6SZ2baJgUV06/yKbwpHGBVmsB8h59p3cliL/Fi8t2Yy8yW6YW1vUKDlxCDMZ/yqfEddJRYNIgMEwEJfjQP6vH9xi+keGfuOJEh+3D7FheweuguZQdni7Azr83h9nJ5UdoYcz5iSo/qMXw2MWqrOqWGN1k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772468501; c=relaxed/simple; bh=XLnJDf16wU+RpuAOUO5MNiJWhJ9cGGNdlu3PjcEwleA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IP+h/6QYkTq82+QqQ84FRi1OqI9IxEvRM8cC0gNWbojsqPWL3qqxgWMlJ3ijQHFnWVFgRKVtG8kaCaL7rloA/fos9VGaVgaQdx97BRiVbS0E1unNK6NCthOM2GshWkDEzPUNZaWdwqLX10Z0gnjsleRStfk45yblhNBx10qaABA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TigebF+k; arc=none smtp.client-ip=74.125.82.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TigebF+k" Received: by mail-dy1-f181.google.com with SMTP id 5a478bee46e88-2be1d9c356cso584307eec.0 for ; Mon, 02 Mar 2026 08:21:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772468499; x=1773073299; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Mh5BTNPf22FcAGJyMm54oCFLF78fe9usxjfIafTIqDU=; b=TigebF+kZlGpKLbZrmbF30hTLUr4YgvJXyb2yr7uZjicDwP8uQiuiGWAjBtv6V3NAi MRiP4Dc4btQcvMe1pF9U57tCiUkztUEzWOCDDCe2YNk6+7cHQwUEl7kA5cCNl3UYzvsc qeltIhjCZ/ETOXOQ4FgCbEQyVUN+/2EObzt+TCoh0bxxzG+Zia/h7obzKIFTA/rw1p3/ b+c1CyONmBf5eFRufT6c4Gg/ZAz9wSYs/btF2Z10YM8vUWgbn32bdgQEsHuYYJqc7hDT WtijoZFZG3njpd0YiyOGwilhAP97lxHyJBlMFtkM7ePoOSjLD/kabJqYY/ZNnrk/Eoi4 mwSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772468499; x=1773073299; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Mh5BTNPf22FcAGJyMm54oCFLF78fe9usxjfIafTIqDU=; b=M+gThp3T6gPjyebTSPFavGzlg839z1pJvulujjIHmxm+6k/zPas2gJn4ARKBCtvLye IsDysoM8wgK0GasGHN9D2xHqwQn7cm1J5gaIvn9a4T7fyz4Vu9qxMHHGOrT891PxoZFr IEV4MaX4DX/RWo1ozBuVkamgvBksgy4pSrJ9KTb8WMSf8Ox7ttY0oFJyjPmGB+wo5VHW sy5WtV3fyprJEXGBm/5wdh2+im8a5jMbGFkzZSnrthqcs1IhHrxctgHjGzlMzRcZawTQ Nj5AXTPEHj+XobBY626lGO9RaThzeNP9ZGRrNBDVoAKlLgBq+3vaJJqmNBReBUlWj/MJ +hZg== X-Forwarded-Encrypted: i=1; AJvYcCUE9lAWEUgMBOBY+MtNi5PX3PAQGuBv5ADpUY7+tks6CyxXxJ0VwnjkX0ZRMV1JaPQXXEVMfZi0Z7odMD4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz8FOjnt0n/Vn16mI3M+MYmSt222tyUGX/KDjOJlQhiHKnV34Il fBM10uXMjfZjAWCXLy+G9R0KSS8G9ZyzOHo2V2w2Yja6MDL9lap0jxXN X-Gm-Gg: ATEYQzyJpTtrfVXmx3bMBK8UEnhAPLXalxUCb1gaeAh3Z0OgM+ORjEv2156ZPN4a8Wm XqfrRkZGnaGzE5ll/4FCqe2wTYb3Rqbs5rzNjnuru218wSc+ChuZ5QzDTzAzTL2joDYCGBrzFVa VDUF+B+SR6pZU/YzVeN9FwH6XhZeg4IfjohW9tvrIC+WK9gSGob1JeEus3DSZXqAROSfLeKTccT IKmQcGkv5BZhXqFn8ykaQmxgvYItrQS8b7dM8qFiNyJfmYkyZn6Z/I0e00Gmqwr04gIYqGNgkAe FbcnieOxSJffN7JU8W6RO9OCfTXLmsBobL1YtQfL14x/KiItXp9ML6/gQmnd0U0Rq4xd5iGHR+3 8BF7Qs6wglbh+mxmr+sxQPBYPFi8/ZbhtDU0NPL0prUHmVK2qVjUxcZaXCqxFBF9LAK7BgLQkOF 5c5LgFiQpeWtjWijoO7gO8LMRNZcG94RHtbJrb3pYAAF5kMiPM8ca0hOJdz4AjXBBjO5oZ/3Gjh chvp87EdP+F/6aacBOw6YxbZn2y1TfybGvT3H3g34IPbQ3UXJ9+8EcG4A9GKyGUR5D6WDUbcqm+ +EfDuYeQD0Jiu1LHUms4NYSYSCAp X-Received: by 2002:a05:7300:cb1a:b0:2ba:81b2:7820 with SMTP id 5a478bee46e88-2bde1c99c71mr6387336eec.22.1772468499181; Mon, 02 Mar 2026 08:21:39 -0800 (PST) Received: from arch.lan (c-98-51-119-100.hsd1.ca.comcast.net. [98.51.119.100]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2bdfed770d4sm5390391eec.17.2026.03.02.08.21.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 08:21:38 -0800 (PST) From: Milos Nikic To: jack@suse.cz Cc: jack@suse.com, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, nikic.milos@gmail.com, tytso@mit.edu, yi.zhang@huaweicloud.com Subject: Re: [PATCH] jbd2: gracefully abort instead of panicking on unlocked buffer Date: Mon, 2 Mar 2026 08:21:36 -0800 Message-ID: <20260302162136.38742-1-nikic.milos@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Jan, No, I didn't trigger this in the wild. I have been auditing jbd2 for J_ASSERT usage to see where we could proactively swap hard panics for graceful journal aborts. You are right that there are many similar asserts, but I focused on this one because it belongs to a specific, easily-actionable group: it resides in a function that already returns an error code (int). Some of the other J_ASSERTs are buried inside void functions. Converting those to return errors would require cascading API changes and rewriting caller error-handling paths across the subsystem, which is a much bigger and riskier lift. My goal was just to target the "low-hanging fruit" - the asserts where the function signature already supports returning an error (-EINVAL/-EIO) and aborting the journal safely without changing the API. If you are open to it, I can audit the codebase for the rest of the asserts that fit this exact profile and submit them. Would you prefer them grouped into a single patch, or a short series? Thanks, Milos