mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Franz Schnyder <fra.schnyder@gmail.com>
To: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>
Cc: Franz Schnyder <franz.schnyder@toradex.com>,
	linux-kernel@vger.kernel.org,
	Francesco Dolcini <francesco@dolcini.it>
Subject: [PATCH v2 2/2] regulator: pf9453: Allow shared IRQ
Date: Mon,  2 Mar 2026 17:53:56 +0100	[thread overview]
Message-ID: <20260302165357.1797803-3-fra.schnyder@gmail.com> (raw)
In-Reply-To: <20260302165357.1797803-1-fra.schnyder@gmail.com>

From: Franz Schnyder <franz.schnyder@toradex.com>

The PF9453 datasheet specifies the IRQ_B pin as an open drain output
with level-low behavior. This makes it capable to share the interrupt
line. To allow shared interrupts, the driver must handle the case
if the interrupt has been triggered by another device.

Set IRQF_SHARED to be able to share the interrupt line.
If the interrupt has not been triggered by the PMIC, return IRQ_NONE.

Signed-off-by: Franz Schnyder <franz.schnyder@toradex.com>
---
v2: Return IRQ_NONE if the interrupt was not triggered by the PMIC
---
 drivers/regulator/pf9453-regulator.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/regulator/pf9453-regulator.c b/drivers/regulator/pf9453-regulator.c
index eed3055d1c1c..07cbcd312653 100644
--- a/drivers/regulator/pf9453-regulator.c
+++ b/drivers/regulator/pf9453-regulator.c
@@ -732,6 +732,9 @@ static irqreturn_t pf9453_irq_handler(int irq, void *data)
 		return IRQ_NONE;
 	}
 
+	if (!status)
+		return IRQ_NONE;
+
 	if (status & IRQ_RSTB)
 		dev_warn(pf9453->dev, "IRQ_RSTB interrupt.\n");
 
@@ -809,7 +812,7 @@ static int pf9453_i2c_probe(struct i2c_client *i2c)
 	}
 
 	ret = devm_request_threaded_irq(pf9453->dev, pf9453->irq, NULL, pf9453_irq_handler,
-					IRQF_ONESHOT,
+					(IRQF_ONESHOT | IRQF_SHARED),
 					"pf9453-irq", pf9453);
 	if (ret)
 		return dev_err_probe(pf9453->dev, ret, "Failed to request IRQ: %d\n", pf9453->irq);
-- 
2.43.0


  parent reply	other threads:[~2026-03-02 16:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-02 16:53 [PATCH v2 0/2] regulator: pf9453: Fix IRQ trigger and allow sharing Franz Schnyder
2026-03-02 16:53 ` [PATCH v2 1/2] regulator: pf9453: Respect IRQ trigger settings from firmware Franz Schnyder
2026-03-02 16:53 ` Franz Schnyder [this message]
2026-03-03 11:20 ` (subset) [PATCH v2 0/2] regulator: pf9453: Fix IRQ trigger and allow sharing Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260302165357.1797803-3-fra.schnyder@gmail.com \
    --to=fra.schnyder@gmail.com \
    --cc=broonie@kernel.org \
    --cc=francesco@dolcini.it \
    --cc=franz.schnyder@toradex.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®