From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B970335543 for ; Mon, 2 Mar 2026 23:58:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772495906; cv=none; b=Urftt69Ri75pSq3+VjMYv7qCMgaQYslCP5zcp1kEKqbVnZhzbaXaDTXXKmkAb0sT149bDDEYGhWj5SVXZ1LXxcFBgsgYyA/tUhRebTh2Z1XNQ2u5PG2IbATB8hkFp/y01Xx9dv/XfLFYNT8ipPQP6A7x0MCcTviTldF7ZfFcrPg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772495906; c=relaxed/simple; bh=tExwCrlQi12nQx7UkSsrhpcEHdMii7nWl7VBNzVsTvc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=klpnYqioQw4eNbwnIh6hvRQsHb6VGS5wtcwjPmloCgo1jfeAJygvBjVRrDsWGUV66elz3gjZXxzqMdpRt6of8z5tfxv5UvDrAEY/oUs3iH6zfPhYbZME3xYlpwr+5/70yTCeGeziqxsrPcMOY37mDNbHNpFrByd8iDA8WlkVWb4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=jZsWpl4s; arc=none smtp.client-ip=209.85.222.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="jZsWpl4s" Received: by mail-qk1-f179.google.com with SMTP id af79cd13be357-8cb3a8494c5so491116485a.2 for ; Mon, 02 Mar 2026 15:58:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1772495904; x=1773100704; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=W9pGflp+DwWVxkpRGVZHn5Rq2Zi9Zui031IX+gYAIi4=; b=jZsWpl4scDAcmgpHafYD6w7MDf6N0TH8/XxpXOVtMuJg4NcJXfJYrDOjARNgSg1nO8 krzJHHP8Mg0/PxfCqXJZE7wyhHJ6RJWaZX8Ou/feDWXOdf5o5nHtGCTDDa8VZ/eO1ALG yQRSJNJbdqbLa0udlzlh+VRcf2lVxgzKho1vfMC+HW21VOyLfMtIfuL0ybyjruxKNpSk 3+7zEilS9Hpgip4A2hdKG5JuEpjQ6r5xYlyGRVUkrdXvDGLaianysYmTmjQeQczNIg0x 6KSE7uPNnDFd6UMqsNLq9k5chX6HGWJP2OsOF99P47afahiX2oqW+2i39AUDjAQ7nKpY y9dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772495904; x=1773100704; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=W9pGflp+DwWVxkpRGVZHn5Rq2Zi9Zui031IX+gYAIi4=; b=jldiM8D6UicSpdPgGQ7nUVDQaQKwd2TIykmknyS93EOIIw9l8mEECX98kv+qPTuW6v Vya265Wi/BfNj7bsi8CqYJqrr6eQSbXntjb70/3V/SlJBN+OS0ohFu2ae6E1hsDhhIvO EbFInj6diW1vXwh+162msUhcSIMh9v6eutI3d16ObyWxYArdNMq2istl4jt2QTcqCLmP 4KMoxriMhhD4did449oppYaZPYv39MGbIw08wwLiFR3GAHSj+c2pptkMmx93v1W/hQGW lBj6/3Fxa6Ld2gm1ivgt342vfGESErzP/nrn7EflErRg1WplPsPMTsv4BFdEO4nzujJD V76A== X-Gm-Message-State: AOJu0YxO2F0CngGChytYA287Kj28ShU++4NHDA2ZB1gjF/O5DxTWdbrk eX73nvmJUg8ANiQ92v+tCSA8gbGR9nYAKXISyW4C16rmG88o3MIsAKY130KTHmHLM80= X-Gm-Gg: ATEYQzyKzCXzYMfYiui+90LyZvHvi3BDGIqVvMA9vw8217sNsx3/nbPrc4LGmJADbIe r+P6qpHrXBhthMrg41sk5p7wPsdL7lfnKf9Mg3iC9S0okC+hPzZzcBVH6jklk+POyYx9Guojs7N eyw3T5shX2c0jDQtpXnI/ilcJ3B6Ag9Vc4G2Zbo24XFiwMA8p3kpm8Da/hfVrdW5kq6s+T+wSNa I7uxMEvUVuk29U/MbA8hyn2wi8fbmDarfHNQKSmjZ3FahNTJSRlF+ykcCILgoP07LVUSHaIfe4i w++f3UQroq9SsBDW7uo2BIScA//ER35nTs8XGMBbcziVcJAlESeCObQoOIcaAT/NeZ2FqpVYHWP Uo7WszBeWctx/0gfPuFrlYTJWhuvNnRaotTBNaAwHBeH5GMy1cjc9rz9Ponp7iqWiLx7ZVPr79M MVVGuxxqerHb8UzQVxKj6ptQNUzroYf8QofGewa1xNey0lVQBOSBDd7G8Xi0R+i2PjJStnsMkDA sLzXT7o X-Received: by 2002:a05:620a:4801:b0:8cb:4066:7acc with SMTP id af79cd13be357-8cbc8e4b74fmr1770386285a.50.1772495904463; Mon, 02 Mar 2026 15:58:24 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-112-119.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.112.119]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8cbbf66f31asm1236972585a.15.2026.03.02.15.58.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 15:58:24 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1vxD9b-00000003wmd-1qhh; Mon, 02 Mar 2026 19:58:23 -0400 Date: Mon, 2 Mar 2026 19:58:23 -0400 From: Jason Gunthorpe To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, Joerg Roedel , Will Deacon , Robin Murphy , iommu@lists.linux.dev Subject: Re: [PATCH] iommu/io-pgtable: fix all kernel-doc warnings in io-pgtable.h Message-ID: <20260302235823.GZ44359@ziepe.ca> References: <20260302005214.3469521-1-rdunlap@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260302005214.3469521-1-rdunlap@infradead.org> On Sun, Mar 01, 2026 at 04:52:14PM -0800, Randy Dunlap wrote: > Avoid kernel-doc warnings in io-pgtable.h: > - use the correct struct member names or kernel-doc format > - add a missing struct member description > - add a missing function return comment section > > Warning: include/linux/io-pgtable.h:187 struct member 'coherent_walk' not > described in 'io_pgtable_cfg' > Warning: include/linux/io-pgtable.h:187 struct member 'arm_lpae_s1_cfg' not > described in 'io_pgtable_cfg' > Warning: include/linux/io-pgtable.h:187 struct member 'arm_lpae_s2_cfg' not > described in 'io_pgtable_cfg' > Warning: include/linux/io-pgtable.h:187 struct member 'arm_v7s_cfg' not > described in 'io_pgtable_cfg' > Warning: include/linux/io-pgtable.h:187 struct member 'arm_mali_lpae_cfg' > not described in 'io_pgtable_cfg' > Warning: include/linux/io-pgtable.h:187 struct member 'apple_dart_cfg' not > described in 'io_pgtable_cfg' > Warning: include/linux/io-pgtable.h:187 struct member 'amd' not described > in 'io_pgtable_cfg' > Warning: include/linux/io-pgtable.h:223 struct member > 'read_and_clear_dirty' not described in 'io_pgtable_ops' > Warning: include/linux/io-pgtable.h:237 No description found for return > value of 'alloc_io_pgtable_ops' > > Signed-off-by: Randy Dunlap > --- > Cc: Joerg Roedel > Cc: Will Deacon > Cc: Robin Murphy > Cc: iommu@lists.linux.dev > > include/linux/io-pgtable.h | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) Reviewed-by: Jason Gunthorpe Jason