mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Qiang Yu <qiang.yu@oss.qualcomm.com>
To: Manivannan Sadhasivam <mani@kernel.org>,
	Qiang Yu <quic_qianyu@quicinc.com>,
	Hemant Kumar <hemantk@codeaurora.org>,
	Bhaumik Bhatt <bbhatt@codeaurora.org>,
	Loic Poulain <loic.poulain@oss.qualcomm.com>
Cc: mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Qiang Yu <qiang.yu@oss.qualcomm.com>
Subject: [PATCH v2 2/2] bus: mhi: host: pci_generic: Add pm_runtime_forbid() in remove callback
Date: Tue, 03 Mar 2026 01:02:14 -0800	[thread overview]
Message-ID: <20260303-b4-async_power_on-v2-2-d3db81eb457d@oss.qualcomm.com> (raw)
In-Reply-To: <20260303-b4-async_power_on-v2-0-d3db81eb457d@oss.qualcomm.com>

Add pm_runtime_forbid() to balance the pm_runtime_allow() call made
during probe. Without this, the device remains in runtime PM allowed
state after driver removal.

Fixes: 855a70c12021 ("bus: mhi: Add MHI PCI support for WWAN modems")
Signed-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com>
---
 drivers/bus/mhi/host/pci_generic.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
index 0395a8ea52b0e874209ca56cd20ed04419038cdb..b6b21d0f3388d61b771062b8077f836a6bf8f9f8 100644
--- a/drivers/bus/mhi/host/pci_generic.c
+++ b/drivers/bus/mhi/host/pci_generic.c
@@ -1459,6 +1459,7 @@ static void mhi_pci_remove(struct pci_dev *pdev)
 		mhi_soc_reset(mhi_cntrl);
 
 	mhi_unregister_controller(mhi_cntrl);
+	pm_runtime_forbid(&pdev->dev);
 }
 
 static void mhi_pci_shutdown(struct pci_dev *pdev)

-- 
2.34.1


  parent reply	other threads:[~2026-03-03  9:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-03  9:02 [PATCH v2 0/2] bus: mhi: host: pci_generic: Improve boot performance and cleanup Qiang Yu
2026-03-03  9:02 ` [PATCH v2 1/2] bus: mhi: host: pci_generic: Switch to async power up to avoid boot delays Qiang Yu
2026-03-03  9:02 ` Qiang Yu [this message]
2026-03-06  7:42   ` [PATCH v2 2/2] bus: mhi: host: pci_generic: Add pm_runtime_forbid() in remove callback Manivannan Sadhasivam
2026-03-06  7:41 ` [PATCH v2 0/2] bus: mhi: host: pci_generic: Improve boot performance and cleanup Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260303-b4-async_power_on-v2-2-d3db81eb457d@oss.qualcomm.com \
    --to=qiang.yu@oss.qualcomm.com \
    --cc=bbhatt@codeaurora.org \
    --cc=hemantk@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loic.poulain@oss.qualcomm.com \
    --cc=mani@kernel.org \
    --cc=mhi@lists.linux.dev \
    --cc=quic_qianyu@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®