Re: [PATCH] drm: of: Fix drm_of_get_data_lanes_count_ep() return value documentation

[Maxime Ripard <mripard@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1444 bytes --]

On Tue, Mar 03, 2026 at 09:14:53AM +0100, Geert Uytterhoeven wrote:
> Hi Maxime,
> 
> On Tue, 3 Mar 2026 at 09:07, Maxime Ripard <mripard@kernel.org> wrote:
> > On Thu, Jan 15, 2026 at 03:45:53AM +0100, Marek Vasut wrote:
> > > Update drm_of_get_data_lanes_count_ep() return value documentation
> > > to match the drm_of_get_data_lanes_count() return value documentation.
> > > The drm_of_get_data_lanes_count_ep() is only a wrapper around the
> > > drm_of_get_data_lanes_count() and therefore returns the same error
> > > codes.
> > >
> > > Fixes: fc801750b197 ("drm: of: Add drm_of_get_data_lanes_count and drm_of_get_data_lanes_ep")
> > > Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
> 
> > > --- a/drivers/gpu/drm/drm_of.c
> > > +++ b/drivers/gpu/drm/drm_of.c
> > > @@ -539,8 +539,8 @@ EXPORT_SYMBOL_GPL(drm_of_get_data_lanes_count);
> > >   *
> > >   * Return:
> > >   * * min..max - positive integer count of "data-lanes" elements
> > > - * * -EINVAL - the "data-mapping" property is unsupported
> > > - * * -ENODEV - the "data-mapping" property is missing
> > > + * * -ve - the "data-lanes" property is missing or invalid
> >
> > I have no idea what "ve" means in that context. We should rephrase or
> > pick something more obvious.
> 
> "-ve" = negative, "+ve" = positive.

Thanks!

My point still stands though.

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]