From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 786A5200110 for ; Tue, 3 Mar 2026 13:22:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772544153; cv=none; b=KghbiDyW3jtu55i0hkuhqocaPbkFgRgcVmP/qGWhyQkilFVr2/r04Ho9oiStcoa3ie4RIus0OqPfLRNVKZ2bmsAMw/kqXNcwEll6LLqBf2sije2UBsU5/CY9pUkyVuamI9ms9HDo3HUPEJGWk+c1PQxd307Y/XWKDFjmOgiRjHw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772544153; c=relaxed/simple; bh=AA/rC8J0bWYxDqY4WhfEhh5yf0+vIt1t0AD3KtpELOE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BagKLgA5Ih+fxA20xPWmaYnDy0jYMerFpgMSn38fgUAI78BXqa3zE54YVk4dW/6TBSV32BQEs/8081zXTfVTwy35psCIYyczAT89fRwsBAhMH6TZEs/UOrjWqNmxR2gHYWhcCANQe8MpLerBnkS0MIGnekEKQF/EfNofAj2HnTc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mLQvoYFU; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mLQvoYFU" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4836fc075d2so6006835e9.0 for ; Tue, 03 Mar 2026 05:22:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772544151; x=1773148951; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=jhjoAq3MmovlrlE8lgBAJ1EdXOnr75atWGwQPHXyE58=; b=mLQvoYFUsaxB2oqpFTKAcasCdy0u/VYZvaQemjYO3XrJkRlFgdYLj1lpITml2savsP YeBuE5hcdvt2/VsZbk72aYv7GOgCJzuVS1PrqBS/rK8qngP7LOQ+zABCVtYC+OXnTSFr Ofo272WawhZi+sCmEtl/5QNx3UqHiVnuhUl1D9o2vVi3aTPrKPznwLpjOhIKQmTQ0odx j6YBkDAXHNcmD0+4Q5ZWstme2zjWUzlxto9+35unHn6fGOPHaFvFwOOYR/nxn215WGXT FGUMdM4V+JPItBx+tifRlDfX26Z8HChctwOmjyvR1QHqfoP6jptqyfOTHdipWuivgmZU ajjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772544151; x=1773148951; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jhjoAq3MmovlrlE8lgBAJ1EdXOnr75atWGwQPHXyE58=; b=aCCgsKawp97mdOHglTxj7Ar7DGHIzI9V/jE6B9/Zoy1tzlAgXuiP3kFpunp1k7479g WSvOYFHOvjyqn/9oJZBjIVqlurZdxNeZ7jOXLd17vCybTe4zPUj2KePO9pzrV7RJ0mR7 ESTKlrEsxU+1xMot53cHp1MD6g4J5oAkw6QAhs0x3pQYR8nH6joRcI6Zilm70zL3bCxC Vw2J7qlakqnntZd7uZli7o0WKhtnnfX1cGGizLHoFGpaQMia1HLlFmqTyymkjo6GBIIt ATIvXer0CaRLkCH7OUvBvHu67NPSj2E1I5VPfZZ9Cna6QbuYG3Gr1eZhAVw2vjoff+fE EIKw== X-Forwarded-Encrypted: i=1; AJvYcCXTeauQ+RPZrVNlWAQcu/HYfyd7bGAaWmCKckz+TD00Hc26z2tYjp2FGJ+uZRYB1Pv3/Aa+vibvRGpi+ro=@vger.kernel.org X-Gm-Message-State: AOJu0YymFvQGXm7E1683mRN9FuaxUyHnLCT72HAZSY0U64yhh8JvsCc1 NfQvB8nniGx0cbJIyHFTRq/WxOuh56nkz3I9bBpEpxq/jTBltyvUkygS7SQ0yw== X-Gm-Gg: ATEYQzwNlYVRlToBzh51q9jqgqq88EdrPFhnfU0M2I3+DvbXpCIlk2dbiQxaDgHrNRx vJqMrJPhrqj4esJEqRZBd2hWZ0tOvmZqIZM11v7x3vtFQJiFdHWMdib5Ol5ggDclIONf8e3BR7V nU4UehiII16qA2spcsjHZXgs7CabY+iIDVRr8zJk9foBkAPkH3CD7kqn2Ta5/7tqwCwfeXvP5Jo twlo8weeAqrcji2FCbKkDUqFBy1UNQpZo5N1aQED2fHhCvBTRvF82PNiC/4Zzsq2RY6LZTJtgNc alM4j802z/0MRMFvj7Ny0GxNwUfa7Hi88xnltVXW2UiY6lYAShWavto+9kkXzu1gM5YR91m0Rle juC9n5FNm9pMsDJ44SOmmV4j70ZvWSNZv29lxVAK1ZKSPkdYVNsFcvdaJo4rNNG0OyitYlgqPje v4pEMUk+aI+b7jO1o= X-Received: by 2002:a05:600c:8b56:b0:477:9fa8:bc99 with SMTP id 5b1f17b1804b1-483c9bba8cfmr153881545e9.4.1772544150700; Tue, 03 Mar 2026 05:22:30 -0800 (PST) Received: from skbuf ([2a02:2f04:d00e:3600:2472:8e4a:cf12:bb30]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-485135d0232sm15234605e9.28.2026.03.03.05.22.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 05:22:29 -0800 (PST) Date: Tue, 3 Mar 2026 15:22:26 +0200 From: Vladimir Oltean To: Jens Emil Schulz =?utf-8?Q?=C3=98stergaard?= Cc: UNGLinuxDriver@microchip.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Woojung Huh , Russell King , Steen Hegelund , Daniel Machon , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH net-next 2/8] dt-bindings: net: lan9645x: add LAN9645X switch bindings Message-ID: <20260303132226.6de5boh5pl6hi3hh@skbuf> References: <20260303-dsa_lan9645x_switch_driver_base-v1-0-bff8ca1396f5@microchip.com> <20260303-dsa_lan9645x_switch_driver_base-v1-0-bff8ca1396f5@microchip.com> <20260303-dsa_lan9645x_switch_driver_base-v1-2-bff8ca1396f5@microchip.com> <20260303-dsa_lan9645x_switch_driver_base-v1-2-bff8ca1396f5@microchip.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260303-dsa_lan9645x_switch_driver_base-v1-2-bff8ca1396f5@microchip.com> <20260303-dsa_lan9645x_switch_driver_base-v1-2-bff8ca1396f5@microchip.com> On Tue, Mar 03, 2026 at 01:22:28PM +0100, Jens Emil Schulz Østergaard wrote: > +examples: > + - | > + soc { > + #address-cells = <1>; > + #size-cells = <0>; > + > + ethernet-switch@0 { > + reg = <0>; > + compatible = "microchip,lan96459f-switch", "microchip,lan96455s-switch"; > + pinctrl-0 = <&lan9645x_leds>; > + pinctrl-names = "default"; > + > + ethernet-ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + label = "lan0"; Please remove labels from DSA examples. They do not constitute best practice, and it is preferable they don't leak into device trees by promoting them through binding examples. It is currently recommended to name DSA (like other) network interfaces using udev rules set up by user space. Using labels is perhaps only tolerated for cases where the udev implementation is sub-par, like OpenWrt.