From: Thomas Gleixner <tglx@kernel.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: x86@kernel.org, Dmitry Ilvokhin <d@ilvokhin.com>,
Neil Horman <nhorman@tuxdriver.com>
Subject: [patch 11/14] [RFC] genirq: Cache target CPU for single CPU affinities
Date: Wed, 04 Mar 2026 19:56:15 +0100 [thread overview]
Message-ID: <20260303154548.705513675@kernel.org> (raw)
In-Reply-To: <20260303150539.513068586@kernel.org>
Some places can be optimized by caching the target CPU for single CPU
affinities. That avoids finding the single CPU in the effective affinity
mask. Provide infrastructure for that.
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
---
include/linux/irq.h | 17 +++++++++++++++++
kernel/irq/manage.c | 14 ++++++++++----
2 files changed, 27 insertions(+), 4 deletions(-)
--- a/include/linux/irq.h
+++ b/include/linux/irq.h
@@ -140,6 +140,8 @@ struct irq_domain;
* @effective_affinity: The effective IRQ affinity on SMP as some irq
* chips do not allow multi CPU destinations.
* A subset of @affinity.
+ * @target_cpu: The target CPU when @effective_affinity contains
+ * only a single CPU, IRQ_TARGET_MULTI_CPU otherwise
* @msi_desc: MSI descriptor
* @ipi_offset: Offset of first IPI target cpu in @affinity. Optional.
*/
@@ -155,6 +157,7 @@ struct irq_common_data {
#endif
#ifdef CONFIG_GENERIC_IRQ_EFFECTIVE_AFF_MASK
cpumask_var_t effective_affinity;
+ unsigned int target_cpu;
#endif
#ifdef CONFIG_GENERIC_IRQ_IPI
unsigned int ipi_offset;
@@ -903,6 +906,8 @@ static inline const struct cpumask *irq_
return d ? irq_data_get_affinity_mask(d) : NULL;
}
+#define IRQ_TARGET_MULTI_CPU UINT_MAX
+
#ifdef CONFIG_GENERIC_IRQ_EFFECTIVE_AFF_MASK
static inline
const struct cpumask *irq_data_get_effective_affinity_mask(struct irq_data *d)
@@ -914,6 +919,14 @@ static inline void irq_data_update_effec
{
cpumask_copy(d->common->effective_affinity, m);
}
+static inline unsigned int irq_data_get_single_target(struct irq_data *d)
+{
+ return d->common->target_cpu;
+}
+static inline void irq_data_set_single_target(struct irq_data *d, unsigned int cpu)
+{
+ d->common->target_cpu = cpu;
+}
#else
static inline void irq_data_update_effective_affinity(struct irq_data *d,
const struct cpumask *m)
@@ -924,6 +937,10 @@ const struct cpumask *irq_data_get_effec
{
return irq_data_get_affinity_mask(d);
}
+static inline unsigned int irq_data_get_single_target(struct irq_data *d)
+{
+ return IRQ_TARGET_MULTI_CPU;
+}
#endif
static inline
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -217,11 +217,17 @@ static void irq_validate_effective_affin
{
const struct cpumask *m = irq_data_get_effective_affinity_mask(data);
struct irq_chip *chip = irq_data_get_irq_chip(data);
+ unsigned int target = IRQ_TARGET_MULTI_CPU;
- if (!cpumask_empty(m))
- return;
- pr_warn_once("irq_chip %s did not update eff. affinity mask of irq %u\n",
- chip->name, data->irq);
+ switch (cpumask_weight(m)) {
+ case 0:
+ pr_warn_once("irq_chip %s did not update eff. affinity mask of irq %u\n",
+ chip->name, data->irq);
+ break;
+ case 1:
+ target = cpumask_first(m);
+ }
+ irq_data_set_single_target(data, target);
}
#else
static inline void irq_validate_effective_affinity(struct irq_data *data) { }
next prev parent reply other threads:[~2026-03-04 18:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 18:55 [patch 00/14] genirq: Improve /proc/interrupts for real and add a binary interface Thomas Gleixner
2026-03-04 18:55 ` [patch 01/14] x86/irq: Optimize interrupts decimals printing Thomas Gleixner
2026-03-04 18:55 ` [patch 02/14] genirq/proc: Avoid formatting zero counts in /proc/interrupts Thomas Gleixner
2026-03-09 15:59 ` Dmitry Ilvokhin
2026-03-04 18:55 ` [patch 03/14] genirq/proc: Utilize irq_desc::tot_count to avoid evaluation Thomas Gleixner
2026-03-09 16:04 ` Dmitry Ilvokhin
2026-03-04 18:55 ` [patch 04/14] x86/irq: Make irqstats array based Thomas Gleixner
2026-03-04 22:18 ` Michael Kelley
2026-03-05 15:52 ` Thomas Gleixner
2026-03-09 18:12 ` Dmitry Ilvokhin
2026-03-10 10:15 ` Thomas Gleixner
2026-03-04 18:55 ` [patch 05/14] genirq: Expose nr_irqs in core code Thomas Gleixner
2026-03-09 18:26 ` Dmitry Ilvokhin
2026-03-04 18:55 ` [patch 06/14] genirq: Cache the condition for /proc/interrupts exposure Thomas Gleixner
2026-03-16 18:46 ` Dmitry Ilvokhin
2026-03-04 18:55 ` [patch 07/14] genirq: Calculate precision only when required Thomas Gleixner
2026-03-16 18:57 ` Dmitry Ilvokhin
2026-03-04 18:56 ` [patch 08/14] genirq: Add rcuref count to struct irq_desc Thomas Gleixner
2026-03-04 18:56 ` [patch 09/14] genirq: Expose irq_find_desc_at_or_after() in core code Thomas Gleixner
2026-03-04 18:56 ` [patch 10/14] genirq/proc: Speed up /proc/interrupts iteration Thomas Gleixner
2026-03-04 18:56 ` Thomas Gleixner [this message]
2026-03-04 18:56 ` [patch 12/14] [RFC] genirq/proc: Provide binary statistic interface Thomas Gleixner
2026-03-04 18:56 ` [patch 13/14] [RFC] genirq/proc: Provide architecture specific binary statistics Thomas Gleixner
2026-03-04 18:56 ` [patch 14/14] [RFC] x86/irq: Hook up architecture specific stats Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260303154548.705513675@kernel.org \
--to=tglx@kernel.org \
--cc=d@ilvokhin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome