From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 902CD34888A for ; Tue, 3 Mar 2026 18:17:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772561878; cv=none; b=Y3oo5fcuK6qyzAQy577cjDUzhPUFO7asL9ebgK49nhLDYBr5hipftEJbMBJQXGMFMwaIj5vJEtUqIZuIr+DyI4mzD8SZM3dRbCCaX2H4YZRog3cP036wK52WGYuhiKQHH7x7D9kB++dxZ+8aQwsCOR/D2JhsRLPjpCrp1IddVNg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772561878; c=relaxed/simple; bh=F+kLyH7oiFQe2yqxkuR04wlD3B0v04pYevpP/LMQApo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nVpP9m7tK9voSmeFyEwY7qVC5/xzs3hV3dr5tIQd7VpUVRDpNu1pOLlyf1hvWqmFMV7fo2O6NLc6iRYCvsmegCMUXFUpLXnLVytNUkqreC+H7SD/wo4tgTQlpGMNnzSAXjii7dxtT8Nm6HYZfJOsd+6sZ4pHs043ng4Cy/8A+cA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=QJwQhNbv; arc=none smtp.client-ip=209.85.160.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="QJwQhNbv" Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-507373bffd9so53459891cf.2 for ; Tue, 03 Mar 2026 10:17:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1772561874; x=1773166674; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Hf1Mz0pW5YKMXMt0KYQl20EDqy7u4HiooeYLyNLCljg=; b=QJwQhNbvHheO9YQPXe32bm8/IDCmLiGeG4F41Z7pP4f+He2ttEKJ70uuPQy4k6VPBH KKNbf3S4iv+IkEdpaSwZF8jJ801mIw9nCXylB0qxrPMdaIIe1Z5Ndr+K9n2Oucsr80R0 Lj09rcdOCT9FYnjGf84ww5AL5+KDwp5apNKso4RHlV1xvhhyu4viLVDJuBwfRqQYNygt uBPHBm5STTAfah3uCcVH6cyf8/E+rr6mIBzWlE9A/sGjUhyiB4f5UBkFoPgAKGgXUjDD JBEfKbWunyW0Ie556vDo282heYWTN+OugTkXPj3/NdSMtWV1clwhMFBV7MAIUPkHrW/1 u7TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772561874; x=1773166674; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Hf1Mz0pW5YKMXMt0KYQl20EDqy7u4HiooeYLyNLCljg=; b=bmXl8jUW0g99Rt8EIJOUgvsaO+tBwpCfo7ehEjq61YHRphhwKdi3dhUlGw644Z/mtw sZ+S5pxYg5FUVEvZa+7eS5TEezNHkW8vn1ilsLEHwwRavO8M+2xX7bWplFuFZXxvRsh+ cLxnPKCGNtHuAuwadi6cgiP86q5Zxuuo+gvfnCaSPS9QAxfUcqaJmCakORt3A/EH+7nt 6shR8viMK6ILwyuSUMgryWuqcU+OSYp84D2tL6oonKMFP3F7GbE6fDbf3ZoTDYWKF/ff 4r+oeKhnL8+5EqG7WDr6/O5ixxcj3TChATQ0ooGJlNWCeRzK9YA5vU65x9pukdBeQbtj 6xZw== X-Forwarded-Encrypted: i=1; AJvYcCXRC4advVMGWOPwpqZbnJNKSzA0WlcnEys/py+2JrjD5cdpTVFcZaODDcAUz1oA5wxRgM0cC77onOFxwuQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yx86Kh+fqlriTYpy2WX6YmoNkRXcdfA/PTNlj1Ocn+NkNvpDH0q ftYraXI0CZsp6IUdFofm1KXCUArD/cCSRT6LZZ9mlwRTHVA4bA8SoTJp+N3MOsnAzKE= X-Gm-Gg: ATEYQzznyCFflQixHoyX2o0vEZoZYj8enD9aMiaYasiDNxxVDwmcpRbQztPWVIOecmx FYYBfC8D10lJddMYM2R9LHPXWLOLII33+XgqWQ5bc/pGrgj8ZF3vwPvsg8nRfhRk5InOL9TbL1v 9o7+CC4I1fjZ4U17ZbaCkb0sJHHTDBfuxh9kPIDD0qXK/XfGlm2hXz7lpR9u8bYTjAa4C4lS9GD ikK/VyyPOS2athYqyjdcE3j5aPVPbU9g6ekJww/JtZ5Q8inPTcvw+6XN44a5huQY5y6JzrBT48D qqcy7rg1/8v1STyXUg/XG2y2lALPLLBAL/t9anej8YjI1d9hfnTy+dnal27JjG0tn9EI5ovIetF TQY8yTuhI+LPwxPkIQYs658DcWuunX0b8K9C0I9n00N5jFni8gs2AEWS3Zkegt3ZfNO8xEtFVLj 62eMBna+w/OKPp4Ce8nHO4Tg0P2ztgJbYje/31S0kmPvsa1vH1/japlcLuMqwcmKHv3YvBqCSCG JUuy5VF X-Received: by 2002:ac8:7dc7:0:b0:505:ec73:822d with SMTP id d75a77b69052e-50752981c24mr234443811cf.38.1772561874341; Tue, 03 Mar 2026 10:17:54 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-112-119.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.112.119]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-89a02f359f2sm37042696d6.24.2026.03.03.10.17.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 10:17:53 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1vxUJd-00000004PZl-0bgZ; Tue, 03 Mar 2026 14:17:53 -0400 Date: Tue, 3 Mar 2026 14:17:53 -0400 From: Jason Gunthorpe To: Ankit Soni Cc: iommu@lists.linux.dev, vasant.hegde@amd.com, suravee.suthikulpanit@amd.com, joro@8bytes.org, will@kernel.org, robin.murphy@arm.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/amd: Adhere to IVINFO[VASIZE] for address limits Message-ID: <20260303181753.GE964116@ziepe.ca> References: <20260302235715.GY44359@ziepe.ca> <20260303120554.GC964116@ziepe.ca> <4yddupv5soxmatbmcqqs4ndsffbls4r6eagoiaebalnlikx2jw@wtdby7qs6nz6> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4yddupv5soxmatbmcqqs4ndsffbls4r6eagoiaebalnlikx2jw@wtdby7qs6nz6> On Tue, Mar 03, 2026 at 05:11:07PM +0000, Ankit Soni wrote: > > I mean if FIELD_GET(IOMMU_IVINFO_VASIZE, amd_iommu_ivinfo) is 35 why > > not just pass it to hw_max_vasz_lg2 and be done with it? What is the > > point of limiting to only a few values? > > > > Jason > > I got your point, i added the check to match the spec, which defines valid > values are only 32, 40, 48, and 64. I don't think you should do that.. The valid values are the only ones a hypervisor should install, but the kernel should be permissive and accept everything.. Certainly it makes little sense to get something like 35 and expand it to 64. Jason