From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C04F376BDC for ; Wed, 4 Mar 2026 03:44:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772595854; cv=none; b=DT92pz5MVw+3OB15Dka80c6dvX1CSPbBFQqxpmdoXRfz9v5iCIWsSK0fKgy01BYDlH9Gjwr1XJiSUuKQgpR/Fwb4WSgSIrLH525nfCs7+HEwNagYbfe8fgsMg7qK7GvExUaHhXyqHnmi8KCQQUTH3XpH6/deoTvnBIqUGxFPo28= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772595854; c=relaxed/simple; bh=V3nE+XT6gJM1djPOVmmoXLkSIGNlRHxcehnXAsYeJSw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZYk4SJvgdPwODB4M0xf0hCsyTWsX+eB7GhKJBe3FTNr/8G1eEMP8YP3ovq7VvtA6e/e+/EpoaoSmAt7pMzWdvZqueB5tmv6PYhJymk1Qive2ksg9mRoENK04cdZ8XnnAKwGo2p7FJlrqrkQ4yZkxO9PZNVr+jd4weg8XDbLU5nk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UbmR68Fk; arc=none smtp.client-ip=209.85.160.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UbmR68Fk" Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-506a3400f30so55840521cf.1 for ; Tue, 03 Mar 2026 19:44:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772595851; x=1773200651; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ZmZUdiZZg0fCj/2i+g2j9xmvk9n9CjWeVFiVPCHQNYY=; b=UbmR68FkK7IIj+x9hLIlgrrZ26cZFQyULJysCgnfFl7nzbmOrpNa7nEAiH4y+lmQwa Cs1TKw5xXy/xEoSVWt83LWndJBOZoK1FVw2i8AXWRh8h6jxtGKBl5U2ieSgqyvPjUsmS tGKtGzN/TGhCXLfuvV9kX9a0j25u7HSCnMiwavyHG1Vy/6TkETTrrNq5vSc7kB2cYm2q gtR6c2vbgM+KxK1KNfR/sI2emqIl4v6i+RvLeZwEwFBv6TTQPuY198t2bgV3QDnXPevK gCe67X4z1OAIy+jWyPCqaemd6ZmEWXHgEicSU6RHLKRPmvGPsLi/HauC2oVe6yzqwCKn rM7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772595851; x=1773200651; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ZmZUdiZZg0fCj/2i+g2j9xmvk9n9CjWeVFiVPCHQNYY=; b=oNb9NZjHAoTPVWP+NyPJ/SEI6Zd3oW36zKmP/wmFDJCr0YpQP//oHmhSxeMpnoyvzr IAC/oHkJ6rcpjqObfHluxrwodXFZkaTTeKxMxBYGsoWl0N2qOLOHnTQvTDpxxOk5R6KX DPKKIKbsdVXlYQ6JIDn0IVFYz/gJx43dQl7BQzCn0RsFmOri32kJKQrUkHtsZbw23mri KtUL39KoL0fsIjbMtRnTh3SJI69sEQ0499Ng9+Lyg/9mUZs2pbiZeJGw2rRj0We805yA 8zOrYtiA++1yR9tZChQs6TVqnUuOFY8Jh/3Ctjw286WD/ss8OOS19Vd0hzO2TK67K6vP DcoQ== X-Forwarded-Encrypted: i=1; AJvYcCVvOO97B+SiCY5k4wXFZju99H0J2wrs+F/QyBSjDxpr8WBYnzpA4Ff62M4u3T7pCVVVs8QT8N74ig00Weg=@vger.kernel.org X-Gm-Message-State: AOJu0YyKRXzjk2eV/h2F6RZEHQnR4n+SKWCgmtn+uIqHU0cr8a/Veyy1 Bcq1nRtx+XfZSvejqzBqccUy9/q48f0GUkIH+8S8FvImKKT16KYPBBV5 X-Gm-Gg: ATEYQzwAp9tV5lnZ16Zb4tqSUsddagdZlIl+XmuxDC6vTUUs7FMxLDl5HgrrXhguXwy 835TyAz3OOeRBX39PbF8h0Zp9Ebbj70V6676EkWuQlDG1mzootuxeZH9s3hB3xQUzQzqAnInwFQ eiSSBlYRPyLRsjuW4itMJnZE/dit2TGd6APpaL3Y5+7Nov8xuIFc0GCJL4XCmXKfPXm9nVmgPO/ AKOxRPkjQTBKBio5aDrtLIAPrsAdYXU7ESNdUwiw+2iT6ED3Uz6/JSGeFCzEFlpoZb2KHm5DpZU eNDPDbWtSLMeK0NtpzU2vY2mYe7jDBj5yvA3CAFshii51pGWNzZ4yyKyEmd4hie0iuPZ7k2I3im boFYZEUwAWlxc5w6KbIO6z+eeB9upwggC/U+jGX39V4ECjB2vpHqoH5gtM0Y+Hrz8e1SSkYQVUD BgFL0UQHyHbBMc7tMTW7Y9y+r6eA8= X-Received: by 2002:a05:622a:1490:b0:501:4b9d:ad19 with SMTP id d75a77b69052e-508cea9b44fmr52007601cf.22.1772595851140; Tue, 03 Mar 2026 19:44:11 -0800 (PST) Received: from [172.17.0.2] ([134.128.219.200]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-899e608cfc6sm88603286d6.14.2026.03.03.19.44.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 19:44:10 -0800 (PST) From: Yuanshen Cao Date: Wed, 04 Mar 2026 03:43:45 +0000 Subject: [PATCH 2/2] pmdomain: sunxi: Add support for A733 to Allwinner PCK600 driver Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260304-b4-pck600-a733-v1-2-2f54efdb8cc2@gmail.com> References: <20260304-b4-pck600-a733-v1-0-2f54efdb8cc2@gmail.com> In-Reply-To: <20260304-b4-pck600-a733-v1-0-2f54efdb8cc2@gmail.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Ulf Hansson Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Yuanshen Cao X-Mailer: b4 0.14.3 The Allwinner A733 PCK600, similar to A523 PCK600, is likely a customized version of ARM PCK-600 power controller. It shares the same BSP driver with A523. According to the BSP provided by Radxa, unlike A523, it doesn't require reset. Make reset optional in the sunxi pck600 driver and add support for A733. Signed-off-by: Yuanshen Cao --- drivers/pmdomain/sunxi/sun55i-pck600.c | 53 ++++++++++++++++++++++++++++++---- 1 file changed, 48 insertions(+), 5 deletions(-) diff --git a/drivers/pmdomain/sunxi/sun55i-pck600.c b/drivers/pmdomain/sunxi/sun55i-pck600.c index c7ab51514531..8f9fdc3915bd 100644 --- a/drivers/pmdomain/sunxi/sun55i-pck600.c +++ b/drivers/pmdomain/sunxi/sun55i-pck600.c @@ -52,6 +52,7 @@ struct sunxi_pck600_desc { u32 logic_power_switch0_delay; u32 logic_power_switch1_delay; u32 off2on_delay; + bool has_rst_clk; }; struct sunxi_pck600_pd { @@ -151,9 +152,11 @@ static int sunxi_pck600_probe(struct platform_device *pdev) if (IS_ERR(base)) return PTR_ERR(base); - rst = devm_reset_control_get_exclusive_released(dev, NULL); - if (IS_ERR(rst)) - return dev_err_probe(dev, PTR_ERR(rst), "failed to get reset control\n"); + if (desc->has_rst_clk) { + rst = devm_reset_control_get_exclusive_released(dev, NULL); + if (IS_ERR(rst)) + return dev_err_probe(dev, PTR_ERR(rst), "failed to get reset control\n"); + } clk = devm_clk_get_enabled(dev, NULL); if (IS_ERR(clk)) @@ -193,7 +196,14 @@ static int sunxi_pck600_probe(struct platform_device *pdev) } static const char * const sun55i_a523_pck600_pd_names[] = { - "VE", "GPU", "VI", "VO0", "VO1", "DE", "NAND", "PCIE" + "VE", + "GPU", + "VI", + "VO0", + "VO1", + "DE", + "NAND", + "PCIE", }; static const struct sunxi_pck600_desc sun55i_a523_pck600_desc = { @@ -206,7 +216,36 @@ static const struct sunxi_pck600_desc sun55i_a523_pck600_desc = { .device_ctrl1_delay = 0xffff, .logic_power_switch0_delay = 0x8080808, .logic_power_switch1_delay = 0x808, - .off2on_delay = 0x8 + .off2on_delay = 0x8, + .has_rst_clk = true, +}; + +static const char * const sun60i_a733_pck600_pd_names[] = { + "VI", + "DE_SYS", + "VE_DEC", + "VE_ENC", + "NPU", + "GPU_TOP", + "GPU_CORE", + "PCIE", + "USB2", + "VO", + "VO1", +}; + +static const struct sunxi_pck600_desc sun60i_a733_pck600_desc = { + .pd_names = sun60i_a733_pck600_pd_names, + .num_domains = ARRAY_SIZE(sun60i_a733_pck600_pd_names), + .logic_power_switch0_delay_offset = 0xc00, + .logic_power_switch1_delay_offset = 0xc04, + .off2on_delay_offset = 0xc10, + .device_ctrl0_delay = 0x1f1f1f, + .device_ctrl1_delay = 0x1f1f, + .logic_power_switch0_delay = 0x8080808, + .logic_power_switch1_delay = 0x808, + .off2on_delay = 0x8, + .has_rst_clk = false, }; static const struct of_device_id sunxi_pck600_of_match[] = { @@ -214,6 +253,10 @@ static const struct of_device_id sunxi_pck600_of_match[] = { .compatible = "allwinner,sun55i-a523-pck-600", .data = &sun55i_a523_pck600_desc, }, + { + .compatible = "allwinner,sun60i-a733-pck-600", + .data = &sun60i_a733_pck600_desc, + }, {} }; MODULE_DEVICE_TABLE(of, sunxi_pck600_of_match); -- 2.53.0