From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C73F2EBBB9 for ; Wed, 4 Mar 2026 00:28:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772584104; cv=none; b=FTIYZQ05fzwifFwnCQIaca/6W8Sy7zxaRbL+wO0MMnAA+XZd3IB6FMfSVRH0pbTNu9pKoFQUkeDafFmmUil7HhdLIdZ+yJyRGoiE2xfj9AePOq4K0OFlhJNn1Z5rR+W8577YGsyfHnHPKPP4Ia8WjeIaq3mMLBKx+HaKiFxZTlk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772584104; c=relaxed/simple; bh=GXq7txbyhon90rY2Pd/0eLOL4txh9vwCy5I1bhGOThQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ilPhSAgE9mn8XbJPc3cvkhC3FnYZXzQVIHACQISpF0jQ4K22hVuSVsfmZN3Fqqpb61d/QRGebY+XlDyRRv4YNblPdLfkvEJbWrtriiOXh0DwYwofwRiR1oUVQXR93Cq6STW9vwOsNz20UlzvYULMKb0JIS4kGVhzGpAjF2jSAk4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RBzDNy4t; arc=none smtp.client-ip=209.85.222.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RBzDNy4t" Received: by mail-qk1-f173.google.com with SMTP id af79cd13be357-8cb5138df1aso607557685a.3 for ; Tue, 03 Mar 2026 16:28:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772584102; x=1773188902; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GXq7txbyhon90rY2Pd/0eLOL4txh9vwCy5I1bhGOThQ=; b=RBzDNy4tZVMtHGAr9rxv9wVVWhDdGMBfEQtb1/SYVcohfRgCnaKPDPEiVaxSjGr+FZ 5Cgo8vvHcRMKJW+96Xo1Syvq+rYcbYApmPOqytdzJTCBKj4tEMTBxd7FKKiCRwAjaSyF 2wIDeytGaz5F5074Y5rmqqWRGgKtqt3mMOq68JHhZdKFKjMgwaK2O4EJEyxrxl8xD6Ly NytrcEYwBndywc3eu7tmrj4ea2s/vI2ZNBO/dMtBUX4tbeED/2sV75qt1xtYDxBSP8tu kp/wdj5YgI3058E3YIcwSQ8OSdsT6cuCzTiFZtKT7yGBt0+CAVBtUovptYr2jW9F2qq4 q0dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772584102; x=1773188902; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GXq7txbyhon90rY2Pd/0eLOL4txh9vwCy5I1bhGOThQ=; b=eOWYuIA/0QdM+pqp91drY9uYQQhjuuzYDG1zadKA6pV4WquOgqgi8DaTa3sM121Y8A gy5GvNi1AQtmOV3nG98QlrnwiyLZQCJCk4AaE2OAdEpSTV2kezfenVXUm6zl90ofgvyg TZFsnFx2cMky4yErJHoOpSNJqQVOa/ft/xjcVQ9FLNO60W+/6JIUBJE+q91RFNb3uS28 ynLrwm4mNZ8MzPhb6QBnbD8x7GbRm7kJcj5EIJe69plotOraLGsGI8+OoHdPVPOE7sMb nCwvF1Fd/ArkphcOWnA4Kcx+u7KQD7plZdEDcBj12SOPOW7mRqH716QX184+Trfui+od t4xw== X-Forwarded-Encrypted: i=1; AJvYcCVnhLGixcmA3hvR0gfNJl1IushOFBBkplCVK4o4+r64/xMKsbRyFy3Lc/FqE+G3XI0p8q/m9FTdZhw7ZME=@vger.kernel.org X-Gm-Message-State: AOJu0YwTv85xd5SbuMeGI1MasZ24jj8XNLl36CLW+RSGysWjKpXzlpzq XC+VKoVW2am+guWNqfT+oMAOK3fP/ojUoIrZoD9JHYINeedXlcDojiwz X-Gm-Gg: ATEYQzxzUc/DyklYniNUY9q4XjK05SzuOhPDwd3mxYj4TRKGau3tSq1QS9ZMJxcgYyS XrXTSM8cW6BFSKjV3bQcSDKvPFW9pNcka1LdTEBEYpvXhkQz2mJjBymlPLb4qX0DZee3FeSf9Eo lXh0U767dJs4vOH5Z5OycBU6rkR+VlCrX5ny1W1Zg6JGatJ+KJ28nvfquNwBxLM5O1967rQAZnY B8JP10gdtEo+GU6AiWgSof5JUyEJxAKOLgMGqa6O1KyBU6AZRMZXznK0EnUb/P3UrVgLzVk2X7/ mAPx0A5t2rU+zVTcESwY61VolhABAeizP6EOGdyBi0nUPdmUkkh6Jmxe4mdxCmMh+0F9nNHpenz Iu3asTTJWghBS5dxflnnbEwhTAiL2AXm2ft+dguiyaATBBngE2cg1mPSjYkg8pEcGVCamuxYJHj 0vWcpNpbnw7QrQiiT55fvTMzIDhFSE8eme6JNv8TB9P93dXqs9OhNJU5lbKmN9zLYDGrYXwoB3h YUi54C4Q4w= X-Received: by 2002:a05:620a:2681:b0:8c5:2ce6:dc2 with SMTP id af79cd13be357-8cd5aec6a25mr47762985a.17.1772584102575; Tue, 03 Mar 2026 16:28:22 -0800 (PST) Received: from hp-strix-cachyos.localdomain ([174.95.22.172]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8cbbf6fb519sm1513450085a.29.2026.03.03.16.28.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 16:28:22 -0800 (PST) From: Kinn Coelho Juliao To: pratap.nirujogi@amd.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Bin.Du@amd.com, mario.limonciello@amd.com, sultan@kerneltoast.com, Kinn Coelho Juliao Subject: Re: [PATCH] media: amd: isp4: add system suspend/resume support Date: Tue, 3 Mar 2026 19:28:11 -0500 Message-ID: <20260304002811.95497-1-kinncj@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Thanks Pratap, Mario. I reviewed commit 0288a345f19b ("drm/amdgpu/isp: fix SMU warning during ISP suspend-resume"). I understand it marks ISP MFD children as syscore devices and manages their suspend/resume from the amdgpu parent via pm_runtime_force_suspend/resume. I'm curious about one thing though; on my current system (7.0-rc1), s2idle resume still hangs with the in-tree V4L2 module loaded. My out-of-tree module, which adds dev_pm_ops that call isp4sd_pwroff_and_deinit() before suspend, resolves the hang. pm_runtime_force_suspend() manages the power domain but doesn't tear down firmware ring buffers or V4L2 streaming state. If the camera was active at any point during the session when suspend occurs, the driver would have stale state on resume. That seems to be what's causing the hang on my hardware (HP ZBook Ultra G1a, Strix Halo). Is the firmware/streaming state teardown handled elsewhere that I'm missing, or does the V4L2 driver still need its own suspend path? Thanks, Kinn