From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CF9D29408 for ; Wed, 4 Mar 2026 05:33:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772602439; cv=none; b=TQmp4a+pFRoeAheR5oUbQHq9E9Cb0dH0FtsE5wBqHPDFsniYLnDJGcg/rDsGX91/b3CW6M2HaUQBHjv6lTEdx/Gahu4+1h4iwSs8WUqkhha4K70L718dWgU6xZ7+Khhqkd6t0suoIq6uhW96q6Ew3/JdqnqSomGPlLvvDqT7lT4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772602439; c=relaxed/simple; bh=uzOoseoi82x/JKFJUPAjExwnycUV7/9lrdQ5vJQV8U4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gGlXXwjTWCtHQLMr4PyxQVkopL6mr/bveu6eHO3pbRGJoG5qPwljNXo8ecBBiv5MlnXS+/MJT00EKjtXS1FChtuYtw2e0Rk6C3myrHJ+46M40B9sTgPIyVA0O6YsCrgZMX3lMTxYhzZ3pAgpl1zUSVpP3xys3fviqlLKU0BNFsg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lf7HLnpZ; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lf7HLnpZ" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-82746ed8cdcso4078042b3a.3 for ; Tue, 03 Mar 2026 21:33:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772602437; x=1773207237; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uzOoseoi82x/JKFJUPAjExwnycUV7/9lrdQ5vJQV8U4=; b=lf7HLnpZBqW8WM2MR22cBKA0gaLSbp7csst2yDvm0O8Oc12p+2P9W3IrMoE5Hun36N RvS9Q2CErdPl2M0fQMlFHIbsT+k12ej1pRnIDkndY2gznb4L7BUQsANVG021o6ULE3d1 qem2ZFO0CQHqFmDYU48IPtZv4wWZgDfobAP7oBjoPoh4uSMDMJro+WqnnkvJdWSfCxYB 4iwulOfmCDQGTS6rgun/cUnaOyLI4hV+/jwbrzYPFENLWMW61pvZOTpXZawKODpW145j XpxsagT6O+xOBlCmv0sL9QMsMn0+S2Rfp46dSSkxSSvMVM3qBeWILfFb6SiWbbX5W9iO gc2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772602437; x=1773207237; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=uzOoseoi82x/JKFJUPAjExwnycUV7/9lrdQ5vJQV8U4=; b=ONdXmvl6BOcFqxcUbe8FOvTKQsTXRF1u++QRa48Vt3MyiIs2htmOCDcfCRG4P5VdgE S3i2XeJxb+KncxCJr3c2N5MDgSS137DfbsIT90Uj5rdvje+Jk7ohc22sPaVYrZgRcZGa ZqYJGwSwfCuVxZfcJZRYHHGliWulUXMouk9zhPqQbM4LlEYLqMZTC5T20uk+eRRHpOce 7bdEODvAJP1hg7s3l/LLmcmdRcNJ9mcADQ7v+ZTo0UUtZvbYmot8HBgsltX1nqLulZbr goC+JC1zpt5LNZeqCdgZ+GFHpZnig6Vwqs+gS/Kq7MPERZnjt/f3XY7RgAyRcCS+rWES T34g== X-Forwarded-Encrypted: i=1; AJvYcCUE8yjHAbdF/TCJISGgSul5NT+4rVM90htUnMkbccs1RU+tsBMe4+cv1IMFBUutTCHJaMQpai85rniIxi4=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0NfP11pnNGshcFLLHZffdq2v1QeOQT5RXMAH+U0yFlTQE22Bv 6EsPo/7sqzIErIPEi/xsUIEHo7VUEOJc1imCfz+zB7DshdCETh4sb0XP X-Gm-Gg: ATEYQzwuyH7ttYzsAnz5YimwjpDWrN6uJEfp/zJXtEwmayDx0ApFg1xLM5SCvRt48Kp rvb4Qs5SjoDVz8o8lHQZHkTTyDDoQ/t/9CalOVNojuusiH1/9QQaeBNMEY43kOk9XKHF9aucNfs 7i3keY+ZM6WbO4RWRO8U2ZE8tFcC9Ju8I8FrlntXdMFLJox0p7KTfOWqhX8VfyIP3M4b1Z9mvuI v4xZBlrfI/1Vqr3D+fmcj/XjbfZ9AdGlxI7gTe+Z6LcO9GSa8QAJ2V8q0JRQSuYYCiOQ87HjVuw q4ou9FtP1uKfyYorAUwboXD9seVzoLeF9oiA7UWo8BgODrX+Hpq4TsQeyK5hWZx+kAimKyZ0aKn 6hbyUMT/IQN7VDtk8bBEszEoiTrOwqbDCxKo9cTag1N/1uofkbwdX8MokkNmoJqhIu7B+Th7YuH MjIga707lvZzKC8PxUAyCHaN1wRx+bA720S2utdN0f3comKptKUhgdXGawNFs+xNZ6d2AADUbPJ rp7uja8S/mEUvo= X-Received: by 2002:a05:6a00:3d82:b0:7e8:4471:ae6d with SMTP id d2e1a72fcca58-82972cffe08mr842208b3a.57.1772602437512; Tue, 03 Mar 2026 21:33:57 -0800 (PST) Received: from mi-HP-ProDesk-680-G6-PCI-Microtower-PC.mioffice.cn ([43.224.245.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82739ff325esm21416745b3a.37.2026.03.03.21.33.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 21:33:57 -0800 (PST) From: soolaugust@gmail.com To: jstultz@google.com Cc: kprateek.nayak@amd.com, linux-kernel@vger.kernel.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, zhidao su Subject: Re: [PATCH] sched/proxy_exec: Optimize proxy_tag_curr() pushable removal Date: Wed, 4 Mar 2026 13:33:50 +0800 Message-ID: <20260304053350.554922-1-soolaugust@gmail.com> In-Reply-To: References: <20260303115718.278608-1-soolaugust@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: zhidao su On Wed, Mar 4, 2026 at 10:28 AM John Stultz wrote: > Yeah, I agree we should use a sched_class-> method rather then doing > a big conditional tree. > > Oh hmm, good catch! So I think you're right that right now we're > leaning on the owner to be run without a donor before we return it > to the pushable list, which isn't great. > > I'll take a swing at addressing this (along with your other feedback > - this year has been hectic and I've only just now finally managed > to get back to proxy-exec upstreaming efforts!) for v25. Understood, and thanks to both of you for the thorough review. The sched_class->proxy_tag_curr() direction makes sense -- it avoids the conditional tree and keeps each class's pushable logic self- contained. And the missing proxy_untag_current() is a real gap I had not considered; good to know it will be addressed in v25. I'll drop this RFC and wait for v25. Looking forward to it.