From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 748BA37FF79 for ; Wed, 4 Mar 2026 11:01:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772622082; cv=none; b=pN1+zrnzG/+i6l9fhzL5ec7Sd5aJ1ZONq7rKugHU0m9U0v8I3Rtd6LZO07xYoD1pukwYGjICzzgV3CVLq3wUcm33lYjKad35/dOmiRg+jzH6iK3mD0hGLjRtcETZulARBKlGmSp23VzrI3sPJYs/9zT/CtcSkj4A3DKsJLZ/JGU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772622082; c=relaxed/simple; bh=cKZR252fdSUvuNQFUcCBTUoWI0/zB/XocAsUnuIVaDc=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=fGBbQ7Mn7mAVrQaTnNQq0HWAlu6kaMt0+EzbPtkecne5xAykFNkqQR32njVI9p7HcOgTMbWtMBAkcmVM02/m9i/nITdwHRA0DCbRokZ7f4tQtVWSBOL20qTE6Vy5lUCzCXv58i4DnKfMCe1CSw0nEeuloCJTLfpIwoaHGjLe5Mc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--joonwonkang.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=nd8woyYt; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--joonwonkang.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="nd8woyYt" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-35449510446so6397763a91.0 for ; Wed, 04 Mar 2026 03:01:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1772622080; x=1773226880; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=p3xCIEoo6ZEEEZ/p1n43Fi5RBMS2/xMTyiLoj4cZCz8=; b=nd8woyYtgioWNbyvQxS0KGuakq0aQHJVOhxn4GD3Fi9wU9x+VVDkzo4Z5jfaoYFx3g yRb+gTezV1rUwfcIhWZ2ffEBi1DYlyalaGx2SAoAVCz32HQu8eZtUUj62VttOB/hqtr4 PJlNZw+DFqAgltOWTYMfTt+g66/+9lTCOHYvkQ64PZKVpuyY5OF23yGLpZPJNtg2Ueky KT21FXFQuNdPKF0cuOZLrm9Ax12EQ65ZqkdUhlO6PFdfCxvwCcEjdfJXUF80z7z4/lXk l3vI3b56BjR6wdv4OjBHELchjHBRf5dGsSNFFS1PGYvBTvFJI94GOExvRvlyrRBudcys EYKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772622080; x=1773226880; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=p3xCIEoo6ZEEEZ/p1n43Fi5RBMS2/xMTyiLoj4cZCz8=; b=gS89tLGlZGY4JbmgP8QUY/aSSUpi7mrRqcojA50hQ5nFhz5gp+XR7QwUGaXRKFja3Z vX/IFe6KqFbbywqJ9fPvXowXRcHn+oEeuhW3TKnsmoM9KbY02rdWdwQa92EV1ubr7/dp oyLhInrNYxbBFRqYUf8ar1HX7CHqpFge483XpA013CNVH1ET1dcPPR5wYF44iKSbZ+PP YUIsAtgw3XmNB0PPANEqOmqyLSnHKqOixY3QgAht6Lsbcb3Ry/wVhMH6v5EtOkeeouSS tkG7Lm95ACk8gz9Mg/YiNff3+9w3ZeSVJ70ngJshQYsCJzluo37f3pSjblkIC5jRz8Pt iiNw== X-Forwarded-Encrypted: i=1; AJvYcCUkaQAH1qfRnALIK7wVVCRU7OoOMKi74sX3G7OAmKMuc2HRaugbPHH1CrgPXzJZ9mZ8AzMGzG1uhx677TA=@vger.kernel.org X-Gm-Message-State: AOJu0YwgDOk1kpRiGGfMsLGQyX3PboMvFOPai5xHWLEU37IjGF8PfssL wp9i2TPpdXUIFm6k57WAzlvtRtWr23O34eOE39i+TKVaw0TrtJ8X8YDM+DWT+/beFxDj7NoldNv wpHZGpwSwzxlbgbzPZu/WWHuT9Q== X-Received: from pga3.prod.google.com ([2002:a05:6a02:4f83:b0:c6d:c043:2cb4]) (user=joonwonkang job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:164c:b0:359:84e1:ba2e with SMTP id 98e67ed59e1d1-359a6a4a3a4mr1598087a91.18.1772622079611; Wed, 04 Mar 2026 03:01:19 -0800 (PST) Date: Wed, 4 Mar 2026 11:01:17 +0000 In-Reply-To: <2026030417-shudder-value-27ca@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <2026030417-shudder-value-27ca@gregkh> X-Mailer: git-send-email 2.53.0.473.g4a7958ca14-goog Message-ID: <20260304110117.3317293-1-joonwonkang@google.com> Subject: Re: [PATCH] mailbox: Prevent out-of-bounds access in of_mbox_index_xlate() From: Joonwon Kang To: gregkh@linuxfoundation.org Cc: jassisinghbrar@gmail.com, joonwonkang@google.com, linux-kernel@vger.kernel.org, sashal@kernel.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" >> [ Upstream commit fcd7f96c783626c07ee3ed75fa3739a8a2052310 ] >> >> Although it is guided that `#mbox-cells` must be at least 1, there are >> many instances of `#mbox-cells = <0>;` in the device tree. If that is >> the case and the corresponding mailbox controller does not provide >> `fw_xlate` and of_xlate` function pointers, `of_mbox_index_xlate()` will >> be used by default and out-of-bounds accesses could occur due to lack of >> bounds check in that function. >> >> Cc: stable@vger.kernel.org >> Signed-off-by: Joonwon Kang >> Signed-off-by: Jassi Brar >> [ changed sp->nargs to sp->args_count in the code and >> fw_mbox_index_xlate() to of_mbox_index_xlate() in the commit message. ] >> Signed-off-by: Joonwon Kang >> --- >> drivers/mailbox/mailbox.c | 6 ++---- >> 1 file changed, 2 insertions(+), 4 deletions(-) > >What kernel tree(s) is this for? Sorry, please ignore this patch. I have specified the proper kernel tree in other patches. Thanks.