From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC5193E51CA; Wed, 4 Mar 2026 22:03:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772661788; cv=none; b=P47CwMNfYCGOk/AZc/ZXZKD6FBOE6/I0eHeSYqfk0CyahcvbEJ0KwW0l6DYG1Qu9ADhHjt3LYQO4rwHsDO+X3ckwa8Th19Bpzk/VcHiO5UytD30LaaOyOIjsPk7jVY5wCPLjI5VcekaqBiO76m/AdJwDdJbpfrMydgqi2xjPGUw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772661788; c=relaxed/simple; bh=QcDeX+4A0lvHQQbRg9leLOGUG35mNFYWz5fL5TVLF1Q=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=UReHcx6aluB+F3msyf/OmEuif775EZsJte5BuxoYe6Q9ybMUITbjR6sAjdinuVdXVNpm9c/YbriRKGURo2FDaNYEKCeV8n2Kw7laNkHfMjsEG1F6S5X/fSP21Xyx0eeA+XjOyodZTZNRteOd/1VnGxM202AouKw8iLJSraYJUqk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=rlpLqS/K; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="rlpLqS/K" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A735FC19425; Wed, 4 Mar 2026 22:03:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1772661788; bh=QcDeX+4A0lvHQQbRg9leLOGUG35mNFYWz5fL5TVLF1Q=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rlpLqS/Kj6XuSnENrppvplSEKrxYqPvM+aALj0ec5JjEL9u5ixAsovpcNNV7ejj0S ljLr1AObex51OKKnoemq2v5AjE6O6xx8BW7Uq/Mxw9EQkmTCgKqYr0ac2XQl6ye+cM GGkekwE02kT/+Xw0PJzgRoeJlHS3jhSKzvw6sAt4= Date: Wed, 4 Mar 2026 14:03:07 -0800 From: Andrew Morton To: Yosry Ahmed Cc: Qi Zheng , hannes@cmpxchg.org, hughd@google.com, mhocko@suse.com, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, david@kernel.org, lorenzo.stoakes@oracle.com, ziy@nvidia.com, harry.yoo@oracle.com, yosry.ahmed@linux.dev, imran.f.khan@oracle.com, kamalesh.babulal@oracle.com, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, chenridong@huaweicloud.com, mkoutny@suse.com, hamzamahfooz@linux.microsoft.com, apais@linux.microsoft.com, lance.yang@linux.dev, bhe@redhat.com, usamaarif642@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Qi Zheng Subject: Re: [PATCH v5 update 29/32] mm: memcontrol: prepare for reparenting non-hierarchical stats Message-Id: <20260304140307.f51a33f77f6ddc1dfc0cf476@linux-foundation.org> In-Reply-To: References: <20260228072556.31793-1-qi.zheng@linux.dev> <46bgg2vwqvmex7wtk2fkvf454tqgaychb7l4odnnrx7svci5ha@vy4b4ophm763> <22cca07c-49e0-42e8-b937-7b1c7c51e78d@linux.dev> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 4 Mar 2026 13:57:41 +0000 Yosry Ahmed wrote: > > > What about this (untested), it should apply on top of 'mm: memcontrol: > > > eliminate the problem of dying memory cgroup for LRU folios' in mm-new, > > > so maybe it needs to be broken down across different patches: > > > > > > > I applied and tested it, so the final updated patches is as follows, > > If there are no problems, I will send out the official patches. > > If I am not mistaken, Andrew prefers fixups to what he already has in > mm-new (Andrew, please correct me if I am wrong). Yes, if the changes are reasonably small and the code has already undergone significant review. Although the mm-new branch is quite speculative/early so I guess this is less important there. Adding a sprinkle of -fix patches can be a pain all round, so nowadays if someone sends a replacement series I'll generate and send a what-you-changed-since-last-time diff. So - we can check that the diff matches the changelogged updates - reviewers don't have to re-review everything - the author can eyeball it and think "yup, I meant to change that". I believe this series is due for quite a few updates so a full v6 resend series would be appropriate. I'll generate the how-you-changed-mm.git email from that.