From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4529035AC0E for ; Wed, 4 Mar 2026 15:58:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772639904; cv=none; b=VdOveHENay6+JAuy+jqoIDS8CvoWw22Nv2NW0gNVCOKsAebhkPQ6ZrABk5cyznSG+Aq6fGE7IKL60hQGItet9aEqwkkCeW5uUbgZhSAKUrPF5O+jxWkONc/FMBTGi08PJZbG8v9YJKys8UlBtq3Pyxq+k8cWfwhaFf4X2hyAwXA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772639904; c=relaxed/simple; bh=MpMb9Xcs4/CrTop1yaufH8JVWEJ4IiYczfsYxp0w4Qg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=e7Y7KepJUnpKoV+KdkF+p+nU29ZbOo/rWrKFgSf1BLjy8eaIVTg3PcsGFJWq1Ee89nJoUNaWkmVI7ogi+CKS3sFNU+gazRq35Xr3dTUC0kIWn+L1I7jqpeBTEZEyJ5NpxVUdTNiN0JZaNdhbeaMTLRX398dIqRuWkJVbZHHG0AA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UgDpCbj/; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UgDpCbj/" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-354a18c48b5so6122915a91.1 for ; Wed, 04 Mar 2026 07:58:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772639903; x=1773244703; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=aOnCrhdJegN14Pwp5FsJabv2Wi4xLhwtkHY2ui0eSo0=; b=UgDpCbj/WEK1OPynkrqQyq3A5N+zhmyXTtRQ1Ojbasq9Pc1AKlgmjs0OTc8MFou7aC 8/EA/EV1R9H9g/NKh/JoLSrrHp1qBpI33ciZrw1h+Yk1e2JlPCIzNBLSuLx7zkDUxbeM aHLUeJdXviuVSKh9EFVikJ19s4/XeBvatzGPNksyY8Qk534fISwIlqzcmLGw0/usOhdc Sd/MWcp58jm62WWFMkm6kBKkngrpl5PNty7Js8lUWD64SCdQxgsB1tsLa7sh4VB07h3p p/eZiLCO8WqRCIkrKtv+YmSaAeYWjJYXnuNP9OjLI5rz2EmOQ45+O9vIYqWZMUsGM6sm X4Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772639903; x=1773244703; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aOnCrhdJegN14Pwp5FsJabv2Wi4xLhwtkHY2ui0eSo0=; b=Cz0RXPOcJN9vucuFWomSSPnIFTWEPTspg0Bm/pcIjhZFzXY6so3tIdC1qk6rSx+6N1 y1z2LVkSdlatD4GqFkcHuqpiXNhjWbdIscj1gLX548GSriBqauTiOKRVpLO8vmLbSC0A ylto6JXXDGIPy7IASyNxGgGPRLVGY9dIb9YUpZUD0xrf8hbVen2pIXdqJ43bo1VQdSPS 99zhyfAECzY3gFbbHiPC3/KOnros33eJvwyAp0jTc9IKEGieGcAHOkUllL2jkU7AfxjD RG9D/mHJLI6RB2FF1s5/fE9SlOI7XkdWTDDQqvqtWGaSzr6MpIYhFCCUb5zJn4zjLV6G e8ZQ== X-Forwarded-Encrypted: i=1; AJvYcCVN17SKHoWGDYrg7/0yVlHOdH1baYmxf8MSnyC5T0Pjx7u3CtX75FdlfbFAd2ZB+M24kuGqqi0H/igmXto=@vger.kernel.org X-Gm-Message-State: AOJu0YyjrdZHYd5yFCHem4ne94ReSfIXO8GOGjYt818PbIH2RV+X42n1 h99xwic+iheR4gfYM7Jar/85fxCeNjB83J0ghobmsHa3fqcJGZ3wmBrA X-Gm-Gg: ATEYQzyRFifjTgNzWCKOjiy/tE7UX1PopIzwWGQeNkzfBRO2Kn7/PCwkhOEN8SEemjJ Fw0ywa30jnSg6U8/Xc020cfMC3MEd9BG22bDGA7KaYIJVgb0Qx/yQtN/VT2M+PcyuyA0OGqFeB3 UtezlGSJukqOUbnHi6GVdwhz+HzYlumAfTIbkBzLTGlj+J5q24oNPJeVm8N1y1m0aax8Bmz39rU CSggGtgIKu/QDoumdl8A3BHH7wKOu8etxEtTEPjFNVNC71sI7BCr2BsiQ/sIzQLzYxzb3jrGqm1 fDu+7PqXJHLW5YUG/keHlmCXrFGz+wnBhOgFSXyklfIG3elZFIzjptAqtjk8r78vlwQx4LqoCjT /2sFbzpT8SRe1pm2qPIbMTkpVGiq16tHpQUZMRq0hNxukmWqXnOasODE2Uot8+jPwchUF782eTf rXFt0sg+8bp89j5ijiT9ZLxS39tULqHSwsg25tnl/6EYlGK4rHUOQpWiCzWmVuF8PqdzsFCi/v6 XQ1lbCCzwD62v+MAZD2+7Pf18I= X-Received: by 2002:a17:90b:1dcf:b0:359:7ae5:89e7 with SMTP id 98e67ed59e1d1-359a69c10ecmr2293681a91.4.1772639902574; Wed, 04 Mar 2026 07:58:22 -0800 (PST) Received: from tower (c-73-37-64-97.hsd1.or.comcast.net. [73.37.64.97]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8273a05e831sm19096426b3a.58.2026.03.04.07.58.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 07:58:22 -0800 (PST) From: Mark Adamenko To: linux-usb@vger.kernel.org Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Mark Adamenko Subject: [PATCH v3] usb: core: remove unnecessary goto in usb_create_newid_files() Date: Wed, 4 Mar 2026 07:58:12 -0800 Message-ID: <20260304155812.4559-1-marusik.adamenko@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The goto to 'exit' only returns the already initialized variable 'error', which would be 0. At that point it could not yet be anything else. Replacing with an early return 0 removes the need for the label entirely. Signed-off-by: Mark Adamenko --- v3: fix missing return statement at end of function --- drivers/usb/core/driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c index 2574e65bc640..752ff84a8dc1 100644 --- a/drivers/usb/core/driver.c +++ b/drivers/usb/core/driver.c @@ -186,7 +186,7 @@ static int usb_create_newid_files(struct usb_driver *usb_drv) int error = 0; if (usb_drv->no_dynamic_id) - goto exit; + return 0; if (usb_drv->probe != NULL) { error = driver_create_file(&usb_drv->driver, @@ -199,7 +199,7 @@ static int usb_create_newid_files(struct usb_driver *usb_drv) &driver_attr_new_id); } } -exit: + return error; } -- 2.53.0