From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FCE3386C2E for ; Wed, 4 Mar 2026 21:27:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772659634; cv=none; b=ll6DXN6S9hwrYv19Bpty8OFhX0EWCd5xnH074Q32KnvTITNctEHloACkLOSOrYw8f/tl10ZtnXoH7KXvZ8rgnFmD/CAuL7LcnUigkBWEqgWX28Zh6vsKFOuBbCADu5Ls0tBHJFiP0u4kxmfR3vZTvwQRmqjjmj5OIU8kDPwEAKw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772659634; c=relaxed/simple; bh=F2afGMEwB5uJJhwzMOSueMg3oN353FwXCET/CyT3Ua4=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=WURgUyO2Ddvs3r3OXxg9gABoQd+uZ4w4YCrcJlVky34r4rD5K/rLhM/JdPyKLEJMXzgNvPFwTwFKqb6+qxTuP/l9Z8vb++z8yk74apasSCcWuvrKDUx0pyXAZGrFHnIwgpncJ+dVaprznUx0HCez24WkkosU7sByUgCyhGoxNCA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OgMaEAta; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OgMaEAta" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4830f029407so13312115e9.2 for ; Wed, 04 Mar 2026 13:27:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772659632; x=1773264432; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QqrYXjS07WWLu9a4fdG6oSfjRISyxlXE1cioRIfnuGw=; b=OgMaEAta67kMRjiy2+PXMsfZCc54buSsmQsWDZ89VO42su/uR0ThK7xo7L8q7B0eLi +6ITt4/w6aihuTAx6qpSINENc7PiNwXMJqnRMXLgzJg0FuolW2yx7viSEWl1wbK1Ky+3 5/Lss2DZMzoAC3rieQ1GFvPuyWGntI7bfqkPU2WLoO9ZmJDqV0gPtJUI1POTeSuCjPgN pHftFwuz2ANoM420o9khLTQWTiOIg++qyjMaYOhVteYIuNXV5lXr35BtAJZd3Ds+jggQ FMAoUt3oJQlcccs2av8PepfCNx9nEOaJCnpqMKil9AuGyupyMwDM0aJUvJCiUeFPZ7sW ZucA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772659632; x=1773264432; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QqrYXjS07WWLu9a4fdG6oSfjRISyxlXE1cioRIfnuGw=; b=UTdd2wDffwbTTM9kWN+dbSGXopOxIlUXEuP7r2/Ex2XXE/qjXG3vxGr3eTfWUdVh8U kf4b5lup545sPhiw2Uy/zgXBNJj0WrL6NshQ6uKc0E4qqRJS4bnR5NUObDyIFAvNNB5G lEq0+Ti4SkzTlBkQgv9sD8r7mBfOl+FIBQFxAdZHO2fKodhjxaWW8runyza8qNLPIgC6 cClFzRb+60RpQDDFI7HrDjUcoVC1mTNlO/2DbxHubDmEr/LjgExo1czOXjzTdee/h5VL Pu23G0sERd7H/iLu3XQv14pPovidyaGH7lb+Lcq/ZvYuPhMMnbe7qKOfbe4oGXwb3i6n 25Hg== X-Forwarded-Encrypted: i=1; AJvYcCWCO/4PnjSe4aWC6sTXUEkAhqFhg0mfoV1LZoknCZ+0TiWyivD0CpoQCv4xj+kBWqYL7pzfUEd2l1XKQ64=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/zSTFAzuVEJdeqoL7h4ongnmysNstTOFcNvInpXv+lOSh0Pwr Hb9PLUJGrt5G7BR7Bl0n1DEFAyLiEIHPxrvqwnB6eAUS/zmTcprY5yGW X-Gm-Gg: ATEYQzxoFiGyE1khdA4h6Vk1E2IAROFqjfu/eMrIbLHwHbybcJQVFoBAcf/p0k2qaae 0TZPsDcHbV4+exkG/iZu1qE3VmgG6TeqosjR0tRHmyW5r5fXf2vTaEUYrdN6vHJlrheYm7GLubF VAOp5my/wjIKjUZ0kpGGG5g+KsEbbep3y9YwdM6FFX3gZw5BY6pqPc5lUbrKtHcFvFZjAf3v1vL SkuusLo6l0cYethgM71YInTQhgRT5r7ozmS95ND3V/PA+bWz+6ApXIeZuqls6jE+vxTvv/eyzZZ Ge04KPmPcK2Cv5eb7jpEXOQID5qTVhJ4qZyibGRrMM8LLtnjrtGibJhmwLqdF2q/3QM4JVrBhAV tYShDMyHaKpOPatY+40jAhsx03FHlzuSxTdPPPOYUlR4lnyCepwMNx44yvLp6j2GDWLt5+RrjAP dG0n0JRAWepjJEn+3RXWaQwh7bXQ== X-Received: by 2002:a05:600c:8b32:b0:483:7d93:9f8a with SMTP id 5b1f17b1804b1-4851982c755mr35027765e9.1.1772659631369; Wed, 04 Mar 2026 13:27:11 -0800 (PST) Received: from skbuf ([2a02:2f04:d00e:3600:16aa:c9ad:4288:9dcc]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4851a82dac3sm46980315e9.0.2026.03.04.13.27.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 13:27:10 -0800 (PST) Date: Wed, 4 Mar 2026 23:27:08 +0200 From: Vladimir Oltean To: Alexander Stein Cc: Vinod Koul , Neil Armstrong , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , linux-phy@lists.infradead.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND 1/1] phy: freescale: imx8qm-hsio: provide regmap names Message-ID: <20260304212437.z34yjprrovewmlm5@skbuf> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260211144949.1128122-1-alexander.stein@ew.tq-group.com> <20260211144949.1128122-1-alexander.stein@ew.tq-group.com> On Wed, Feb 11, 2026 at 03:49:48PM +0100, Alexander Stein wrote: > This driver uses multiple regmaps, which will causes name conflicts > in debugfs like: > debugfs: '5f1a0000.phy' already exists in 'regmap' > Fix this by using a dedicated regmap config for each resource, each > having a dedicated regmap name. > > Signed-off-by: Alexander Stein > --- > Same as the one sent in December but with an updated CC list. > > drivers/phy/freescale/phy-fsl-imx8qm-hsio.c | 23 +++++++++++++++++---- > 1 file changed, 19 insertions(+), 4 deletions(-) > > diff --git a/drivers/phy/freescale/phy-fsl-imx8qm-hsio.c b/drivers/phy/freescale/phy-fsl-imx8qm-hsio.c > index 279b8ac7822df..4ab45c9f53dff 100644 > --- a/drivers/phy/freescale/phy-fsl-imx8qm-hsio.c > +++ b/drivers/phy/freescale/phy-fsl-imx8qm-hsio.c > @@ -107,7 +107,22 @@ static const char * const lan2_pcieb_clks[] = {"apb_pclk2", "pclk2", "ctl1_crr", > static const char * const lan2_sata_clks[] = {"pclk2", "epcs_tx", "epcs_rx", > "phy1_crr", "misc_crr"}; > > -static const struct regmap_config regmap_config = { > +static const struct regmap_config regmap_phy_config = { > + .name = "phy", > + .reg_bits = 32, > + .val_bits = 32, > + .reg_stride = 4, > +}; > + > +static const struct regmap_config regmap_ctrl_config = { > + .name = "ctrl", > + .reg_bits = 32, > + .val_bits = 32, > + .reg_stride = 4, > +}; > + > +static const struct regmap_config regmap_misc_config = { > + .name = "misc", Since __regmap_init() doesn't keep a persistent reference to the config, just performs a deep copy of it (including regmap_set_name() -> kstrdup_const()), technically you could have gotten away with just a single on-stack regmap_config whose .name you kept changing for all 3 calls. But this is perfectly valid as well. Reviewed-by: Vladimir Oltean I don't think you need to do anything further, just wait for Vinod to start going through the backlog.