From: Yuanshen Cao <alex.caoys@gmail.com>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Chen-Yu Tsai <wens@kernel.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, Yuanshen Cao <alex.caoys@gmail.com>
Subject: [PATCH v2 2/2] pmdomain: sunxi: Add support for A733 to Allwinner PCK600 driver
Date: Thu, 05 Mar 2026 03:34:08 +0000 [thread overview]
Message-ID: <20260305-b4-pck600-a733-v2-2-ba6bbed7d253@gmail.com> (raw)
In-Reply-To: <20260305-b4-pck600-a733-v2-0-ba6bbed7d253@gmail.com>
The Allwinner A733 PCK600, similar to A523 PCK600, is likely a
customized version of ARM PCK-600 power controller. It shares the same
BSP driver with A523. According to the BSP provided by Radxa, unlike
A523, it doesn't require reset, as well as a different pair of delay
values.
Make reset optional in the sunxi pck600 driver and add support
for A733.
Signed-off-by: Yuanshen Cao <alex.caoys@gmail.com>
---
drivers/pmdomain/sunxi/sun55i-pck600.c | 35 ++++++++++++++++++++++++++++++----
1 file changed, 31 insertions(+), 4 deletions(-)
diff --git a/drivers/pmdomain/sunxi/sun55i-pck600.c b/drivers/pmdomain/sunxi/sun55i-pck600.c
index c7ab51514531..1d47bbd35ced 100644
--- a/drivers/pmdomain/sunxi/sun55i-pck600.c
+++ b/drivers/pmdomain/sunxi/sun55i-pck600.c
@@ -52,6 +52,7 @@ struct sunxi_pck600_desc {
u32 logic_power_switch0_delay;
u32 logic_power_switch1_delay;
u32 off2on_delay;
+ bool has_rst_clk;
};
struct sunxi_pck600_pd {
@@ -151,9 +152,11 @@ static int sunxi_pck600_probe(struct platform_device *pdev)
if (IS_ERR(base))
return PTR_ERR(base);
- rst = devm_reset_control_get_exclusive_released(dev, NULL);
- if (IS_ERR(rst))
- return dev_err_probe(dev, PTR_ERR(rst), "failed to get reset control\n");
+ if (desc->has_rst_clk) {
+ rst = devm_reset_control_get_exclusive_released(dev, NULL);
+ if (IS_ERR(rst))
+ return dev_err_probe(dev, PTR_ERR(rst), "failed to get reset control\n");
+ }
clk = devm_clk_get_enabled(dev, NULL);
if (IS_ERR(clk))
@@ -206,7 +209,27 @@ static const struct sunxi_pck600_desc sun55i_a523_pck600_desc = {
.device_ctrl1_delay = 0xffff,
.logic_power_switch0_delay = 0x8080808,
.logic_power_switch1_delay = 0x808,
- .off2on_delay = 0x8
+ .off2on_delay = 0x8,
+ .has_rst_clk = true,
+};
+
+static const char * const sun60i_a733_pck600_pd_names[] = {
+ "VI", "DE_SYS", "VE_DEC", "VE_ENC", "NPU",
+ "GPU_TOP", "GPU_CORE", "PCIE", "USB2", "VO", "VO1"
+};
+
+static const struct sunxi_pck600_desc sun60i_a733_pck600_desc = {
+ .pd_names = sun60i_a733_pck600_pd_names,
+ .num_domains = ARRAY_SIZE(sun60i_a733_pck600_pd_names),
+ .logic_power_switch0_delay_offset = 0xc00,
+ .logic_power_switch1_delay_offset = 0xc04,
+ .off2on_delay_offset = 0xc10,
+ .device_ctrl0_delay = 0x1f1f1f,
+ .device_ctrl1_delay = 0x1f1f,
+ .logic_power_switch0_delay = 0x8080808,
+ .logic_power_switch1_delay = 0x808,
+ .off2on_delay = 0x8,
+ .has_rst_clk = false,
};
static const struct of_device_id sunxi_pck600_of_match[] = {
@@ -214,6 +237,10 @@ static const struct of_device_id sunxi_pck600_of_match[] = {
.compatible = "allwinner,sun55i-a523-pck-600",
.data = &sun55i_a523_pck600_desc,
},
+ {
+ .compatible = "allwinner,sun60i-a733-pck-600",
+ .data = &sun60i_a733_pck600_desc,
+ },
{}
};
MODULE_DEVICE_TABLE(of, sunxi_pck600_of_match);
--
2.53.0
next prev parent reply other threads:[~2026-03-05 3:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 3:34 [PATCH v2 0/2] allwinner: a733: Add A733 PCK600 Power Domain Controller Support Yuanshen Cao
2026-03-05 3:34 ` [PATCH v2 1/2] dt-bindings: power: Add Support for Allwinner A733 PCK600 Power Domain Controller Yuanshen Cao
2026-03-05 3:34 ` Yuanshen Cao [this message]
2026-03-14 6:53 ` [PATCH v2 2/2] pmdomain: sunxi: Add support for A733 to Allwinner PCK600 driver Jernej Škrabec
2026-03-14 7:40 ` Chen-Yu Tsai
2026-03-18 18:19 ` [PATCH v2 0/2] allwinner: a733: Add A733 PCK600 Power Domain Controller Support Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260305-b4-pck600-a733-v2-2-ba6bbed7d253@gmail.com \
--to=alex.caoys@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=robh@kernel.org \
--cc=samuel@sholland.org \
--cc=ulf.hansson@linaro.org \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®