From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8C0A366DDE; Thu, 5 Mar 2026 08:22:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772698934; cv=none; b=AU6aeokrfnUmxlrwrfopA+Z77PtnXUXIn07K8XBgbro2Dwf+amHT0b/nB9CPreTz5XU8BWcPj23iYCUCRKSBN4UEOdPMwX72AW+3Q/jMHCHUYFYBMqScl4MhB8bhU0ZRiXwUzQGDhG+oIIhvB9pu/L2Oe1U5eZ23uafqlo1gggo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772698934; c=relaxed/simple; bh=WNQaYbqsWl5GcqsRD9xTGJysvUcTpIBJXQIESqnEV2g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Nuywwf6H+b3wncmoDltkP/kqNRh1HSv0FZVJ1kLe/l8rW6r8OFkkoakc6Gd8i0+gWXM2+ddhj8ZmJloVFjJLSLoz/hCByHzCbMLD03wD2qCo8bIhwtATmpUvmWzA4q/NHqmfUBbcOzvAnhQLSFDFQ5q7KiUdPJ8VlseF9NjButY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JCXNaCh8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JCXNaCh8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C6EC5C19423; Thu, 5 Mar 2026 08:22:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772698933; bh=WNQaYbqsWl5GcqsRD9xTGJysvUcTpIBJXQIESqnEV2g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JCXNaCh8NDzazx2GC3TYspB6/Yro1LA51C2/VZsUC94X3UhWCLZ5+89NkpmxyNcHb WZwX9Vv+q1kLJIINsrTKHa6xPepwK4aFRdDIUuv3pBwZ89xwYvugHdn8q1KrbbN+3X 4ixS/Wf6lFW5404jQMC36jH9YSYV+qsSqRrWQE66By8OYv3MaVRjx3meEFE4tYvwn6 eUuVox3CM64qqurrmmHzOUQRLmYLPg52WGjJkVRUnquj98C7EfkdIMGq5IWYDB6pcS UhhMczVPC0uM11zlsuxx0RmloJ7A/giL1d8j2rBA42dgjZgwFpGhpoQjobeAewtPmF 4w99n2IXxxtdQ== Date: Thu, 5 Mar 2026 09:22:09 +0100 From: Krzysztof Kozlowski To: Kaustabh Chakraborty Cc: Alim Akhtar , Rob Herring , Conor Dooley , Krzysztof Kozlowski , Kees Cook , Tony Luck , "Guilherme G. Piccoli" , Andras Sebok , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] arm64: dts: exynos: add initial support for samsung-j5y17lte Message-ID: <20260305-gentle-important-starling-48ca1b@quoll> References: <20260304-exynos7870-j5y17lte-v1-0-eb25902c84c8@disroot.org> <20260304-exynos7870-j5y17lte-v1-2-eb25902c84c8@disroot.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260304-exynos7870-j5y17lte-v1-2-eb25902c84c8@disroot.org> On Wed, Mar 04, 2026 at 10:56:54PM +0530, Kaustabh Chakraborty wrote: > From: Andras Sebok > > Add initial devicetree support for samsung-j5y17lte (exynos7870) > > Signed-off-by: Andras Sebok > Signed-off-by: Kaustabh Chakraborty > --- > arch/arm64/boot/dts/exynos/Makefile | 1 + > arch/arm64/boot/dts/exynos/exynos7870-j5y17lte.dts | 528 +++++++++++++++++++++ > 2 files changed, 529 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/Makefile b/arch/arm64/boot/dts/exynos/Makefile > index fa6e6308e30a9..76cc23acb9b29 100644 > --- a/arch/arm64/boot/dts/exynos/Makefile > +++ b/arch/arm64/boot/dts/exynos/Makefile > @@ -8,6 +8,7 @@ dtb-$(CONFIG_ARCH_EXYNOS) += \ > exynos5433-tm2e.dtb \ > exynos7-espresso.dtb \ > exynos7870-a2corelte.dtb \ > + exynos7870-j5y17lte.dtb \ > exynos7870-j6lte.dtb \ > exynos7870-j7xelte.dtb \ > exynos7870-on7xelte.dtb \ > diff --git a/arch/arm64/boot/dts/exynos/exynos7870-j5y17lte.dts b/arch/arm64/boot/dts/exynos/exynos7870-j5y17lte.dts > new file mode 100644 > index 0000000000000..d685bc0703cff > --- /dev/null > +++ b/arch/arm64/boot/dts/exynos/exynos7870-j5y17lte.dts > @@ -0,0 +1,528 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Samsung Galaxy J5 (2017) (j5y17lte) device tree source > + * > + * Copyright (c) 2024 Andras Sebok > + */ > + > +/dts-v1/; > +#include "exynos7870.dtsi" > +#include > +#include > +#include These are ordered by name so interrupt < input. > + > +/ { > + model = "Samsung Galaxy J5 (2017)"; > + compatible = "samsung,j5y17lte", "samsung,exynos7870"; > + chassis-type = "handset"; > + > + aliases { > + mmc0 = &mmc0; > + mmc1 = &mmc1; > + mmc2 = &mmc2; > + serial0 = &serial0; > + serial1 = &serial1; > + serial2 = &serial2; > + }; > + > + chosen { > + #address-cells = <2>; > + #size-cells = <1>; > + ranges; > + > + stdout-path = &serial2; > + > + framebuffer@67000000 { > + compatible = "simple-framebuffer"; > + reg = <0x0 0x67000000 (720 * 1280 * 4)>; > + width = <720>; > + height = <1280>; > + stride = <(720 * 4)>; > + format = "a8r8g8b8"; > + }; > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + pinctrl-names = "default"; > + pinctrl-0 = <&key_power &key_voldown &key_volup>; > + > + key-home { > + interrupt-parent = <&gpa1>; > + linux,code = ; > + label = "gpio-keys: KEY_HOMEPAGE"; > + gpios = <&gpa1 7 GPIO_ACTIVE_LOW>; > + }; > + > + key-power { > + interrupt-parent = <&gpa0>; > + linux,code = ; > + label = "gpio-keys: KEY_POWER"; > + gpios = <&gpa0 0 GPIO_ACTIVE_LOW>; > + }; > + > + key-voldown { > + interrupt-parent = <&gpa2>; > + linux,code = ; > + label = "gpio-keys: KEY_VOLUMEDOWN"; > + gpios = <&gpa2 1 GPIO_ACTIVE_LOW>; > + }; > + > + key-volup { > + interrupt-parent = <&gpa2>; > + linux,code = ; > + label = "gpio-keys: KEY_VOLUMEUP"; > + gpios = <&gpa2 0 GPIO_ACTIVE_LOW>; > + }; > + }; > + > + memory@40000000 { > + device_type = "memory"; > + reg = <0x0 0x40000000 0x3e400000>, > + <0x0 0x80000000 0x40000000>; > + }; > + > + pwrseq_mmc1: pwrseq-mmc1 { > + compatible = "mmc-pwrseq-simple"; > + reset-gpios = <&gpd3 6 GPIO_ACTIVE_LOW>; > + }; > + > + vdd_fixed_mmc2: regulator-fixed-mmc2 { And this should be regulator-1 or regulator-xvx (see bindings). No need to resend for these. Best regards, Krzysztof