From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B43F63264CB for ; Thu, 5 Mar 2026 18:01:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772733718; cv=none; b=O6qSrYEFN47cHALDM6ChcYU6RXxBznISkZPWndCUz4gltwlmKBxMo9TYB0Wo4vmMY1PaWxTpCU1jo5UMhrr4XYQ6YykqBP7PlsLpRM+HLK8DjDAGLEWb5x7n3UZpMDw6fTwE+SXt4avUk7QlFoYz5prezwseH685RQV9vEjIEaw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772733718; c=relaxed/simple; bh=pXdruElE9YtMNc6wu0Lhl4IF6VsogSDzYLH2njRPexo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YU/xW3T/znAId3YKPrP8li34lei3c05jbdLVYaPNpo6c4e3inR3AZutK7+Q9k/mPllEBBOao6SmD+3u2dD9Rq9ME+zT7N9tj1b1VIGfCPcwqprOEv+KYbGmjNVAEpO6+X3rISgG3+3UBB5/NIrOAtYTCUHIvkKtHLR9OS820dGI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=SVGaVbKN; arc=none smtp.client-ip=198.175.65.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="SVGaVbKN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1772733717; x=1804269717; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=pXdruElE9YtMNc6wu0Lhl4IF6VsogSDzYLH2njRPexo=; b=SVGaVbKNssPhUXHA2D8iWpiSWEyd8Sv1qpIZ5s3HD1RxRAQ2BjzLpfQx Ow22bWNuxZ1hFim4ewOTWgyAqdq3JskvAKYJ40Dp3ElctcovHGKP/rfFn W0gHbOUn+UgeGJV0v5x3na1MoooEdYYB6REd1o/7LnnYwY+zFrKYAC6sQ nM1OrldlsTtr/975BB4Krj0HMgApc73doFrnP0YO0s1AoN77k+3bw1EX7 9iYKi/79LK0ubSjJwvaCaG7g1s8Ii6M+ivyFDcqLNnyylxv1358NO3QRN SWHhTZCY3XdN5yGdtSYV5454Mw/3tgewLOkBqakjjbqEQacM60+6Ic8fT w==; X-CSE-ConnectionGUID: L3ivkaQOSjaZYhzaIgLONg== X-CSE-MsgGUID: Myccd5zJSoaLM97tEodPbg== X-IronPort-AV: E=McAfee;i="6800,10657,11720"; a="74022354" X-IronPort-AV: E=Sophos;i="6.23,103,1770624000"; d="scan'208";a="74022354" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Mar 2026 10:01:56 -0800 X-CSE-ConnectionGUID: tR32G648QzeWNFDoDOCU1A== X-CSE-MsgGUID: UuAfp4seQSiH47f3ofAOlQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,103,1770624000"; d="scan'208";a="249227622" Received: from guptapa-desk.jf.intel.com (HELO desk) ([10.165.239.46]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Mar 2026 10:01:56 -0800 Date: Thu, 5 Mar 2026 10:01:50 -0800 From: Pawan Gupta To: Sohil Mehta Cc: Dave Hansen , linux-kernel@vger.kernel.org, zhao1.liu@intel.com, Borislav Petkov , "H. Peter Anvin" , Ingo Molnar , Jon Kohler , "Peter Zijlstra (Intel)" , Thomas Gleixner , Tony Luck , x86@kernel.org Subject: Re: [PATCH v4 1/4] x86/microcode: Refactor platform ID enumeration into a helper Message-ID: <20260305180150.zuqm7mycpbegrh3u@desk> References: <20260304181016.85EC87C7@davehans-spike.ostc.intel.com> <20260304181018.EB6404F8@davehans-spike.ostc.intel.com> <20260305013853.3riphxey733tokly@desk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Mar 04, 2026 at 10:28:13PM -0800, Sohil Mehta wrote: > On 3/4/2026 5:38 PM, Pawan Gupta wrote: > > On Wed, Mar 04, 2026 at 10:10:18AM -0800, Dave Hansen wrote: > > >> Also note that the PII is weird. It does not really have a platform > >> ID because it doesn't even have the MSR. Just consider it to be > >> platform ID 0. Instead of saying >=PII, say <=PII. The PII is the > > ^ > > I think you meant PIII here? > > > > What Dave has here is correct. You can blame me for the confusion. > Family 6, model 5 is DESCHUTES but Pentium II and not III. > > I incorrectly named it INTEL_PENTIUM_III_DESCHUTES in commit > 7e6b0a2e4152 ("x86/microcode: Update the Intel processor flag scan > check"). It should have been named INTEL_PENTIUM_II_DESCHUTES. > > Anyway, there are no other users of this. So after this series merges > I'll send a cleanup patch deleting the #define completely. Ohk, thanks for the clarification.