From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEF483ED13B for ; Fri, 6 Mar 2026 16:16:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772813766; cv=none; b=F6mbGKlKKbckjNgc2T1t6ZhfnhnSviHpkJ9a4XPTrH2LCSeFKVfaIjrw0K56dOA0T0wjEbPT9NMDCSCLCXUWkY1aC2WzSg4E2cPmk+yYBeNlNTDDKmJfQvKZSdKS3SLhk59QK1choNwSgXt2LKMm6WYKe1LdB9wiUKNZfKOgkh0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772813766; c=relaxed/simple; bh=1QMaxyD1F9yKwzn/BVzoZDlX+0p80VII8mbLuRl01WU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=gnCqca5ERYIWNVVNt0dhy3ji1W/Sf70kQqIuFod0hO42sehxg0dDjnW1OeMyifjgIicdhGxN1miJUrqaVYDsZXr1SMgQK7D6AYvHv8i1/479HAX0V6JGTVnxyMNPVyKmXva3bUm3APBj2apYatDNbgI7kQpUjqumGyhCocqryhE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 026E559A1B; Fri, 6 Mar 2026 16:15:56 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: rostedt@goodmis.org) by omf02.hostedemail.com (Postfix) with ESMTPA id EF40C80011; Fri, 6 Mar 2026 16:15:53 +0000 (UTC) Date: Fri, 6 Mar 2026 11:15:54 -0500 From: Steven Rostedt To: Dmitry Ilvokhin Cc: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH 0/8] mm: introduce zone lock guards Message-ID: <20260306111554.2bb29b05@gandalf.local.home> In-Reply-To: References: X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspamout07 X-Rspamd-Queue-Id: EF40C80011 X-Stat-Signature: fpbqkundi4nqeqt9ae7kcict3bpmuh5e X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX1/tuoj/FLMPa0UPrYOx7INpk/t0Ezcuz70= X-HE-Tag: 1772813753-241209 X-HE-Meta: U2FsdGVkX18o2yCoAdNudJeUMcXbnJEYHu+uAzjxxnehAq7dDUP/xmvv8xmVDKJ+sHdFfRBbTFzK07D9SBVNG5lu0qwnhTVsnM0o5Gy4q6LyibMOFHlIKceH6YgDFyDb4ZybrsY35RjwPhrNL8y2bWtIUgcw7+xgUv0gar9Sr7WU2RNOGA6X1f1GYYlhnTWxe4CqRoS/n0zqBTw814P8ihlQb3gz9bjChSO0Ow58vqnWJ8iuH79Z5OsmOuK5oWi0nk+aChJ5I3ofXEfZxGeaLcUGBrRgbUYqKx49GI8648/JWtoDNmHF3fqmrgZqGdc8wsxmZ6urtG+pqAnLpwBi19wHYtu6vyzOr049HFbEac+QJcz9neQK7Ba9DGybJ8ILp/AAaOfTCqbX29HClISE4gyQh41ENihXnfQX3kPpC/irPqTZBMUjIfoWA3DSxkPM On Fri, 6 Mar 2026 16:05:34 +0000 Dmitry Ilvokhin wrote: > This series defines DEFINE_LOCK_GUARD_1 for zone_lock_irqsave and uses > it across several mm functions to replace explicit lock/unlock patterns > with automatic scope-based cleanup. > > This simplifies the control flow by removing 'flags' variables, goto > labels, and redundant unlock calls. > > Patches are ordered by decreasing value. The first six patches simplify > the control flow by removing gotos, multiple unlock paths, or 'ret' > variables. The last two are simpler lock/unlock pair conversions that > only remove 'flags' and can be dropped if considered unnecessary churn. > > Based on mm-new. > > Suggested-by: Steven Rostedt Thanks, the code looks much cleaner. Reviewed-by: Steven Rostedt (Google) -- Steve