From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5B3A17DFE7 for ; Fri, 6 Mar 2026 23:10:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772838629; cv=none; b=giwWV4fLqWOPnLsTp3F71yB/6kDKyXlXlgnCNSPVI0aHLReif5XiuGLUqiharDLs4wzbpv6Z9g4i0czuoK86IaZjNtFijMa9nLVBVxbcJ+YmTlozHw7/IPFKGdv6jtpAzJno8m7UUDQ7/cGIKDF3y6Bc6zyE4ZEv+zyJAsbBZAQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772838629; c=relaxed/simple; bh=+Wo2K/X+Cq11I5YoP13/K61MVEHaQ70AgPIyYdTnDro=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GGXSQe/UPAJhWHF+U/txasAvFL4RC88WMD9OQTtd5EOUGCv2akhXmWzGPSX8+Y8B1Vlb6H/P1zA11C/W/71Gnyx+Iz4VS89buTcO0UzKE6xrqsbGoXB3IT1G5kEKLT37YSBe17c37TtfopVGuiYaqorbMw4JUcw++1tX4VFUCyw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=Wsg+1JCV; arc=none smtp.client-ip=209.85.160.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="Wsg+1JCV" Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-5062fc5d86aso85548641cf.1 for ; Fri, 06 Mar 2026 15:10:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1772838626; x=1773443426; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=X8xiVcJi/2j0+t3xwC2rYaGHbViIQdp0Z+nSHzUs3cI=; b=Wsg+1JCVrTec4XkcLEFsr9/nUlMWupW7x2g3G1YUHiDimWJ77Yg6+qfbLvAAaUk2SW vkP4fZhatWRyjQ3Fvq+pKs5TALFNAMK4wDFqo3aqiOpGiXINJ7ErRJy+E54PaiMmSomB +WmlTB6RyNlxDd3GPsklgNbgCLdA9wFdb4xAFw0I4hFGhw8EKHUvMH+Pf6Olqj1iKJCq 4OxPR2+3s6SWyTRqPz4x2C4hbqF/8YZ/2JZxNKbQ/NWATHTHPxY0Pt9lk1NP45z3qldq kXOYHO6y0EaFBu0gEsAN1i7cd4x+DAmBLq5R0yicZ3nc8F7e+IXOa+P5bHLm29VUQVfK 2rXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772838626; x=1773443426; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X8xiVcJi/2j0+t3xwC2rYaGHbViIQdp0Z+nSHzUs3cI=; b=kylWrwcJ0dhchr96Do3wsbxbk3+vfb+eG6+KcGOBWYwwDEp+tw2VxxbrduCCBC0LVZ i01kgonqsMHq64i6LsrYktt6mjK4xxojA7TyHhiFXT1Adnlmefd3LS9db8PQw/FYNNyb XsPamgl4uEdt0Ov5UYmmibXSmtJgF+g0RE4kV/TAtnGkg65M4Ew/piud/7vOXR82y6Yo F5Ac0u0kqVsCnpoLbDoKwElUOm/SfkbSNE49NrZTgYnrk97YB260Q7frL0jlrRb5ohSX 5wxXtgtMFqcFCfm44vXu7nc24JCjQHjXFHYWzou1eDuAkKA0qEmmVk1ywLto/njLjJLf tXHw== X-Forwarded-Encrypted: i=1; AJvYcCWOZsetBECqi3G3dwYLFy2KEwb3lLxZ3E3cS3salUqtsCOSFKTgOU7nFoVPzcqFURIMrPpL59op1kTFAHM=@vger.kernel.org X-Gm-Message-State: AOJu0Yxmtsrod2NGBHoODq/ucHhN2Kg0DW0dBUcu0uOIuqmmDGYVsydb LzZ/vqwQA1sr4NSGRDCyXPYHUXvcFmkBsrDDI0X1S1FjI9CkemnZZ3/O+D/Ztpapwig= X-Gm-Gg: ATEYQzzHXxLraSKqz6NoWT3ucojgKqVesK4eTgI+QUlAwGunHQ3utkZCpey/OcxJfAx MkRZO5FSobSX91SitfspY7QCK/gqTvg9bKzVM4M2qbMlmYHm+Fl9XZNbNEafyWySBfH45FDuFKY +ajzOOl5OxGkZbw/ClGETNiKLuM0BQu9nbbO3X31VYxSfak6+R5zj3W2VqTw7oI97YXS4f3HKKn XgAtYViU7OsC0P3grBCYd10ypE2oDp6jMybLaODOy8vtq35htoj4KC62VddtduzI3OfuDXvgB67 9QVKjBA0SxZSwJaLBn37aMeOy+30FYEHI9a+WwaqVpA/QRR8WCzS5h4oPtb3AEC5dfZ0d2eVu3I GtT6g2lGxLuaYTgsaJr5raUy4WNU76QAEIomemdCTI7rOPN0V266McUwsF2qjPxW7gWIjLcVy+4 dxUgDzKGrGk2lyZwzIoLf7rU7q9xk1q6kI//0Mf03alnKeFfTY/RrESGlFzVfRbvRmPac3vU0uK nHLfXhH X-Received: by 2002:a05:622a:11c1:b0:506:9b96:6283 with SMTP id d75a77b69052e-508f49980eemr54331101cf.66.1772838626596; Fri, 06 Mar 2026 15:10:26 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-112-119.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.112.119]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-508f66ce03esm18225341cf.27.2026.03.06.15.10.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 15:10:25 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1vyeJM-0000000FcSI-0t9y; Fri, 06 Mar 2026 19:10:24 -0400 Date: Fri, 6 Mar 2026 19:10:24 -0400 From: Jason Gunthorpe To: Praveen Kannoju Cc: "saeedm@nvidia.com" , "leon@kernel.org" , "tariqt@nvidia.com" , "mbloch@nvidia.com" , "andrew+netdev@lunn.ch" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "netdev@vger.kernel.org" , "linux-rdma@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Rama Nichanamatlu , Manjunath Patil , Anand Khoje Subject: Re: [PATCH] net/mlx5: poll mlx5 eq during irq migration Message-ID: <20260306231024.GF1687929@ziepe.ca> References: <20260304161704.910564-1-praveen.kannoju@oracle.com> <20260304201151.GI964116@ziepe.ca> <20260306003217.GB1687929@ziepe.ca> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Mar 06, 2026 at 02:19:09PM +0000, Praveen Kannoju wrote: > > > On Thu, Mar 05, 2026 at 05:08:52PM +0000, Praveen Kannoju wrote: > > > > > Regardless of the underlying causes, which may include IRQ loss > > > or EQ re-arming failure, the TX queue becomes stuck, and the > > > timeout handler is only triggered once the queue is declared > > > full. In scenarios where only specialized packets, such as > > > heartbeat packets, are sent through the queue, it takes > > > significantly longer for the queue to fill and be identified as > > > stuck. A proven solution for this issue is polling the EQ > > > immediately after the corresponding IRQ migration, which allows > > > for earlier recovery and prevents the transmission queue from > > > becoming stuck. > > > > I undersand all of this, but for upstreaming we want the root cause, not > > bodges like this. > > > > There is no reason to do what this patch does, the IRQ system is not supposed > > to loose interrupts on migration, if that is happening on your systems it is a > > serious bug that must be root caused. > > Thank you, Jason. > We'll evaluate more on it. If this is in a VM running under qemu - qemu does Lots Of Stuff whenever a MSI-X is changed and that stuff has been buggy before and resulted in lost things. If it is bare metal, I'm shocked. Maybe an IOMMU driver bug in the interrupt remapping? Jason