mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Breno Leitao <leitao@debian.org>
To: tj@kernel.org, jiangshanlai@gmail.com
Cc: linux-kernel@vger.kernel.org, Breno Leitao <leitao@debian.org>,
	 kernel-team@meta.com
Subject: [PATCH 0/3] workqueue: Fix table in wq_dump.py for large number of workqueues
Date: Sat, 07 Mar 2026 09:47:18 -0800	[thread overview]
Message-ID: <20260307-wqdump-v1-0-8663563c234e@debian.org> (raw)

On larger machines (e.g. 316 CPUs, 2 NUMA nodes), the "Unbound
workqueue -> node_nr/max_active" section of wq_dump.py has column
alignment issues.

Values like max_active=2048 exceed the hardcoded minimum field width of 3,
causing the header and data rows to misalign.

This series cleans up the formatting:

 1. Remove the backslash separator from the header

 2. Widen format specifiers for 4-digit values and right-align
    nr/max as a single string

 3. Add "NODE" prefix to all node columns for clarity.
    * Although the original code intentionally only labeled the first column,
      the bare numbers for subsequent nodes create more confusion than they
      help. Labeling all columns makes the output self-explanatory.

Before:
  [          workqueue           \ min max  NODE 0       1     dfl ]
  events_unbound                     8 2048   0/2048   0/  8   0/2048
  netns                              1   1   0/  1   0/  1   0/  1
  async                            1024 1024   0/1024   0/1024   0/1024
  cpuset_migrate_mm                  1   1   0/  1   0/  1   0/  1

After:
  [           workqueue             min  max    NODE 0    NODE 1       dfl ]
  events_unbound                      8 2048    0/2048       0/8    0/2048
  netns                               1    1       0/1       0/1       0/1
  async                            1024 1024    0/1024    0/1024    0/1024
  cpuset_migrate_mm                   1    1       0/1       0/1       0/1

Signed-off-by: Breno Leitao <leitao@debian.org>
---
Breno Leitao (3):
      tools/workqueue/wq_dump.py: remove backslash separator from node_nr/max_active header
      tools/workqueue/wq_dump.py: fix column alignment in node_nr/max_active section
      tools/workqueue/wq_dump.py: add NODE prefix to all node columns

 tools/workqueue/wq_dump.py | 17 ++++++-----------
 1 file changed, 6 insertions(+), 11 deletions(-)
---
base-commit: 5ee8dbf54602dc340d6235b1d6aa17c0f283f48c
change-id: 20260307-wqdump-33fd85802b92

Best regards,
--  
Breno Leitao <leitao@debian.org>


             reply	other threads:[~2026-03-07 17:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-07 17:47 Breno Leitao [this message]
2026-03-07 17:47 ` [PATCH 1/3] tools/workqueue/wq_dump.py: remove backslash separator from node_nr/max_active header Breno Leitao
2026-03-07 17:47 ` [PATCH 2/3] tools/workqueue/wq_dump.py: fix column alignment in node_nr/max_active section Breno Leitao
2026-03-07 17:47 ` [PATCH 3/3] tools/workqueue/wq_dump.py: add NODE prefix to all node columns Breno Leitao
2026-03-07 18:17 ` [PATCH 0/3] workqueue: Fix table in wq_dump.py for large number of workqueues Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260307-wqdump-v1-0-8663563c234e@debian.org \
    --to=leitao@debian.org \
    --cc=jiangshanlai@gmail.com \
    --cc=kernel-team@meta.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®