From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8EEADF76 for ; Sat, 7 Mar 2026 00:51:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772844710; cv=none; b=tKhK7FDCTHx+doD6TKEjDwtuPSLgLtIcDoOUJ4lrNPg+FZ3P8zyNKfvBeuSa9L7LTylOTGKHPE/SEO8010DsVH8NY8mEP7k8pMMUEx+g4NoEKiL6rUefSeNGRY0tCvfpzqXTh2Z7hOlC7lo2Or7SXQBRJpUuNOXmcRNAPUMVn3g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772844710; c=relaxed/simple; bh=mwqNcTB273ulw91qQyocu2ayRs440ihR3CBH40UXk2E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BS0UoN/to8O4f3dcFrB+EIjpu37JMlF8H6+JLqkm26EYCDX4uLPQLJ+qUtI5n1uUDRxLfMvPptGw74fSov+IQufB7iFAllhu6FV5gtgTL0bsWIk+bx8vCzSJWxgfdqPDQkqL8Dd0RPUyS78Lu31mOiDMbz+yAGLh24YJEwoxsdY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AUphX1O+; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AUphX1O+" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-439cd6b09f8so2130986f8f.3 for ; Fri, 06 Mar 2026 16:51:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772844708; x=1773449508; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uTCkikjnueS3c6z47TYvBXYSIRQdE3ZmpIej2YEQUAU=; b=AUphX1O+k9HPx/9cSJv5UpqfkomoIQwRytJoSaMUBcA3hEk2KmuD1+hkmO8a2bj7XK fMOLPnJlX9OM3wt0TYgetNywlaRIgLhoBIaZbQXE+6ZUj33WLVI4D/4Ic81MVXOfu76m c9yLccatXX1Jd8zJM20eY0YjGVFUEjRVSNyzUHwqE3KoZgQ9BFO//TPMMthSzo/qnlDR hKcgqUmv2cQb5zlaI83VZCNqHKerbrTu+1Sib5XDBv+Mo3Mei25YjvkbjQc6mJj/MHaj dKmt4U/0GGvGbJ73PZCWxPFzjPOUncaCKDipcH3txN6OodVH4p5ZbT8Qo7kHSsYm8W2Z LfCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772844708; x=1773449508; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=uTCkikjnueS3c6z47TYvBXYSIRQdE3ZmpIej2YEQUAU=; b=wJuGIzMAirzVHwVxb0fIfTyTWfCGOiA/yhlwLDjQwN8MYK6qKkowbooKZis8le3YuI P5gAXpmiw215KrleS1tdFjj773iA7Ly/dyizf9XE/vsPciQctWreN5ndix4PEerNydF2 9eKh4oPQJmbJVUzj/9pc/6TVH4rZ4YhsOmyMiP6tEJsZMhEH+rKhRi5eQElH6TOHrtvi ExSpKonSWmOuR0EDAXYlzlobBxAOUv6x4421uv5/r6oOR3CvlYXrz7xWx6KWDc2Ivh5d mNe6vR6QlYRzMwskoQrA35AMbqPkMQ1xbvg/DwGHtfW/6qjfsuVtbheo8Y9k2KRBXVeB Nbzg== X-Forwarded-Encrypted: i=1; AJvYcCVjkFTgRv68aU57PPznB0GZR79gH8RBCne2NG1xrR81Hb4wbNMrtqNOTAYyhyGmQt81DNeqOII2+eWbix4=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8z4Mf4dO6XjznaxxRAnKaMICs+gbJVOVRdTjodwJPA2L9JKnX 2/04Mg2nktFJy9d8Xau44MaZkZD3T5Mcejh8Adz54bh7Mok8vN9ILdW3DNDLHQ== X-Gm-Gg: ATEYQzzoGGfPmrMx8SIjRFR3iXTJelRWdLLgsisKNEWW+AbQ/g90mX/pOKWMhRk7oWx qHTiJk2Z63T2mqKKabovDRtplZ8l/IVTLJFp3dQvzTkNc5BvIhEs8UksqwiwfRJd1rlEvc3rpQw 6rDtkZ+Y44LX8m7BS50XZbJnpzpmsVBM5OYN+70ZBJzAqWmicQE9v73lpNPjjm72y6QhK8M8hhd S1ebelFXP0OifYHudtTvYqSrCGMfAGVlV5gbcdl6vs7gsdowRYiEZTiop96MxBpHwD8jCskjHXx sRmzC0cZB68CRbEk24ahwNVwQWMGBK8sEgFvWjwQEeKk2+OcVjxXlUywNqy04G9LYA+JP636bU/ 0YQ2UBajGKOmFFw6AvrjYNrNROUTMiak8jF65ROuEY6m8A+1F/+JwxSQ50UDczFNYB2crJU8eJn JyTFIdkGGUX3nYlORDFuc= X-Received: by 2002:a05:6000:1447:b0:439:beba:300 with SMTP id ffacd0b85a97d-439da31e274mr7516787f8f.1.1772844707988; Fri, 06 Mar 2026 16:51:47 -0800 (PST) Received: from localhost ([212.73.77.104]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-439dae57c05sm6667097f8f.39.2026.03.06.16.51.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Mar 2026 16:51:46 -0800 (PST) From: Askar Safin To: brauner@kernel.org Cc: axboe@kernel.dk, jack@suse.cz, jannh@google.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, tj@kernel.org, torvalds@linux-foundation.org, viro@zeniv.linux.org.uk Subject: Re: [PATCH RFC v2 15/23] fs: add real_fs to track task's actual fs_struct Date: Sat, 7 Mar 2026 03:51:41 +0300 Message-ID: <20260307005141.2582633-1-safinaskar@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260306-work-kthread-nullfs-v2-15-ad1b4bed7d3e@kernel.org> References: <20260306-work-kthread-nullfs-v2-15-ad1b4bed7d3e@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Christian Brauner : > Also fix the argument passed to nullfs_userspace_init() in > switch_fs_struct(): pass the old fs_struct itself rather than the > conditional return value which is NULL when other users still hold > a reference, ensuring the PID 1 unshare detection actually works. This description doesn't match actual patch. Your patch doesn't change what is passed to nullfs_userspace_init in switch_fs_struct. Code before this patch already passed fs. -- Askar Safin