From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5587FE55A for ; Sat, 7 Mar 2026 09:40:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.92.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772876418; cv=none; b=uCUDAvC0wz7OvhRiNljeJ5ZU8uwqHhWGhhAMIJDP26Jqay1N2p8oS/ykYJB29nDsjwLVHEK93aM+m5aCv/jBo6B8xk/p7MEBoOvSsjCxA/KSAm+xMmlEWFkH/PRSlbJQKDabeRABCXHk2OnxnPnKmCRJb3OizqlX0+Mio/kgcHY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772876418; c=relaxed/simple; bh=qp1carzr4Zlbj3Qvls07aYzzEba0ZrNEpV+Fl0g3mKc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Uoohpf3c/YGG1Dr9wvKj6CIfKpIS8OIZzMk93vgkQ5a2SEIpfg6gIIbET/FImSGhqoZr0nCf503yM4ds0pdoGYoOmAOg105OSJqUbXCiU3l55dURUKZrWgFaD6DhvAnBwRelai/eXc6BpvdE7kZCAoDQWKpZHMhQm0M3eFAhJ28= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=VlJ0mYHU; arc=none smtp.client-ip=90.155.92.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="VlJ0mYHU" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+ygCbaAlNusIenTtLF5Yt4Vp4JlnRIwWo1LD+dRCwJo=; b=VlJ0mYHULyctd3ssEbq+3l/cdc RsNJrhJWJAddXDQQgPG7XTI1wYTDCSfwYytUq93bRMh4O1WmuhtxipUf6zhr1NM/B3/0ZKK0XOUAu tj0mU3l9a8HoMK1HNMQqPd1zoh00Rs/w546wNYcrXD+7ffUOjT4D+jn2BCiQ2UCA2pA4KDcavIrpu kMGeIwFIP7r8aGkdUYVbQZDAAxPx6DssI8ZIFt7o9YTYu8FoUBFfe3NEzV53yBXZX7N7nSqFE4jJQ jZ5+kF6b/Zk/WayWXa87YB7qVM855Doj5Szq0lrEniUnb5wH4LneF2KVCMnWJekANzTprzlN3a5PB N5vg0K4A==; Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1vyo8f-0000000A84H-2jTu; Sat, 07 Mar 2026 09:40:01 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 0D2D5301150; Sat, 07 Mar 2026 10:40:01 +0100 (CET) Date: Sat, 7 Mar 2026 10:40:01 +0100 From: Peter Zijlstra To: John Stultz Cc: LKML , K Prateek Nayak , Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Suleiman Souhlal , Johannes Weiner , Joel Fernandes , Qais Yousef , zhidao su , Xuewen Yan , kuyo chang , hupu , kernel-team@android.com Subject: Re: [RFC][PATCH] sched: Make class_schedulers avoid pushing current, and get rid of proxy_tag_curr() Message-ID: <20260307094001.GV606826@noisy.programming.kicks-ass.net> References: <20260307073953.3735702-1-jstultz@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260307073953.3735702-1-jstultz@google.com> On Sat, Mar 07, 2026 at 07:39:29AM +0000, John Stultz wrote: > With proxy-execution, the scheduler selects the donor, but for > blocked donors, we end up running the lock owner. > > This caused some complexity, because the class schedulers make > sure to remove the task they pick from their pushable task > lists, which prevents the donor from being migrated, but there > wasn't then anything to prevent rq->curr from being migrated > if rq->curr != rq->donor. > > This was sort of hacked around by calling proxy_tag_curr() on > the rq->curr task if we were running something other then the > donor. proxy_tag_curr() did a dequeue/enqueue pair on the > rq->curr task, allowing the class schedulers to remove it from > their pushable list. > > The dequeue/enqueue pair was wasteful, and additionally K Prateek > highlighted that we didn't properly undo things when we stopped > proxying, leaving the lock owner off the pushable list. > > After some alternative approaches were considered, Peter > suggested just having the RT/DL classes just avoid migrating > when task_on_cpu(). > > So rework pick_next_pushable_dl_task() and the rt > pick_next_pushable_task() functions so that they skip over the > first pushable task if it is on_cpu. > > Then just drop all of the proxy_tag_curr() logic. > > Fixes: be39617e38e0 ("sched: Fix proxy/current (push,pull)ability") > Reported-by: K Prateek Nayak > Closes: https://lore.kernel.org/lkml/e735cae0-2cc9-4bae-b761-fcb082ed3e94@amd.com/ > Suggested-by: Peter Zijlstra > Signed-off-by: John Stultz Right, that works for me ;-) Sone bits I also had in my 'patch' that didn't make it, and quite frankly don't belong in the same patch anyway, is the below. Compilers are really bad (as in they utterly refuse) optimizing (even when marked with __pure) the static branch things, and will happily emit multiple identical in a row. So pull out the one obvious sched_proxy_exec() branch in __schedule() and remove some of the 'implicit' ones in that path. Hmm? --- --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -6597,11 +6597,7 @@ find_proxy_task(struct rq *rq, struct ta struct mutex *mutex; /* Follow blocked_on chain. */ - for (p = donor; task_is_blocked(p); p = owner) { - mutex = p->blocked_on; - /* Something changed in the chain, so pick again */ - if (!mutex) - return NULL; + for (p = donor; (mutex = p->blocked_on); p = owner) { /* * By taking mutex->wait_lock we hold off concurrent mutex_unlock() * and ensure @owner sticks around. @@ -6829,14 +6825,16 @@ static void __sched notrace __schedule(i pick_again: next = pick_next_task(rq, rq->donor, &rf); - rq_set_donor(rq, next); rq->next_class = next->sched_class; - if (unlikely(task_is_blocked(next))) { - next = find_proxy_task(rq, next, &rf); - if (!next) - goto pick_again; - if (next == rq->idle) - goto keep_resched; + if (sched_proxy_exec()) { + rq_set_donor(rq, next); + if (p->blocked_on) { + next = find_proxy_task(rq, next, &rf); + if (!next) + goto pick_again; + if (next == rq->idle) + goto keep_resched; + } } picked: clear_tsk_need_resched(prev); @@ -6886,10 +6884,6 @@ static void __sched notrace __schedule(i /* Also unlocks the rq: */ rq = context_switch(rq, prev, next, &rf); } else { - /* In case next was already curr but just got blocked_donor */ - if (!task_current_donor(rq, next)) - proxy_tag_curr(rq, next); - rq_unpin_lock(rq, &rf); __balance_callbacks(rq, NULL); raw_spin_rq_unlock_irq(rq);