From: Rajveer Chaudhari <rajveer.chaudhari.linux@gmail.com>
To: lucas.p.stankus@gmail.com, lars@metafoo.de,
Michael.Hennerich@analog.com, jic23@kernel.org,
nuno.sa@analog.com, andy@kernel.org, puranjay@kernel.org,
dlechner@baylibre.com
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Rajveer Chaudhari <rajveer.chaudhari.linux@gmail.com>
Subject: [PATCH v3 1/3] iio: accel: adxl313: convert to guard(mutex)
Date: Sat, 7 Mar 2026 15:47:56 +0530 [thread overview]
Message-ID: <20260307101758.50091-2-rajveer.chaudhari.linux@gmail.com> (raw)
In-Reply-To: <20260307101758.50091-1-rajveer.chaudhari.linux@gmail.com>
Replace manual mutex_lock/mutex_unlock pair with guard(mutex) in
adxl313_read_axis(). This ensures the mutex is released on all
return paths and allows returning directly without a goto label.
v3: Return directly from regmap_bulk_read error path.
v2: Split into separate patch per driver.
Signed-off-by: Rajveer Chaudhari <rajveer.chaudhari.linux@gmail.com>
---
drivers/iio/accel/adxl313_core.c | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/drivers/iio/accel/adxl313_core.c b/drivers/iio/accel/adxl313_core.c
index 9f5d4d2cb325..40f62c6f89b4 100644
--- a/drivers/iio/accel/adxl313_core.c
+++ b/drivers/iio/accel/adxl313_core.c
@@ -8,6 +8,7 @@
*/
#include <linux/bitfield.h>
+#include <linux/cleanup.h>
#include <linux/interrupt.h>
#include <linux/module.h>
#include <linux/overflow.h>
@@ -354,21 +355,15 @@ static int adxl313_set_odr(struct adxl313_data *data,
static int adxl313_read_axis(struct adxl313_data *data,
struct iio_chan_spec const *chan)
{
- int ret;
-
- mutex_lock(&data->lock);
+ guard(mutex)(&data->lock);
- ret = regmap_bulk_read(data->regmap,
+ int ret = regmap_bulk_read(data->regmap,
ADXL313_REG_DATA_AXIS(chan->address),
&data->transf_buf, sizeof(data->transf_buf));
if (ret)
- goto unlock_ret;
-
- ret = le16_to_cpu(data->transf_buf);
+ return ret;
-unlock_ret:
- mutex_unlock(&data->lock);
- return ret;
+ return le16_to_cpu(data->transf_buf);
}
static int adxl313_read_freq_avail(struct iio_dev *indio_dev,
--
2.53.0
next prev parent reply other threads:[~2026-03-07 10:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 20:26 [PATCH] iio: " Rajveer Chaudhari
2026-03-06 20:37 ` David Lechner
2026-03-06 21:11 ` [PATCH v2 0/3] iio: accel: " Rajveer Chaudhari
2026-03-06 21:11 ` [PATCH v2 1/3] iio: accel: adxl313: " Rajveer Chaudhari
2026-03-06 22:10 ` David Lechner
2026-03-06 21:11 ` [PATCH v2 2/3] iio: accel: adxl355: " Rajveer Chaudhari
2026-03-06 22:12 ` David Lechner
2026-03-06 21:11 ` [PATCH v2 3/3] iio: accel: adxl372: " Rajveer Chaudhari
2026-03-07 10:17 ` [PATCH v3 0/3] iio: accel: " Rajveer Chaudhari
2026-03-07 10:17 ` Rajveer Chaudhari [this message]
2026-03-07 10:31 ` [PATCH v3 1/3] iio: accel: adxl313: " Jonathan Cameron
2026-03-07 10:17 ` [PATCH v3 2/3] iio: accel: adxl355: " Rajveer Chaudhari
2026-03-07 10:39 ` Jonathan Cameron
2026-03-07 10:43 ` Jonathan Cameron
2026-03-07 10:17 ` [PATCH v3 3/3] iio: accel: adxl372: " Rajveer Chaudhari
2026-03-07 10:41 ` Jonathan Cameron
2026-03-07 10:26 ` [PATCH v3 0/3] iio: accel: " Jonathan Cameron
2026-03-07 10:33 ` Rajveer Chaudhari
2026-03-07 17:08 ` Jonathan Cameron
2026-03-06 21:12 ` [PATCH] iio: " Andy Shevchenko
2026-03-06 21:23 ` Rajveer Chaudhari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260307101758.50091-2-rajveer.chaudhari.linux@gmail.com \
--to=rajveer.chaudhari.linux@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.p.stankus@gmail.com \
--cc=nuno.sa@analog.com \
--cc=puranjay@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome