From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-180.mta0.migadu.com (out-180.mta0.migadu.com [91.218.175.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C98D0296BDA for ; Sat, 7 Mar 2026 10:24:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772879083; cv=none; b=gck0P6Idn5dl4KT0VkFvDKoBWEg6AJVo4TAxUaCQQPnOiYYJ5oMdR3fhjQMO0GhmLn8ulTlHPfyz+fDGigT/g341IftGjVdZ/Nhm3gBObrhHYK2LoIHCikb9iq4WO3hDEBUtHZbO2M+WiSpIVt4ToxrWwgrmyzfTk0Raq1lJNag= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772879083; c=relaxed/simple; bh=aSt391DxZe1C6jPD3lkNb/qzG9YGtaVJ33WAxoNfXjs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=afqeKV5T5t25/tx9FW+sICHuakzgO58oNKM2QVPQus7Q3VxVSa5a7tjXLECF+t75hDezrW1fVxaMDli5mGwzv2di3Ncqj9NiVH2+2zSVvRf+5ryeyk2hMCt1+iak0QuOvZWXLynvB59yRCG3bgdclppSdlcZ3hC9wFUNcG3Fc4M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=uCpBsKwl; arc=none smtp.client-ip=91.218.175.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="uCpBsKwl" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1772879078; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=pu6e1byH9v32PoeInp9i7sLdqeOsmCpfac+V1Maiv94=; b=uCpBsKwltM1OKZd19nJig/4JB3vgA71mMKjXxrw0hTgK3UFmwE73ZNx+I1LZEOKUSTASjL aMpg7BShsmvIV/W4B/qAapeXE47ehT2Iq4kSQ7NxGfakkbbqSAsTIXeWrEG6vOOHn5L1bu vcyBXqrNxaOMx1XVxGXdc+O0ZTssbfA= From: Thorsten Blum To: "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Orson Zhai , Baolin Wang , Chunyan Zhang , Freeman Liu Cc: Thorsten Blum , stable@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH RESEND 1/2] thermal: sprd: Fix temperature clamping in sprd_thm_temp_to_rawdata Date: Sat, 7 Mar 2026 11:24:20 +0100 Message-ID: <20260307102422.306055-1-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT The temperature was never clamped to SPRD_THM_TEMP_LOW or SPRD_THM_TEMP_HIGH because the return value of clamp() was not used. Fix this by assigning the clamped value to 'temp'. Casting SPRD_THM_TEMP_LOW and SPRD_THM_TEMP_HIGH to int is also redundant and can be removed. Fixes: 554fdbaf19b1 ("thermal: sprd: Add Spreadtrum thermal driver support") Cc: stable@vger.kernel.org Reviewed-by: Baolin Wang Signed-off-by: Thorsten Blum --- drivers/thermal/sprd_thermal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/sprd_thermal.c b/drivers/thermal/sprd_thermal.c index e546067c9621..70c879e75d85 100644 --- a/drivers/thermal/sprd_thermal.c +++ b/drivers/thermal/sprd_thermal.c @@ -192,7 +192,7 @@ static int sprd_thm_temp_to_rawdata(int temp, struct sprd_thermal_sensor *sen) { u32 val; - clamp(temp, (int)SPRD_THM_TEMP_LOW, (int)SPRD_THM_TEMP_HIGH); + temp = clamp(temp, SPRD_THM_TEMP_LOW, SPRD_THM_TEMP_HIGH); /* * According to the thermal datasheet, the formula of converting -- Thorsten Blum GPG: 1D60 735E 8AEF 3BE4 73B6 9D84 7336 78FD 8DFE EAD4