mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Felix Gu <ustc.gu@gmail.com>
Cc: "Francesco Dolcini" <francesco@dolcini.it>,
	"João Paulo Gonçalves" <jpaulo.silvagoncalves@gmail.com>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Andy Shevchenko" <andriy.shevchenko@intel.com>
Subject: Re: [PATCH] iio: adc: ti-ads1119: Drop redundant error message
Date: Sat, 7 Mar 2026 13:25:42 +0000	[thread overview]
Message-ID: <20260307132542.629c7d21@jic23-huawei> (raw)
In-Reply-To: <20260303-ti-ads1119-2-v1-1-19d31e69ec7c@gmail.com>

On Tue, 03 Mar 2026 01:07:29 +0800
Felix Gu <ustc.gu@gmail.com> wrote:

> devm_request_threaded_irq already prints an error message when failure,
> so the error message is redundant, drop it.
> 
> Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Hmm. I applied this already and for some reason didn't reply to say so.

So applied.

J
> ---
>  drivers/iio/adc/ti-ads1119.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/ti-ads1119.c b/drivers/iio/adc/ti-ads1119.c
> index c9cedc59cdcd..1157e606bc64 100644
> --- a/drivers/iio/adc/ti-ads1119.c
> +++ b/drivers/iio/adc/ti-ads1119.c
> @@ -740,8 +740,7 @@ static int ads1119_probe(struct i2c_client *client)
>  						NULL, IRQF_ONESHOT,
>  						"ads1119", indio_dev);
>  		if (ret)
> -			return dev_err_probe(dev, ret,
> -					     "Failed to allocate irq\n");
> +			return ret;
>  
>  		st->trig = devm_iio_trigger_alloc(dev, "%s-dev%d",
>  						  indio_dev->name,
> 
> ---
> base-commit: 3fa5e5702a82d259897bd7e209469bc06368bf31
> change-id: 20260303-ti-ads1119-2-73294fc211a7
> 
> Best regards,


      parent reply	other threads:[~2026-03-07 13:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-02 17:07 Felix Gu
2026-03-02 17:15 ` Andy Shevchenko
2026-03-02 19:50   ` Jonathan Cameron
2026-03-03  8:43 ` Markus Elfring
2026-03-07 13:25 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260307132542.629c7d21@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=francesco@dolcini.it \
    --cc=jpaulo.silvagoncalves@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=ustc.gu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®