From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC377C2FF for ; Sat, 7 Mar 2026 14:00:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772892014; cv=none; b=A8mG8m8I12ATGnDNAitKKdbvDPmOUrmzZyAC39xHmsBx3nm5+DKwUdFhT9QyF4EabHNPQW+HDQlSRyTszel6s9/rh5couZq2A1QjreOyObNItOyiLWsx2N0anhhlEHLVTeviMNYvQNH13cER132P3fiO8iQGQMvoeOPtha+7F34= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772892014; c=relaxed/simple; bh=6z5z13sZJQWAx63WDddjUPDcrnYQA0Y5iP1sD7HHlDk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mghvkkWiAHf3d3dP77rVijoAQZc2mb3x5Q+h48/Yg8H8sZqXxjPzXTZA96zaFeVR2YwzEB43h268iqqaw6lAfiNlRwyX4vej8ROITXJEP40khcvlmcbooVt9Mn28dkYhf32KL5jVkzA+v9pR5eClZNnpgD5/5TRqL8x0dFjLujc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OXNa+nJn; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OXNa+nJn" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-829abaaa92bso584824b3a.1 for ; Sat, 07 Mar 2026 06:00:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772892013; x=1773496813; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mRAH1OwRMd/hgomET3JR4h+I3zPtNpk+wbuNofTgx3o=; b=OXNa+nJn4MvgwbK6doBq1esoXSdB3kJ4X3ZrKZpw1hDG5DG1zc4dUXIP/jxya31wlo LEQFKMTpOT33dRVfIWmH8s54jK0GQ0bjKd0F9xxyuERzymeD6kCYxtzH5l4KT0XNBAW6 /wT5ecaXzuRVx8jB9DL/rVnLvBolaLJeoXBwWaOM9O9qM9B9L2ORsznXG2HgJTCxFuZj iKfKB7tQHMkDlpcbQUfhwb20PIIf+XhkDUE4hdA7raCISsxOHlZrgiIYxRkwng+kHQaP UvHdF7VFOTQq/etkmV15m21kunQ/ecj/tMGzvz/3vstozrtU3zRBmHbPnSM2Nr6NWemr U/zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772892013; x=1773496813; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=mRAH1OwRMd/hgomET3JR4h+I3zPtNpk+wbuNofTgx3o=; b=sd6+/KxFOaZ51BiZPlIcur2TweKiXY06Ck6vZs0TSjNQhfVSNsSzlrX8m4Y7QvoUhJ wlVDBKkhyIZldiwdwdowUjsCVPqGyULsWP76igVrCdkq/zGQG9XRxGcfQ9vNcxayGsP6 /1IjBHxrp7U9C1VzcKB/w5kqkVqHjTY+F3rfCIoeh8ggMh77+a8i1UQayg1/vFuK4kRU ffRmu4fH2OSosmDuMp6rt+mr1eqKL0rbYgT4iIIAmKuR1OrAJ4p9/2Wi8WMZJrzdBy80 x0LwvHSqM/35Uey/lGvRl7s87pzIVf/KgSNQJlyEYvlgr6Gei8A0umclbHosHiPvPWFt iORg== X-Forwarded-Encrypted: i=1; AJvYcCVUmAyptIzlkVUlTD0wT3P+T4nRQOaBhVDc7D+d5Hj/j8Mn2ETFceRwZbE2w/p9eM16wCZPvSy3NtOX3js=@vger.kernel.org X-Gm-Message-State: AOJu0YzOHvkTXj5XL++iue28BQXqjK1ZcgBe5pvS5VMnfF/d5pP3mzDx mVOik+FyCg15jr6H9S1ADIbCMpI06G0o8yBC0lB714q8h4w20MI5br+W X-Gm-Gg: ATEYQzwrNZjGjpwsrSJ79qN8OC62abkpSmMo95EVeT/0zPvx9pKVeDFZuBwv/KIPxBt LPtN5AQi8hGlGBrjB0s6iwylD0VQjPpsxOIrUuPeAGytteTT145rT68gqtGJVbFo16r3ID2smh0 KEPOeIR1nq9aMJLdJSS116LobEpgjj00FiPX498QljTzmWdPD/aiuhMf3P8B705fskDiaF/31C+ +sbVA+f3iqE+vVjvZlNAlznKVfSGjK2r7zPXPHng7mbmxJvieZrvsLuButyAd0V6CheOMb8c71L 76JHIy6TQ4NXxPAU4bLMEiVebvrfMjAYRmVD4eYHeNdMMGzp5ZTXU6Bp7vV5LNvORgnqpYSahx7 6tvPUhLwHNJKB+/oJI7g8dTUR+YXOEN/dN+/PNcr/t3ikD4QrkyXn2VI7SPSHKXUels4OXWwpUE 81KwB+bZlDQ75UbOV3rA7ZPbvwlKJnkOo3 X-Received: by 2002:a05:6a00:7087:b0:81e:f1c3:89df with SMTP id d2e1a72fcca58-829a2f808acmr4078268b3a.50.1772892012838; Sat, 07 Mar 2026 06:00:12 -0800 (PST) Received: from zjh-MS-7E01.. ([2404:7ac0:6427:b7dd:ba81:85a1:e5bb:852a]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-829a4657a10sm4291425b3a.21.2026.03.07.06.00.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Mar 2026 06:00:12 -0800 (PST) From: Jianhui Zhou To: peterx@redhat.com Cc: aarcange@redhat.com, akpm@linux-foundation.org, david@kernel.org, jianhuizzzzz@gmail.com, jonaszhou@zhaoxin.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mike.kravetz@oracle.com, muchun.song@linux.dev, osalvador@suse.de, rppt@kernel.org, stable@vger.kernel.org, syzbot+f525fd79634858f478e7@syzkaller.appspotmail.com Subject: Re: [PATCH] mm/userfaultfd: fix hugetlb fault mutex hash calculation Date: Sat, 7 Mar 2026 21:59:59 +0800 Message-ID: <20260307135959.44974-1-jianhuizzzzz@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Thu, Mar 06, 2026 at 04:53:00PM +0000, Peter Xu wrote: > IIUC we don't need this; the userfaultfd.c reference should only happen > when CONFIG_HUGETLB_PAGE. Please double check. You are right. mfill_atomic_hugetlb() is guarded by #ifdef CONFIG_HUGETLB_PAGE in mm/userfaultfd.c, so the stub under !CONFIG_HUGETLB_PAGE is not needed. I will remove it in v2. Thanks for the review!