From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FD1039A7FF for ; Mon, 9 Mar 2026 14:40:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773067233; cv=none; b=EmQB9mKhvQ54HoQau0O0sPGaUR40Jks1263Nod2tdUSKjw3KXjbKWjzBHOYQ+84365B3OQ8tnTQID0FvpMay04UYvzTrQscEEiqYxg5EWWqbRNESwLkh4/z/Mc9mRprqatJ+tNFiNfgXhhU54tdTd9JA8gJQVzPpcMRr77mPwXM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773067233; c=relaxed/simple; bh=vduBEcn4MVIhN6ydLYN5LPvkRxdxKNxfJ/MIwxWKEpU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=SWvdyYedMi/ZpK1dGxYSBC5J1r7EdiLfU1q1CK8gvNAgdR4AfjNs8R6nzEF8CIAbErrpyyLO6CKnnwxAG3aqN6dm4EYBSoX9tBIYJtBosCrh1TmI4F3IlvZejb6Hs7n9Y4apzzkWPvUuLw2UU1We8wLcWGXCIEseu1rsUJCmLBo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id AFD1BC03ED; Mon, 9 Mar 2026 14:40:29 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: rostedt@goodmis.org) by omf18.hostedemail.com (Postfix) with ESMTPA id 4EC7A2E; Mon, 9 Mar 2026 14:40:27 +0000 (UTC) Date: Mon, 9 Mar 2026 10:40:34 -0400 From: Steven Rostedt To: "Ricardo B. =?UTF-8?B?TWFybGnDqHJl?=" Cc: John Hawley , Andrea Righi , Marcos Paulo de Souza , Matthieu Baerts , Fernando Fernandez Mancera , Pedro Falcato , linux-kernel@vger.kernel.org, Steven Rostedt Subject: Re: [PATCH 3/9] ktest: Treat undefined self-reference as empty Message-ID: <20260309104034.1ff0ba0f@gandalf.local.home> In-Reply-To: <20260307-ktest-fixes-v1-3-565d412f4925@suse.com> References: <20260307-ktest-fixes-v1-0-565d412f4925@suse.com> <20260307-ktest-fixes-v1-3-565d412f4925@suse.com> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Stat-Signature: kjkh7s6n5wmyuwhmrpq8c4fcnzq8oofg X-Rspamd-Server: rspamout04 X-Rspamd-Queue-Id: 4EC7A2E X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX19082cLl7XUCXNEjyT1S8chmIoKhExxNBs= X-HE-Tag: 1773067227-547586 X-HE-Meta: U2FsdGVkX1/d+AGUdUVve2xRsz9ICO1w0+pxapIVl9eLJwQNEh6r+8licZFSBpIQsJTQjfAib/Eyj7qyTUJI1dUWkl72R2/A2qRbvEm5FANnOzZtn72vP2rf+BJN/VmRNt5GpXYvQqxdmwtbgYRib0SJxfPZwWOPLlYLsqKT+KEG0XmRjV7idxQBnQTKz6QB0B4rVJ2RORvpq5FZXTA88lajShjbmLwyVAaZrdtliiVNTdCT7sYoos+YvJM+X9U1zPVu2l6xtS/yfJl3ZfVda4b89UoXTMb7Kdx1uoRMVcfYZJPuIXld3rcXkY0HcKVRFrVWz1j4xd2dP/h5I9JbIUO+sWWd6M+nnfXQYEQK0bm1u7Sq+PxP0KELqoieodI8 On Sat, 07 Mar 2026 19:07:58 -0300 Ricardo B. Marli=C3=A8re wrote: > Config variables are expanded when they are assigned. A first-time append > such as: >=20 > VAR :=3D ${VAR} foo >=20 > leaves the literal ${VAR} in the stored value because VAR has not been > defined yet. Later expansions then carry the self-reference forward inste= ad > of behaving like an empty prefix. >=20 > Drop an unescaped self-reference when the variable has no current value, > and trim the outer whitespace left behind. Keep escaped \${VAR} references > unchanged so literal text still works. >=20 > Signed-off-by: Ricardo B. Marli=C3=A8re > --- > tools/testing/ktest/ktest.pl | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl > index b7a1c8c617e0..b8fcdabffffe 100755 > --- a/tools/testing/ktest/ktest.pl > +++ b/tools/testing/ktest/ktest.pl > @@ -910,6 +910,14 @@ sub set_variable { > if (defined($command_tmp_vars{$lvalue})) { > return; > } > + > + # If a variable is undefined, treat an unescaped self-reference as e= mpty. > + if (!defined($variable{$lvalue})) { > + $rvalue =3D~ s/(? + $rvalue =3D~ s/^\s+//; > + $rvalue =3D~ s/\s+$//; > + } > + > if ($rvalue =3D~ /^\s*$/) { > delete $variable{$lvalue}; > } else { >=20