From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2814036B06D for ; Mon, 9 Mar 2026 22:08:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773094138; cv=none; b=G0yhF7NzLSmIXPVFnfTmyz+jpbN+yKeZFPNjfZYaPmNlAiJntty1GfGx/tYVz8KYlfvTLrnoa6urstoE2Yr3ytO6Lweghk0eKFrlFFz5y5SwKSewS9b941/+t6XvEljm9FsYH7AXNpuKLCQJupv3xmnSfbhu37ppdBTD0M1AOo0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773094138; c=relaxed/simple; bh=9hUJKJaz1W+6sdBvmp8POZydEtk/cXXugXiieg1UTps=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=bzlQZFMvkCkVsmxfj4XHvR9pMdAprO/i1GwSgExll6sp+WuYNeZFsmMzW2XYW7YwkBuEN005kGH73pabxFP/VHeEpIUeGa8U6J1qmu6P5s6AiDPyzUQozBPWGM63kOdaSIlYcD2QNgACP4iCK+uTfh5PB6rPPEmbzloxFhcQyYg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id BFC3E1A0366; Mon, 9 Mar 2026 22:08:55 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: rostedt@goodmis.org) by omf04.hostedemail.com (Postfix) with ESMTPA id 8105F20027; Mon, 9 Mar 2026 22:08:53 +0000 (UTC) Date: Mon, 9 Mar 2026 18:09:01 -0400 From: Steven Rostedt To: Joseph Salisbury Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , Valentin Schneider , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] sched/isolation: avoid reading past string in isolcpus parser Message-ID: <20260309180901.4e4b8cd3@gandalf.local.home> In-Reply-To: <20260309220216.198478-1-joseph.salisbury@oracle.com> References: <20260309220216.198478-1-joseph.salisbury@oracle.com> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: zzr6a3hkumnbh7fgiz6666nh73mhmi8r X-Rspamd-Server: rspamout04 X-Rspamd-Queue-Id: 8105F20027 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX1+7SMwCrlKOFjPWXJtgOxg2pjmU5fwzbsk= X-HE-Tag: 1773094133-525023 X-HE-Meta: U2FsdGVkX18t31HprL64kvkkM27Snv5XHMafQy+7cDXe+ZAuV6+t5VM5CDVRAoHxaKpK9dof3ExVKBc36sVZgCQNZxEpCJq/4VSfGChI3nwlxDezcCDtf+0oD5NAk7QoNO+/9kvMzrnBEoip2f9KymyUdQTYXfEi0Nf1i7spx5QK6CY6JLyz1VrNoEjDxPOEPL+Yb70g0TbS2sq5dauXxRxIG87ZErJXeIS9rHuni41Sn+kmI9g7O1CEq+5Mp2ziekxwtleIsn/jMDhp5K4+MoDT6oaVs67AdPDa1Zc4fAqe0f3MQcKvc8gILY+awtnRMowwXElIXBJr7im6WiSjGF2+YYfyu+zKvpt0ugaXNxtSk4csrbLexJPWIdZDkWi19GD9w25IXXf0h/J9We/6IJ8ihLT+pWdOyi4+V4GnrOQ= On Mon, 9 Mar 2026 18:02:16 -0400 Joseph Salisbury wrote: > The function housekeeping_isolcpus_setup() advanced the parser pointer > unconditionally after unknown flags. > > For an argument like 'isolcpus=unknownflag', with no trailing > comma, this can move the pointer past the terminating NUL, and > the next loop test reads out of bounds. > > Reproducer: > isolcpus=unknownflag > > Advance only when the parser is not already at the terminating NUL, > preserving existing parsing semantics while avoiding the invalid read. > > Fixes: 3662daf02350 ("sched/isolation: Allow "isolcpus=" to skip unknown sub-parameters") > Cc: stable@vger.kernel.org > Cc: Steven Rostedt > Assisted-by: Codex:GPT-5 > Signed-off-by: Joseph Salisbury Reviewed-by: Steven Rostedt (Google) -- Steve