From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E5AF36BCF5 for ; Mon, 9 Mar 2026 21:49:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773092956; cv=none; b=kMmTi7WZIcXN1RnbbeZn1dLlFRVCxkJ/2pzEFlud6uMZbHYnrQwAdrrdgkSgKROYsnfiiWTS8wiHLR8jD0X/d3C1KzA2nXmA2IFMSN64XMSyWlWrudaFTKevBJ2h7e/C3ILteRCs+vz+qvvPg/mksEm5X/+B9IKf94jO6rFzc/o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773092956; c=relaxed/simple; bh=6ZepANxP71vzTeeFkk+myydgIBPE2f4n8g/mTa8Namw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=EaIPB8dXaExiV5myRKdnOVD4pj2AIRGOgwQk+3Xaz7Z0Jzv5qUaenyCpx4u70zZ0ndqsysBa+Un/pV5sGkF2JM0P5ErmRRUJspX8yEZmWkQUEdVkue1A3pARr6I96EvQVaqVh7Edcmy6RZA2HNINP6LOW+Y9MnSvzbHrva7J7TU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CCT3QN4R; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CCT3QN4R" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-48539cbb7b1so11519845e9.3 for ; Mon, 09 Mar 2026 14:49:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773092954; x=1773697754; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UCOiS+RSyl4rQ1CP4ex+7wZZ9gyZAKKhYX8v9rsTRMo=; b=CCT3QN4RX9Iejr0WM2iO/GPLs/unHLfd2ulBIPwvzRTvGg/nbewywn+s+1q1aT4HhX O2U9m44wWvSwAXcJEgmQkHCy/ak+p/thJOx3no++mn4FISmP9IcaxH5RwL9NONS8YHe6 WcWhbhIA9yB3N36K3GDMuTFBk9887bCbWbh5t43PtJjnzc2crXF/fDRIf8DIAEdSQ4fd VZR/cxeR+B1yxMW5p3cGkRqJT0bHxJhZeLc+muIuMtdRAw27kvdTpah4yaS3aRM8cx63 oR+BFjVZmzC/e2GzfRQQ07VOHsOuw9QlQ+Iy+acVqsmKecX/zyv5I8kDJPT4aM8dy7Q8 80GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773092954; x=1773697754; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=UCOiS+RSyl4rQ1CP4ex+7wZZ9gyZAKKhYX8v9rsTRMo=; b=Rdv93rk+gfzUs6dzpR3iRsJwFH1irHvv8LAgocnXwSeZBMmIUkXAb1ZmrPrd3U2IfP 9ufOiNQvYpcS/VfNsDKshDXwMqEwM8pWweyGArzocBk87farjuHsgkL8qo3kxdRr//gI 5i+JsXnQpM6AZi1ibf92PBKpbITtq+l47ses2p4s1YznWZ7XEgYk8x+8lzE1RKALw9eT ZYJXA4PK3P89rDpsv8PVhvKkNrUrcQl8d41Uk/SgQC//if/0L4BD9Am0UPtfK5aiJXWp dXyqk2YnIwWMe8aD/iEG2ZoHf8UNyNrSGzgOl7rAntmbkHU4piTAZ1HptCyk0iPoQ3gS wFfA== X-Forwarded-Encrypted: i=1; AJvYcCVLsxbStE57bP/rqn5Ux9TAHcP9iDFE9/fwpX/WLVZHdh8SBWWtt+mErbTEkwl6n/rTg6ee25mp/tjsFpU=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0UoyeinBxymSHmqZOuNDu3Zb2DV53lnnyqd1twsIz0fwxyK8h 4kvcbUPhVlrISIj7D7d5D0L3YJLnpUT/dmTmIdMCKpjEEsheTzxxqlQ= X-Gm-Gg: ATEYQzyViA3cEuXFoxldhmuhUtB3cuBMIPLj1alG60k4W9ouK4GCKALmrolMCzFM8Ve t2PeN01sRFVJen2MSoxsvvRa0PGoHmCpHuBw90L4x+J574INmp82sfvK1AMgv+CtF/rdo3FEdUe 8U7S6+w8m+6kdnKr33XZAwqTaBnyfVlL0QRDfYv+a6JUsYKxbU0aFNJu5zGK5qWNuseH/6xalLq 4RSfZ83iUJk6iEzfFHZB7ZcYkbQTMuVX6cVbz3Msb6gkQS1NbpxvqTyx6kfKNaxw6fyA9Ine2Nl WpZKPaBzNS7NbJ0/fHGf/blBRG4P9at1Cl6VYpiLy7FtdpqSmD9vkbnrh1o+eOWBrSrllTjdKGw rJM1mgN4Ee7J0pl+b/BGjExtD28lXU6bVBUao0anjpTvmP1TDNKul71DnUHBDi4MXM8Bxz3wr5i 6OCsLw94JqJ4tcTsFNdSyaryRmBBtiCqIsEPSAotDIPvO7Aunm9Ytouw== X-Received: by 2002:a05:600c:3b92:b0:485:3b00:f939 with SMTP id 5b1f17b1804b1-4853b00fa43mr93367735e9.8.1773092953435; Mon, 09 Mar 2026 14:49:13 -0700 (PDT) Received: from localhost.localdomain ([2a01:e11:2401:e440:4d43:1ae9:c232:cc4d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-485246fd127sm149015395e9.6.2026.03.09.14.49.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 14:49:12 -0700 (PDT) From: "matteo.cotifava" To: broonie@kernel.org Cc: cotifavamatteo@gmail.com, cujomalainey@chromium.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, perex@perex.cz, srini@kernel.org, tiwai@suse.com Subject: Re: [PATCH] ASoC: soc-core: fix use-after-free in snd_soc_unbind_card() Date: Mon, 9 Mar 2026 22:49:06 +0100 Message-Id: <20260309214906.543639-1-cotifavamatteo@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <17591222-b9f7-4056-9c13-4a2ccd0788df@sirena.org.uk> References: <17591222-b9f7-4056-9c13-4a2ccd0788df@sirena.org.uk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Mon, Mar 09, 2026 at 03:01:40PM +0000, Mark Brown wrote: > That's exactly what flush_delayed_work() is supposed to do? Are you > sure whatever you're seeing isn't that something is managing to schedule > new work after the cancellations? You're right, I was wrong about flush_delayed_work() in v1. Looking at it more carefully, I believe the issue is exactly what you suggested: new work gets scheduled after the flush. Specifically, snd_card_disconnect_sync() inside soc_cleanup_card_resources() can trigger PCM closes which call snd_soc_dapm_stream_stop(), scheduling new delayed work after the flush in snd_soc_unbind_card() has already completed. > These are two separate changes which should be in two separate commits. Agreed, split in v2. > This now guarantees that we don't execute any queued work, presumably > something was expecting it to do something... Dropped the cancel approach entirely. v2 keeps flush and adds a second one in soc_cleanup_card_resources() after snd_card_disconnect_sync() (so no new work can be scheduled) and before DAIs/widgets are freed. v2 incoming. Thanks, Matteo