From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5881338E13A for ; Mon, 9 Mar 2026 10:14:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773051247; cv=none; b=qlNFEhNIhqmZTWrgGGU8s5/wVpu23OxqwB1GyPwu+H0Od5SOP0DR+RIVg9NAShKSnLRHGV2zjFiz8K6R/gDZk0oNYf7JMhLgFswh8iqsO2HiqmspQPqbxtMHzkab7yKXkqr4P6Qwhrp98kMgFx8f9dIm3amRsU/124OxK/uTBn8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773051247; c=relaxed/simple; bh=bGcLCHMf0kG6KAQcgQti9IyFFTGBwB7azJrRnMTCKvk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aFm5StJY/ChGUJipvFqPmE6QAjMuV83BnBs7a0MNroJFEq2RgFYEo8sNm4j9Eq5MkjvOpxsYFuiqOTTsQANGhm/fz5HyHoLN5ceoknXswE65ez74QASX2mwzvyJIT4VdZBYFs++RwQajPtEQNVunK9TI8hTihhn0gWMemUsvsf4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=i9lnxTrp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="i9lnxTrp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2FA43C4CEF7; Mon, 9 Mar 2026 10:14:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1773051246; bh=bGcLCHMf0kG6KAQcgQti9IyFFTGBwB7azJrRnMTCKvk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=i9lnxTrpUTwB5jhlwwD4lOPmM9JnvcwkqQ3NUA3ntcvizK1dwmii6J7FnL7OpomNe r5OukbjD9/s6lTdIDq/lme3SKYdbNuukjYpxIG2IFhD8yDzurfxOBkXpadJ/EI7vMH BO9p0uNa6TOAhZLS2aAkVuxuWJpKxBvmDMkGXP2o= Date: Mon, 9 Mar 2026 11:14:04 +0100 From: Greg KH To: "Aneesh Kumar K.V (Arm)" Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Lorenzo Pieralisi , Jeremy Linton , Mark Rutland , Sudeep Holla , Jonathan Cameron Subject: Re: [PATCH v3 1/2] firmware: smccc: coco: Manage arm-smccc platform device and CCA auxiliary drivers Message-ID: <2026030923-relieving-dollhouse-28f8@gregkh> References: <20260309100507.2303361-1-aneesh.kumar@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260309100507.2303361-1-aneesh.kumar@kernel.org> On Mon, Mar 09, 2026 at 03:35:06PM +0530, Aneesh Kumar K.V (Arm) wrote: > Make the SMCCC driver responsible for registering the arm-smccc platform > device and after confirming the relevant SMCCC function IDs, create > the arm_cca_guest auxiliary device. > > Also update the arm-cca-guest driver to use the auxiliary device > interface instead of the platform device (arm-cca-dev). The removal of > the platform device registration will follow in a subsequent patch, > allowing this change to be applied without immediately breaking existing > userspace dependencies [1]. > > [1] https://lore.kernel.org/all/4a7d84b2-2ec4-4773-a2d5-7b63d5c683cf@arm.com > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Lorenzo Pieralisi > Cc: Jeremy Linton > Cc: Greg KH > Cc: Mark Rutland > Cc: Lorenzo Pieralisi > Cc: Sudeep Holla > Cc: Jonathan Cameron > Signed-off-by: Aneesh Kumar K.V (Arm) > --- > arch/arm64/include/asm/rsi.h | 2 +- > arch/arm64/kernel/rsi.c | 2 +- > drivers/firmware/smccc/Kconfig | 1 + > drivers/firmware/smccc/Makefile | 1 + > drivers/firmware/smccc/rmm.c | 25 ++++++++ > drivers/firmware/smccc/rmm.h | 17 ++++++ > drivers/firmware/smccc/smccc.c | 14 +++++ > drivers/virt/coco/arm-cca-guest/Kconfig | 1 + > drivers/virt/coco/arm-cca-guest/Makefile | 2 + > .../{arm-cca-guest.c => arm-cca.c} | 59 +++++++++---------- > 10 files changed, 92 insertions(+), 32 deletions(-) > create mode 100644 drivers/firmware/smccc/rmm.c > create mode 100644 drivers/firmware/smccc/rmm.h > rename drivers/virt/coco/arm-cca-guest/{arm-cca-guest.c => arm-cca.c} (84%) > > diff --git a/arch/arm64/include/asm/rsi.h b/arch/arm64/include/asm/rsi.h > index 88b50d660e85..2d2d363aaaee 100644 > --- a/arch/arm64/include/asm/rsi.h > +++ b/arch/arm64/include/asm/rsi.h > @@ -10,7 +10,7 @@ > #include > #include > > -#define RSI_PDEV_NAME "arm-cca-dev" > +#define RSI_DEV_NAME "arm-rsi-dev" > > DECLARE_STATIC_KEY_FALSE(rsi_present); > > diff --git a/arch/arm64/kernel/rsi.c b/arch/arm64/kernel/rsi.c > index c64a06f58c0b..5d711942e543 100644 > --- a/arch/arm64/kernel/rsi.c > +++ b/arch/arm64/kernel/rsi.c > @@ -160,7 +160,7 @@ void __init arm64_rsi_init(void) > } > > static struct platform_device rsi_dev = { > - .name = RSI_PDEV_NAME, > + .name = "arm-cca-dev", > .id = PLATFORM_DEVID_NONE > }; > > diff --git a/drivers/firmware/smccc/Kconfig b/drivers/firmware/smccc/Kconfig > index 15e7466179a6..2b6984757241 100644 > --- a/drivers/firmware/smccc/Kconfig > +++ b/drivers/firmware/smccc/Kconfig > @@ -8,6 +8,7 @@ config HAVE_ARM_SMCCC > config HAVE_ARM_SMCCC_DISCOVERY > bool > depends on ARM_PSCI_FW > + select AUXILIARY_BUS > default y > help > SMCCC v1.0 lacked discoverability and hence PSCI v1.0 was updated > diff --git a/drivers/firmware/smccc/Makefile b/drivers/firmware/smccc/Makefile > index 40d19144a860..146dc3c03c20 100644 > --- a/drivers/firmware/smccc/Makefile > +++ b/drivers/firmware/smccc/Makefile > @@ -2,3 +2,4 @@ > # > obj-$(CONFIG_HAVE_ARM_SMCCC_DISCOVERY) += smccc.o kvm_guest.o > obj-$(CONFIG_ARM_SMCCC_SOC_ID) += soc_id.o > +obj-$(CONFIG_ARM64) += rmm.o > diff --git a/drivers/firmware/smccc/rmm.c b/drivers/firmware/smccc/rmm.c > new file mode 100644 > index 000000000000..03496330630f > --- /dev/null > +++ b/drivers/firmware/smccc/rmm.c > @@ -0,0 +1,25 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (C) 2026 Arm Limited > + */ > + > +#define pr_fmt(fmt) "smccc: " fmt No need for this define as you never use it in this file. thanks, greg k-h