From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com [209.85.219.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5D751F4CB3 for ; Tue, 10 Mar 2026 00:35:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773102927; cv=none; b=L1dGgjvUTKn7JsCs1/aMGGLYBPwrAN3FDIvSxdZA6Ojft5M5ULadbME3buYw2fBug+DBWH17tRWE+WFtcL8aq1uSfhD4makGxLZ7TSfT4D4zWG3qhWGecb54m4AWIzJE/CCPC4kLAflmXT1Xe6O/tqNajmd6qO+NnPYHc6DT6lI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773102927; c=relaxed/simple; bh=009AGo0MZHlPasEPyaYAPNU6AvgkTeVS0lu0Z4SrMtg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cRa96/Cf2JzKE/I4x0oIMOLLndXYXbxl3Nc6LZ9BSjJpbob9VuNxWryR3pa9o/Rc6ASp0MUK2NcMyyP6fWeB6Hw5EJT3C+a1DUMqIlOAoWH0QXN7HXxmP7YunU6DZmy9rjDld3WnybnVNeYzU9mnSfEOFIAaNVVrP84ch/VbSGk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=AoM/U9g/; arc=none smtp.client-ip=209.85.219.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="AoM/U9g/" Received: by mail-qv1-f48.google.com with SMTP id 6a1803df08f44-899fc9853b7so119646296d6.2 for ; Mon, 09 Mar 2026 17:35:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1773102924; x=1773707724; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=FzWH6RbRKTBzRTMn26sPYCEGxdubi4Ld04JsptWsl0o=; b=AoM/U9g/IlVXpkCbVgZvbPhYt4i5WDvqaTbNTFU894qR70LxyZkYYdK9s3teIwq3LL C0+xB4Mequ52o6qb+EX1G8i63WNe4sS+K/C9reuF0+A5xr6gkfuFziTW+0bfmGQH5yQ5 Gd+eKr5KZFfbZTZvMyL/9LMUz1dp4nlActB3W6t3gPHfbRYkGro7HP67/w84AbiIcBMe oOmOGEHQtCp2wTpbpQcrU4NYrRxeP1S6oN8WDR3Cb5plLxdCRi9LKZPNr4xGoW1yQlrT CF5T83K5Rgh9Mm6NXguW5yHxjB0jD141jfkFQOXgJLW9bObKN9veK9q2cvssl0VXcqX6 +iNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773102924; x=1773707724; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FzWH6RbRKTBzRTMn26sPYCEGxdubi4Ld04JsptWsl0o=; b=LQouP4nuVOFWNvk/lFzvOImt6s0j91gjKhMGQFEh9MsX2iL/zquh2p0OXraOB0TGLb 2tDMaHEyWGB3U7+R1GwSPSd8Hqu7+wQqFVtup/NENal88zoAhET+5Har0mXRHNLksshN gBGC0m1V55mVMc4dKu741NnmiWSFQI5q7bj7f4vpdA2TqOEeqgacrqVNZIpZ0J6ZONzW EJCBiNrlsP90yDNxBgdfFa1vhn/uojrje22IxZvxNlql2hzQGeNuDktzoZdFMDFIcenN jMuugFJrNMWrPPvCOhSzumnKHLKsTZXm6YIDjOlc85nfLIJ57GWPwvxOUnJURap+nqgf y1lw== X-Forwarded-Encrypted: i=1; AJvYcCUFbovAxcrJwjDje6y3P7bwNML2IaSpGlrjmb2RLTTDV4xiIS2g+UM8ntQlGC9NBUSxfueOrWlPdKBQKxQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4UVKMY0Ip5MRH4aNIF6RYHnNRRLgUDgjuje7rnq6LF6ppiD/H B/FcFBTEBJGSIO/8h+alEgIQUJCvKDFl2qCm/d9Tp3TqqEKecEd02FnMhqjI05mRy9PlcM1W2v2 q3qDM X-Gm-Gg: ATEYQzyhXkhHRCHSl/ZAcKJfBRA34aRru6v7vAKZNDPTarxNe9Y5/1RbE/Zi7w34/aT g2tsrZNc3dVC2SmPxWRE9ZswC0SLi/Vn0YsDjJRoW4dSk+2WxbrpcPcLVVhP7y40GyqY1+w2vJK QOzF4YxfbfGsNMaVMeki4jHQT/nrV+lU701Kx/TZqaK8dT34PRehH46AfxfO58Lbi3tdREOt+D3 tVhaCXgT0/mlHOYVMY2W7SGvsAin1B/eO3ODDoMAEQDtSfgdmV2YJ3JhJFzt2tQDUBVmivT7umv pGL7XQi9RFVW/GjAk3q21D+uD9yAadk0C9em/iwVJz/3Vu0VNqKNndr4r/z+/Pu1ble+6+SdSEQ Iba3+it7N7wWq9b5HkXYayPlg7UHwVWlBVjUY7zk+6u3Kp/ugIavPCQSL0D0608qTV/P136p9Ce B1n1GSK4C90nbO9X9OLnqdAGSXQtv5AQKQ1EjUb77i7wVlLHwuXPLpVdqu+x3jiOqPK6aOzX78L YSwSRgF X-Received: by 2002:a05:6214:2524:b0:89a:107a:5b8 with SMTP id 6a1803df08f44-89a30ad1c8emr181406496d6.36.1773102924555; Mon, 09 Mar 2026 17:35:24 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-162-112-119.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.112.119]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-89a57c298e4sm8412466d6.40.2026.03.09.17.35.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 17:35:23 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1vzl4F-00000001ttk-0iou; Mon, 09 Mar 2026 21:35:23 -0300 Date: Mon, 9 Mar 2026 21:35:23 -0300 From: Jason Gunthorpe To: Joe Damato Cc: iommu@lists.linux.dev, Joerg Roedel , Suravee Suthikulpanit , Will Deacon , Robin Murphy , Vasant Hegde , Kevin Tian , linux-kernel@vger.kernel.org, Joerg Roedel Subject: Re: [PATCH] iommu/amd: Block identity domain when SNP enabled Message-ID: <20260310003523.GQ1687929@ziepe.ca> References: <20260309235234.3367768-1-joe@dama.to> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260309235234.3367768-1-joe@dama.to> On Mon, Mar 09, 2026 at 04:52:33PM -0700, Joe Damato wrote: > With this commit applied: > > # echo "identity" > /sys/kernel/iommu_groups/62/type > -bash: echo: write error: Invalid argument > > Fixes: 4402f2627d30 ("iommu/amd: Implement global identity domain") > Signed-off-by: Joe Damato > --- > drivers/iommu/amd/iommu.c | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) Reviewed-by: Jason Gunthorpe Jason