From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2856043C049 for ; Tue, 10 Mar 2026 09:11:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773133881; cv=none; b=IUDAmXumFUgioTCjgBCscGRY7djMeL+0vqqE8b7cHX9x5McebocBY88/kKsL1njf5o96cdbu0Wn+2u+JNY8bLNKW1YvJLbm0iWta7Xb7MDzyu3Mjj/DZcWdqFqpVf71R0amCGmcJhde4ACzggDEPjtVDQYUaC7k3Et1hRNXJOjg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773133881; c=relaxed/simple; bh=6f6CTMROKclxCiuBLqyUInbS/438WmkNzB35QP0bqws=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MNlniyLkxaCTaWI7/waKKUXmkpZVa90VVKweokFJkeZk7zMI+QL3aBsmX56E2mP/RDALk+OX7ex+H2sdZB2Y1pX9+IY0rjDEj2NQSBNxy+43Gi6Crcxg6RQ7SWcX4BdR1DWElMmRvUMgEjbm+c4cfk1gcKW45w60jWB5yC/FYYI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iQYzDU2H; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iQYzDU2H" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-439bc1a201fso870591f8f.2 for ; Tue, 10 Mar 2026 02:11:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773133878; x=1773738678; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=eRVYnrhnkOAdeAd2Kjlt1+H2Rmi0u5RX+qxn7s2d300=; b=iQYzDU2H6P+NXTwOjx/QnpSDx/ci4QfglcAKffpHt+bl0/4MEDbDvW3HDa+Y6OB5GF NoCynyU5dDl6GE7vL7V+wGJhr0/l/4BlEb+Tz0H2eRnrSGgo10By3rGFJYA2U25Xvgpc ORl+ycxYSIqmdm/ozgZHupRVaQEVoLP5tz2ERzt536RbPZILUItHYW2l7zjZ7G9uLxGS h5nnDQYmNgqGEDN4CYCL56SOw8X4Qz3stCZH+pwCXjBQvlOX6OMrAVPJUTdKT5pwFh2H j1SgaDAbQzYI63HEZxvsEyZJe8KiztP23TKkk7ggQd2ten5IM2niGk1pJI1ZMMlSlvIr pfKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773133878; x=1773738678; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eRVYnrhnkOAdeAd2Kjlt1+H2Rmi0u5RX+qxn7s2d300=; b=TMPAagNJGyYmviH6HcKPqmIAhFoXo+YVmse5p8lsSPwicUYTvVT8aa5jBXaG/far6a +AKLIfCPJKbtaUdeDS3+g0FzI+EbrAWGbvyInDMrnd0R4r7kucOOiSsQzA8p5LO9jB5d 9+ufJ2X0oyLQrGI92ly4D/0nfBZ79Wpx1gwEhpJYbSEipUfrWu2/bxqeSLDs0vWFY6ZR 53iEFFbRU9vrgWrCajtm1TDbfd1HCy2LaOzJUJSZaj8yFkwF1ET/4COm35R1fm3U8I0z vMYB8JVHiPBEThgz8X9HBJG3bV6W2kosesKv753kq6ksJUYF1mpZ5NILFmzT2eKGu+GL 16uA== X-Forwarded-Encrypted: i=1; AJvYcCXn2JqUeI1HF/YGDMxpLIuSttQ0dAco3gyaD5SsDIcxSza5jtAakipWe2tSHleDIJnt2n7/AROOLw/FSTU=@vger.kernel.org X-Gm-Message-State: AOJu0Yy9eZHb0DcuNOyttMpIXaCZxU6S1bdNZPpcQFcBXJfIlPxzD4wB DT2hJ1e3hJ9Se94yqaDmloY8uh2k+N3y5FKcAUVlb3iSCm76E8WQuQoE X-Gm-Gg: ATEYQzxtpVOlFs+HMC7KGo2O2RJUbn1Zz33lBQKHGFaoVf4IT3NuijU8CKCJT60o3Ec oKCaC3q4vYBGuBd3AikgtKUDywqWvml2n0yyN1DbODt6gjMw5V+zTNRSLME+b2aU3CNEg6ebuT8 eq17csLVCsF/0G8EukqtwGfu5WyiNYDj8k9FgUXe4/WCHBWBXMUNI56vCyiBF6xSOHqoIi4zk/H Rfl5wnDYiaKZ2jM6ZjIHwjE+fpLo9kmwwO/KgbxJt6eUqykLvjl4CwzYEtb+EUTMhnIf4TD/bYP 5N2RD5gRUUDpiABk2Kj4MTSsNIwOpC2CUd/ODubTPV+Fy2/BBL0gNnyByG0u0Uo3tXwzRdqsYsW jFGXVfskvNdUH0Y7M5+e0P1LfVaVT0dWB9hp43kUnKvUnvroNQ3izYzYvv/Pnma8R2ijEHOdTRI +2bOv27O16kh1e2g== X-Received: by 2002:a05:600c:4e8b:b0:485:358b:e7ed with SMTP id 5b1f17b1804b1-485358be94cmr73984075e9.0.1773133878274; Tue, 10 Mar 2026 02:11:18 -0700 (PDT) Received: from skbuf ([2a02:2f04:d00a:e00:8799:3a7d:3c86:3200]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48535c7fae3sm90439885e9.1.2026.03.10.02.11.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 02:11:17 -0700 (PDT) Date: Tue, 10 Mar 2026 11:11:15 +0200 From: Vladimir Oltean To: Daniel Golle Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: dsa: mxl862xx: don't set user_mii_bus Message-ID: <20260310091115.j2aqdk3ikodffoei@skbuf> References: <0f0df310fd8cab57e0e5e3d0831dd057fd05bcd5.1773103271.git.daniel@makrotopia.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0f0df310fd8cab57e0e5e3d0831dd057fd05bcd5.1773103271.git.daniel@makrotopia.org> On Tue, Mar 10, 2026 at 12:41:56AM +0000, Daniel Golle wrote: > The PHY addresses in the MII bus are not equal to the port addresses, > so the bus cannot be assigned as user_mii_bus. Falling back on the > user_mii_bus in case a PHY isn't declared in device tree will result in > using the wrong (in this case: off-by-+1) PHY. > Remove the wrong assignment. > > Fixes: 23794bec1cb60 ("net: dsa: add basic initial driver for MxL862xx switches") > Suggested-by: Vladimir Oltean > Signed-off-by: Daniel Golle > --- Reviewed-by: Vladimir Oltean