From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f227.google.com (mail-pl1-f227.google.com [209.85.214.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1919D38AC7E for ; Tue, 10 Mar 2026 14:01:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.227 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773151295; cv=none; b=YLoBPDiHtcNvjHyTwwL5ZBID5SSBcD3a2g8gcP1kkD+WugHF6NYmqsdsb81VnD3tgj+8YFf+So4jOX/QV2QkyS4PQ674sd2fWfBusO21gtfwt6O2xdb8SrDwjv9kAVgV87uo1alDg1kFf/Dn5nYuBsFBJd1vUPMVIWWnymEbx1o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773151295; c=relaxed/simple; bh=B67hDG/SL9opV3GW2yl793QuTIM18s7EGzju2YVYLpM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=nNUXkZPua99U8JbLsdGke9BLMTsa0oJzIICn92XHEONCFUQr3HveP4UXjzBnEtwK5LU+95ImFKAcLFJdliNUbmUCACsZ8apta6sotVr+k0mzeISKn8u15Tlz7g4t7KkbVXVJgcg3oLP76k2fC7nYCEyaHCLv/ti2kTv2Y7PqECQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=eiMBxWsS; arc=none smtp.client-ip=209.85.214.227 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="eiMBxWsS" Received: by mail-pl1-f227.google.com with SMTP id d9443c01a7336-2ae4e538abdso91369375ad.3 for ; Tue, 10 Mar 2026 07:01:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773151293; x=1773756093; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uxNg0ZuvybwMNPFc1XdUvc1gk+8z+XaUlMvkkngGJis=; b=OjA5/yjnYGdUSKuwbivPvsz+iGUJRFao6pp5yB9frWPBvq3oYZw+dfN+2OEQ2ojTNy tTjDFPtJ/P+5m6PqyA+Ekee5z0f3LnKwgjHug0Wx4hudg1Oza9jrorKX1LvdpWleZ1F9 Nh5ff2yUhRN8RFYvTTa8bsZzoquMDc7w+06VYo6/cRwoUCc6rsOVxxwbfLtUN4EkVs9D MX9REi8FG4kdW2UAwzHVOGKJEDS40skbkzforqlyYyW60QZsV9y67vdZtxE5Z/h9va6s Mlo2+hoRDS6FKHPYktp/tHfSPTuefkZro23CthLXHO0cWTrawauoMoW6+RMpe33UzqaW 06ig== X-Forwarded-Encrypted: i=1; AJvYcCWupFOUPfXiKqi2svmC8d/JdR5cNgqz5OgMU4z+4U81hMzUitjTIQzBUq1bXWajAWW9Vd5KGSmq/2oc5Nw=@vger.kernel.org X-Gm-Message-State: AOJu0YxlgCyqCC70Uib50WsF6D/iOn885UxD8rMfnUoWrAfz2af82tqT ApRNZ0kt7LNZ1TH4R6zdo3pkLktXw1U3PpaU4zrBGFSpC3M/UwcxNLXSzXgssy8/DWt5SR5ZbJu 3BrbBMX7Ye084FLxMU0GX5OuyOpoHbudbp0o/2QD+8NajkxjZLsQBz8b2CFLQ0sIFqP/T7FYd6p oznx/pWZC97jRnxYnekbNwtVYoX2r0S8okBUmEpDypvEi22ha+7kbknWKBcHXNvcTBji7H4vNwc AEj5ReXpMhXYRKDjNGip8mFlQ== X-Gm-Gg: ATEYQzyQnlRZiDShM/wwpGYdHTLKh77vvCocG6YQXxj0fVWC0mK/NOWD+ayzCrUf5MN pj8T+1M055ssW+XGnNfTKli9yHei5wDL5ffMyNgjaWEXr424OX5bESIbdMUkxU+PFwQp/FIpOE+ QR/zymPlqtn7/bAUzKf9zZYm7o+afZRKnyllyvrs/xQEnNCbwbRoGNZpDNbEg+fyHE1M8aZFDBc ZVnAnmbW9WaRMV+7PZTI0BfV+CJsJEpzcrkEsrO3kFmL4a+yN7/FOI1yWNFCEUT7iF5LtEMQT0h 0xBruHxW7DTtO7xU/dc+IJ0q/bGdYJKLUqo8H/n6rXw6FoULO9SxgFTMb1k+Dv8/xrpOroBnuMU WR8O1hfmZEOET2ho42NdiGezMRTx5jMY24vLiAG0qD8IRXvgyML5233UemMDyP6rKMF4qh3zUEb iSr/TbfhJpuj+lKbNwHCE/iNsvpLsDotPbczgxX0AYyUdRcgUN+Ev1rg4ouEJefOrPFw== X-Received: by 2002:a17:902:f64a:b0:2ae:ac0c:5a29 with SMTP id d9443c01a7336-2aeac0c6655mr356945ad.10.1773151293194; Tue, 10 Mar 2026 07:01:33 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-102.dlp.protect.broadcom.com. [144.49.247.102]) by smtp-relay.gmail.com with ESMTPS id d9443c01a7336-2ae83e57ae7sm19812425ad.8.2026.03.10.07.01.32 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Mar 2026 07:01:33 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-829a535ad7fso11926784b3a.1 for ; Tue, 10 Mar 2026 07:01:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1773151290; x=1773756090; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=uxNg0ZuvybwMNPFc1XdUvc1gk+8z+XaUlMvkkngGJis=; b=eiMBxWsSDOIC8EpoR1Z8pXPnl2i6Xc3GMRs3rN1woTT1mcva3roryLCKbJn5L/cfPS 0Rz1tTED5qhJAq2mdH6827FFPxahP//GiKplCUXeowRnBVoXy36ojSniiMc9LnLOGzLP LLL7DXVKXk1ejjXtQH6FcVCcycXDYNKInvWGY= X-Forwarded-Encrypted: i=1; AJvYcCXY6VYe6cNDOx+afJmCBsxT+eey9fCgTdHLCn2dOc2bTtn1UUcZYWahJCFP2LG9dRxeNS8p8DGvEf819RY=@vger.kernel.org X-Received: by 2002:a05:6a00:414b:b0:81f:4f47:c6d6 with SMTP id d2e1a72fcca58-829a30f4a30mr13185840b3a.65.1773151288807; Tue, 10 Mar 2026 07:01:28 -0700 (PDT) X-Received: by 2002:a05:6a00:414b:b0:81f:4f47:c6d6 with SMTP id d2e1a72fcca58-829a30f4a30mr13185495b3a.65.1773151283943; Tue, 10 Mar 2026 07:01:23 -0700 (PDT) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-829a465b6f7sm16885202b3a.23.2026.03.10.07.01.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 07:01:22 -0700 (PDT) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy Subject: [PATCH net-next v5 00/10] bng_en: add link management and statistics support Date: Tue, 10 Mar 2026 19:30:22 +0530 Message-ID: <20260310140032.20893-1-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Hi, This series enhances the bng_en driver by adding: 1. Link/PHY support a. Link query b. Async Link events c. Ethtool link set/get functionality 2. Hardware statistics reporting via ethtool -S This version incorporates feedback received prior to splitting the original series into two parts. Addressed following comments from Andrew Lunn - Apply Rev-xmas fix in several places. - Correct ethtool-speed comment to reflect accurate behavior. https://lore.kernel.org/netdev/49930724-74b8-41fe-8f5c-482afc976b82@lunn.ch/ https://lore.kernel.org/netdev/CANXQDtb5XuLKOOorCMYDUpVz6aFuQgvmQZ4pS6RJGkAgeM8n1A@mail.gmail.com/ Addressed following comments from Jakub Kicinski - Took care of missing mutex_init() https://lore.kernel.org/netdev/20251127190855.69779791@kernel.org/#t https://lore.kernel.org/netdev/CANXQDtYy2JziaaVi=Cqt+gAJNt4NjFFs8NbhrS=RBV61ORwinA@mail.gmail.com/ Addressed following comments from ALOK TIWARI - Add newline for clarity/formatting. https://lore.kernel.org/netdev/CANXQDtZbLhdwEtN+kKg1OVLV+uy-gsNfX+rU4MR77QPuO6_y9A@mail.gmail.com/ v5: Address Jakub Kicinski's comments by holding the instance lock across the entire service task (instead of flag-based locking) and checking the OPEN bit under the lock to resolve the close-path deadlock. v4: Addressed comments from Jakub Kicinski: - Explicitly size speed mask arrays to remove the need for manual sentinels in the hardware configuration. - Fix an off-by-one error in the queue index bound check. - Standardize ethtool -S per-ring stat naming to "rxq$id_$name" (e.g., rxq0_errors). Removed spaces and brackets to ensure compatibility with parsing scripts. - Exclude ethtool -S global counters (tx_err, tx_fifo_underruns, tx_total_collisions) already covered by rtnl_link_stats64. v3: Addressed comments from Andrew Lunn: - Fix a comment and refactor bnge_hwrm_set_pause() to improve code readability. Addressed comments from Jakub Kicinski: - Switch to RCU for stats synchronization and drop the BNGE_STATE_READ_STATS state bit. Fix checkpatch warning by switching to kzalloc_node(). v2: Addressed comments from Andrew Lunn: - Add implementation for .get_pauseparam and .set_pauseparam to support a full flow control configuration, covering global autoneg, independent pause autoneg, and forced RX/TX pause functionality. - Move MAC, PHY, Control, Pause, and RMON statistics from .get_ethtool_stats to their respective structured ethtool callbacks (e.g., .get_eth_mac_stats, .get_rmon_stats). Addressed comments from Jakub Kicinski: - Fix potential out-of-bounds read in speed mask array by adding the missing sentinel. - Simplify timer synchronization by removing the redundant intr_sem. - Replace link_lock with the netdev instance lock, as it is sufficient to handle the required synchronization. v1: https://lore.kernel.org/all/20260223163641.755200-1-bhargava.marreddy@broadcom.com/ Bhargava Marreddy (10): bng_en: add per-PF workqueue, timer, and slow-path task bng_en: query PHY capabilities and report link status bng_en: add ethtool link settings, get_link, and nway_reset bng_en: implement ethtool pauseparam operations bng_en: add support for link async events bng_en: add HW stats infra and structured ethtool ops bng_en: periodically fetch and accumulate hardware statistics bng_en: implement ndo_get_stats64 bng_en: implement netdev_stat_ops bng_en: add support for ethtool -S stats display drivers/net/ethernet/broadcom/bnge/Makefile | 3 +- drivers/net/ethernet/broadcom/bnge/bnge.h | 12 + .../net/ethernet/broadcom/bnge/bnge_core.c | 1 + .../net/ethernet/broadcom/bnge/bnge_ethtool.c | 808 ++++++++++ .../ethernet/broadcom/bnge/bnge_hwrm_lib.c | 388 ++++- .../ethernet/broadcom/bnge/bnge_hwrm_lib.h | 8 + .../net/ethernet/broadcom/bnge/bnge_link.c | 1300 +++++++++++++++++ .../net/ethernet/broadcom/bnge/bnge_link.h | 204 +++ .../net/ethernet/broadcom/bnge/bnge_netdev.c | 632 +++++++- .../net/ethernet/broadcom/bnge/bnge_netdev.h | 119 +- .../net/ethernet/broadcom/bnge/bnge_txrx.c | 35 +- 11 files changed, 3491 insertions(+), 19 deletions(-) create mode 100644 drivers/net/ethernet/broadcom/bnge/bnge_link.c create mode 100644 drivers/net/ethernet/broadcom/bnge/bnge_link.h -- 2.47.3