From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f227.google.com (mail-pl1-f227.google.com [209.85.214.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C905F2E8897 for ; Tue, 10 Mar 2026 14:41:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.227 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773153707; cv=none; b=q5BOWgDac8TfQLvIfZM2U6YHhIUiF1sznhlGrvOFhZhMFlGo72lIDYBAZf950hX8G5NgIYkoowIdIgqJs9/SWlKGOAiCkdBeQumi3fdieqEYV12JPwJ1pcbM2MkEaeo/akZScjn/tdVFkBj0nylFgHh2AzCi7fw1jLHeFKdLUhg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773153707; c=relaxed/simple; bh=k9ETKZ2Ll/z55MoNNjAA1xVvyW76Vb9Cnj790pEDbRc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=FazrwN2qL7sM5h74vho2409jZ67elEIC4hwp92c2b8PcVhB3v2kEMYPfP2505wAEGAjNIM04DJnp1VCqV4VOePu5UDIC/dgDQKKrRZAlzmR3NcYZLqf/GDwCF0MHi9JYv6xTzgzKUhMjTsgJbK3yXFmoDLBY3EdiaLHPJcKxti4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=FX/qdLPy; arc=none smtp.client-ip=209.85.214.227 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="FX/qdLPy" Received: by mail-pl1-f227.google.com with SMTP id d9443c01a7336-2ad9a9be502so84771695ad.0 for ; Tue, 10 Mar 2026 07:41:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773153705; x=1773758505; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sABkKey+X1qlomCWXvt/52GFmSGb3hIO4tI4MGV4fzA=; b=YB3FtZgeCuuK204XZhf5PFM7qhUs76nkuyg+XgFTqAOWXAvVNdDu85K2Nncq7HpX32 kQxvb67c0Zn8wTJmxJjKW3ovs6LjaEUVXyjTH7mBq1OUXVqS4G66tfEEh2a8hk0kcZAK jCqfp+pWXVsymiTb7bbqyoI7eWIMv3hpVaVBFI/D+8Cq8K3VlH62kC8LKSRlRFnbZeLQ jWvrJ8ndLPeDfAHrGS7+mh5rmcgScU4sxc0R4ZGCiFBWGG1YIJdq0DquJCkuXo/rhEjz 8jLv86YqDBIqQZXU90OLnXCnHwj+gl6xu97WYQ6IfCehzXEMG1jNpc3+1M49jr8eOYtG polA== X-Forwarded-Encrypted: i=1; AJvYcCUvQAh/p/4TSf6HZnHYy0KOZ6x50i2D9Pfmbd4FdiJ5hQ2u5Yr5RLFLRWD+7DX1cflzK8YewohBytmpRHM=@vger.kernel.org X-Gm-Message-State: AOJu0YzV7E5Ezao5BXuS22egR/oGiEr4PjE4wc2yOFbeIS6tsL/nz+mh eVuS+w5r+XkJs2LNBMEjmgfaJeD7g3KBMqHiaPDds5z934CgHP56zGQoUEj6U2R6sZIK6YMdyqf 6BlxUyjvpEHxdQjGMjt5/M7LSN3dqoFTApGrKsHRUtOOxXMFwDPXJekECCrtsI7naHazZJ654E6 TzSCwUd5jWAJVYKFuCGrKrUFJdA7cJxkDckKokZ8MqoRoRp3MiLFjW7R3sg8uceGXfu+mrePoAm YOkcU7Qu4VVy27KCxWlLkBQgA== X-Gm-Gg: ATEYQzxkIYw9WStHowSByaEFvbUmPBNCvMgEOzK5UMKcVbwBV34ie4wWIl4HAMgfWU0 +F6m3YSgp3QybI4eO7PVNaHWC0nlFTwQMP0UYeamGAbKad+Tw8y4TyTFzqOqM54ValJQmfenJqh EunTg2Pfc2iNIbBiRZuDQjyFk46C0WCp10+hg2s7pdlDJIr/PYToZghC4N7MNNnNFhKTfyN6Mdg P1/VnVxyI93w2tLJnAudyD9v5xjWlakF9bmOJFy7GQXBad3p4RAyZZZXwOJuPt2iuyWpWHpLtlx KrMxtsa8DQSVWV/4lMpA/PWkGqQf/g2rBGvKHOEGv9ikDDPhMbzt9UHspPT/mAs3PMSedxncZnp 17pLFGnnoa9a29oq52e89PmXtPwywfc5GnYm+n0HNmt2OaIW1kCCpDgy2NSNg0zBMxGInPG9exM vu7qYcmzGzFY2XvCdfyAWnVs7ianuciOfoMvGwXFz2x/H+bQu3Dqv6J5wzQIN7TpWhyw== X-Received: by 2002:a17:902:f68f:b0:2ae:5671:7067 with SMTP id d9443c01a7336-2ae823a836bmr140046745ad.23.1773153705069; Tue, 10 Mar 2026 07:41:45 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-117.dlp.protect.broadcom.com. [144.49.247.117]) by smtp-relay.gmail.com with ESMTPS id d9443c01a7336-2ae83e80bfasm18830975ad.20.2026.03.10.07.41.44 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Mar 2026 07:41:45 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2ae61939fa5so229632045ad.0 for ; Tue, 10 Mar 2026 07:41:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1773153703; x=1773758503; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=sABkKey+X1qlomCWXvt/52GFmSGb3hIO4tI4MGV4fzA=; b=FX/qdLPyJV5VTfjs3/GxQfAJOQCrysZLtQeGVXZJJkeYmiLE/PINu4hQwvkAVCQUkn BMg+0+VGWfqeBZNJKeUtIEwa3eDyFN60ngZ+l7VDHG1ZxpEisiTnzL6WyY1xo12wqoc+ /NLqlK8c/OUDN6zJZbIhbipT2jBse9Pn07e/Q= X-Forwarded-Encrypted: i=1; AJvYcCWJ/K8ARyU3EnpDvL4xsDE0id6uF1+pC11nS12jrvNcvfabG4X88d0BcjG8HXqPZESEvqXcUAHEcK8ph5M=@vger.kernel.org X-Received: by 2002:a17:903:2ac6:b0:2ae:7f49:dba6 with SMTP id d9443c01a7336-2ae8238d8abmr151499955ad.17.1773153703261; Tue, 10 Mar 2026 07:41:43 -0700 (PDT) X-Received: by 2002:a17:903:2ac6:b0:2ae:7f49:dba6 with SMTP id d9443c01a7336-2ae8238d8abmr151499665ad.17.1773153702759; Tue, 10 Mar 2026 07:41:42 -0700 (PDT) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae83f783cfsm157096515ad.56.2026.03.10.07.41.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 07:41:42 -0700 (PDT) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy Subject: [PATCH net-next v6 00/10] bng_en: add link management and statistics support Date: Tue, 10 Mar 2026 20:10:34 +0530 Message-ID: <20260310144044.21672-1-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Hi, This series enhances the bng_en driver by adding: 1. Link/PHY support a. Link query b. Async Link events c. Ethtool link set/get functionality 2. Hardware statistics reporting via ethtool -S This version incorporates feedback received prior to splitting the original series into two parts. Addressed following comments from Andrew Lunn - Apply Rev-xmas fix in several places. - Correct ethtool-speed comment to reflect accurate behavior. https://lore.kernel.org/netdev/49930724-74b8-41fe-8f5c-482afc976b82@lunn.ch/ https://lore.kernel.org/netdev/CANXQDtb5XuLKOOorCMYDUpVz6aFuQgvmQZ4pS6RJGkAgeM8n1A@mail.gmail.com/ Addressed following comments from Jakub Kicinski - Took care of missing mutex_init() https://lore.kernel.org/netdev/20251127190855.69779791@kernel.org/#t https://lore.kernel.org/netdev/CANXQDtYy2JziaaVi=Cqt+gAJNt4NjFFs8NbhrS=RBV61ORwinA@mail.gmail.com/ Addressed following comments from ALOK TIWARI - Add newline for clarity/formatting. https://lore.kernel.org/netdev/CANXQDtZbLhdwEtN+kKg1OVLV+uy-gsNfX+rU4MR77QPuO6_y9A@mail.gmail.com/ v6: - Resending the full series due to an SMTP failure during v5 submission. - No functional changes from v5. v5: Address Jakub Kicinski's comments by holding the instance lock across the entire service task (instead of flag-based locking) and checking the OPEN bit under the lock to resolve the close-path deadlock. v4: Addressed comments from Jakub Kicinski: - Explicitly size speed mask arrays to remove the need for manual sentinels in the hardware configuration. - Fix an off-by-one error in the queue index bound check. - Standardize ethtool -S per-ring stat naming to "rxq$id_$name" (e.g., rxq0_errors). Removed spaces and brackets to ensure compatibility with parsing scripts. - Exclude ethtool -S global counters (tx_err, tx_fifo_underruns, tx_total_collisions) already covered by rtnl_link_stats64. v3: Addressed comments from Andrew Lunn: - Fix a comment and refactor bnge_hwrm_set_pause() to improve code readability. Addressed comments from Jakub Kicinski: - Switch to RCU for stats synchronization and drop the BNGE_STATE_READ_STATS state bit. Fix checkpatch warning by switching to kzalloc_node(). v2: Addressed comments from Andrew Lunn: - Add implementation for .get_pauseparam and .set_pauseparam to support a full flow control configuration, covering global autoneg, independent pause autoneg, and forced RX/TX pause functionality. - Move MAC, PHY, Control, Pause, and RMON statistics from .get_ethtool_stats to their respective structured ethtool callbacks (e.g., .get_eth_mac_stats, .get_rmon_stats). Addressed comments from Jakub Kicinski: - Fix potential out-of-bounds read in speed mask array by adding the missing sentinel. - Simplify timer synchronization by removing the redundant intr_sem. - Replace link_lock with the netdev instance lock, as it is sufficient to handle the required synchronization. v1: https://lore.kernel.org/all/20260223163641.755200-1-bhargava.marreddy@broadcom.com/ Bhargava Marreddy (10): bng_en: add per-PF workqueue, timer, and slow-path task bng_en: query PHY capabilities and report link status bng_en: add ethtool link settings, get_link, and nway_reset bng_en: implement ethtool pauseparam operations bng_en: add support for link async events bng_en: add HW stats infra and structured ethtool ops bng_en: periodically fetch and accumulate hardware statistics bng_en: implement ndo_get_stats64 bng_en: implement netdev_stat_ops bng_en: add support for ethtool -S stats display drivers/net/ethernet/broadcom/bnge/Makefile | 3 +- drivers/net/ethernet/broadcom/bnge/bnge.h | 12 + .../net/ethernet/broadcom/bnge/bnge_core.c | 1 + .../net/ethernet/broadcom/bnge/bnge_ethtool.c | 808 ++++++++++ .../ethernet/broadcom/bnge/bnge_hwrm_lib.c | 388 ++++- .../ethernet/broadcom/bnge/bnge_hwrm_lib.h | 8 + .../net/ethernet/broadcom/bnge/bnge_link.c | 1300 +++++++++++++++++ .../net/ethernet/broadcom/bnge/bnge_link.h | 204 +++ .../net/ethernet/broadcom/bnge/bnge_netdev.c | 632 +++++++- .../net/ethernet/broadcom/bnge/bnge_netdev.h | 119 +- .../net/ethernet/broadcom/bnge/bnge_txrx.c | 35 +- 11 files changed, 3491 insertions(+), 19 deletions(-) create mode 100644 drivers/net/ethernet/broadcom/bnge/bnge_link.c create mode 100644 drivers/net/ethernet/broadcom/bnge/bnge_link.h -- 2.47.3