From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 232422D948D for ; Tue, 10 Mar 2026 15:12:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773155555; cv=none; b=NZwNpm3BQyWKbA34cYopLAq+QLguGTyArLrlC/v+TyNkzdkqys5Ve+eBd82ggS8PnZzLffG5odMA4YdQ6ImLGWrEjTK2nUgxbn4xViRbxlSpNFwz3hK0yQdx629gnwUqxbnEn+dhlySZE0J6bELgl6VlPbvmt1pJO0ug4096d2Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773155555; c=relaxed/simple; bh=CPs1c/G5mvCMSxqg0kk/dMapsjGjXKO3sabe7GK1NkQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AtLtvQ2DSAxv9Sav8y7DlrXO4bTjHT9W8PtVQiG94gyLYxkAYKbxb7Qb8Dth8J1+KX7YyNYzwHYsDzYTX4bMf07TT9u9yby4U+foJd0h0GpqHNCbrZSQSUBI5zECLoCWTGdV5UMKSWCT7qRs+k4Jr7nkSxR/q40gB2VuDp22KWc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gyXstwd5; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AzUl5erD; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gyXstwd5"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AzUl5erD" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62ACno1A3893457 for ; Tue, 10 Mar 2026 15:12:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=ihC7DRtjTPJ USDPh8rumlXblahonstifNwos0OC4Pr4=; b=gyXstwd5LAxtanZgsTyX4QyRsGR CG451z6Jzitlcs7vihFhXTq/g8ArivDy72xnzzypbimXRxEjYkqMfTNjQnzU05Ry n0WFo4Bj7cOQWk+YzVpfu4A9sQwsdSzy9aaP6yN/vyIfnz8g8k484mABN4rL9Fzh PAXK5piaExIeyyzpbKBruu53DEnYBKbxkHvIo8op0FsfwMeq/G1mTt+iZW+wQKzK 7cjzwgiz0KSdLO2GvFdhBPww7VrNV6bBVJdLN8byTBEyngKuXoPXscnhueeG66ZV ml7Cl8Y+3StEYWXSEk36bN1TMCtCZiPszU6Ab41x0MDbtKaUznWyqlzRqEQ== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ctkmyrjmm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2026 15:12:33 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-89a174bd442so489458016d6.2 for ; Tue, 10 Mar 2026 08:12:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773155552; x=1773760352; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ihC7DRtjTPJUSDPh8rumlXblahonstifNwos0OC4Pr4=; b=AzUl5erDJAxTl7kRtF6+L3FL6BV6pAOWaSpSjMELpqU0gRoSYuCxMFBSxTa5Ji2T7/ 0nDl6XPhCahhEkxpQTAAz03jt12Fc4QI586sFXK/7BeeKHD/xrYVRqytuV5G49uCUqPK 4KNsh5BMhtZbOk5XQrXbDkaOvv5g+SHDscj6lxl/eCIvEsEFUIOOK0TuAUZJbrDHsevm bUHEbIGhtp5ASsR4jiSZ/274IByrGAiTe/47JfwvmfjZMLls914tTo25Nd6tlHpamnch t0yITr9D2Iukp6F9vUYuYSTU/yHRQGh1VxNGmwg+lJALMMJl4CxsOZr4sKnxY5/erm0Z xkZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773155552; x=1773760352; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ihC7DRtjTPJUSDPh8rumlXblahonstifNwos0OC4Pr4=; b=d/weTCbnp9tSdCeUYj4oMH/Aor6vaUTIy5lYy6tYi0r8JH2ncdVR5sXaEucagVtdmW GjSFjnXo4+L/VR0q+RcUHR6+Q1aeDVas5noTkizR7jEVrp7T1e1s/gOmiycaa+Gb20r/ i1ERpudoTBbpbMVaTTDXWoHDNMz/Ao9Og/JdZ2235KY0F3gfO/KtWVgB7m0ShSM1mKrj yD5z/GjHlrRm5pm1peCaUjTpb/7in20fcr/p5lqwGmQjh8WRGLI51uq32LDdWztt1r7e KvfpbBEWuhtfqVfEbKieP1scN6/13QegDZrq0Ak+nP23ZBqesHL/ycqt8KXDXZZbUi+w Jozg== X-Forwarded-Encrypted: i=1; AJvYcCV6phYLXA4kal6izdFeVejbej40zmikgfrhPgNAGdL3Zx7E5sAT4tWXbPWBn4yFQP+vJtpXS/E943Mja6Q=@vger.kernel.org X-Gm-Message-State: AOJu0YwmLaA5Y5/gdU2FsHA+qq+BKn3zgFjHuSUhPoHDqw2xI2cFb7nE r5hXTIH8cU3jHPd9B32Fwvwy2MheAvkyUmrN/vhOav8ZarIFoEJn0jf/CfbgE9LZLsaj4bo4EVq 8bIuP/Tor7INblUe45KzY+Hs3hjhob3GkpasUP6BJiqDlIqMo2JLIWj5PsvNibEiFCjo= X-Gm-Gg: ATEYQzySL+YK3bO/zEqGLIabKkozEfVWfxLzJynVnFjp5saScL+jsuT+LyKhGwxqXd7 hPwjRsvpG+eDPwpRSAO6A2xg+y5Jy2pXt7N4f+8tutMwc1pXYjlmYgNYz02pIHLn4lI4Xf/PYCU AgEoIPGaTojFIndX77IPHRGfTaBBBarhu+Ued/35Xz7QXHuhT1dENMFmR47f3L7bCwx7aeipG7x 8KTdFw6eBn+d+O15VGmqbV7T3u7hdnuRgMoyiScOkeNF0GcO0SlDwEtDmHrCROQPco1FEeBwXJG lquPiWXx1LnXiwcZAZ13FcWpmmg8Ukdo0rAMIUnspx87thfBaEWpQQNTdy2vXNnqyqr7SF0c+fO Ps/Zs1aisJ47kQtFrpc4sknzzdX2HJkmiTd08l2mwhjhR6AGibXp84AF2bzbELQ== X-Received: by 2002:a05:620a:31aa:b0:8cd:8f04:50f4 with SMTP id af79cd13be357-8cd8f04560cmr686119085a.44.1773155552354; Tue, 10 Mar 2026 08:12:32 -0700 (PDT) X-Received: by 2002:a05:620a:31aa:b0:8cd:8f04:50f4 with SMTP id af79cd13be357-8cd8f04560cmr686113485a.44.1773155551871; Tue, 10 Mar 2026 08:12:31 -0700 (PDT) Received: from hu-yabdulra-ams.qualcomm.com ([212.136.9.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dae45786sm41529852f8f.32.2026.03.10.08.12.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 08:12:31 -0700 (PDT) From: Youssef Samir To: ebiggers@kernel.org Cc: amadeuszx.slawinski@linux.intel.com, arnd@arndb.de, dakr@kernel.org, gregkh@linuxfoundation.org, jeff.hugo@oss.qualcomm.com, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, mcgrof@kernel.org, rafael@kernel.org, russ.weight@linux.dev, troy.hanson@oss.qualcomm.com Subject: Re: [PATCH] firmware_loader: use SHA-256 library API instead of crypto_shash API Date: Tue, 10 Mar 2026 16:12:30 +0100 Message-ID: <20260310151230.3478726-1-youssef.abdulrahman@oss.qualcomm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260306212052.GA9593@quark> References: <20260306212052.GA9593@quark> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=RYudyltv c=1 sm=1 tr=0 ts=69b034e1 cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=dNlqnMcrdpbb+gQrTujlOQ==:17 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=VwQbUJbxAAAA:8 a=B-Biid8fbNSdKZqIvtQA:9 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-GUID: fYyjt5E2G8rx72AdNtF5tfOyFy1btxKz X-Proofpoint-ORIG-GUID: fYyjt5E2G8rx72AdNtF5tfOyFy1btxKz X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEwMDEzMiBTYWx0ZWRfXxNJk77qEixAE 4g1NAjVKrCIRFhjbMyBqa3zVgwnkoQ0XtNEOqfgejkzUzdw38Fh8Ygd8yA2DR+aj4NymmpUkQZv K4ex18BP3zTOqwCdtlBxrmu8dtzac/h+VJerHjocZhhx+HuQHClsC3aWWIu8F6uxb97omnJEUHb +HJX7ygAhIl9NMR3f3HZ637VHUVS89VJEDwoO9iwgN1W/NgHwVI9/6Y98iv+Tg14xJz4m2PLrs8 UXjm8nvnCLy+iK154ZDb1MlJ5GMwlNUPjNRVWz9S5BUqyDhuah9JXi/yqxzROXw6PhM5cPBVN32 U3jnLBzfz3VzdRortdJ1aZjNJ7kY0n+raX4H53XXLTw+h0Tz2Qki5jld85uJcMLa91CmvqbQ74f E8MWuF17rf53LyjWnRV+DSSoZHW0cV12IJwP4G/WNtXHkSdLXqXQCZynHWX6PabsQUaH1lcpnhj 0yBlF7vNqT0WqwngZpg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_03,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 impostorscore=0 malwarescore=0 spamscore=0 phishscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603100132 On 3/6/2026 9:20 PM, Eric Biggers wrote: > > I guess this further shows that the upgrade to size_t lengths was a good > idea... > > There was recently a similar bug report where on old kernels kexec > crashed in crypto_sha256_update when loading a file larger than ~2 GB. > It had already been fixed upstream by the upgrade to size_t lengths. > However, due to the large number of backports that would have been > needed, for the 6.1, 6.6, and 6.12 LTS kernels we just went with the > one-line fix "crypto: sha256 - fix crash at kexec" > (https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit/?h=linux-6.12.y&id=70165dc3ec8cff702da7b8b122c44575ee3111d6). > > That increased the supported length in 6.1, and 6.6, and 6.12 from ~2 GB > to ~4 GB. Your "6.8.0-62-generic" distro kernel must be missing that > commit. You should first ask your distro to cherry-pick that commit > from 6.12, and it will fix the problem for sizes < ~4 GB. Thanks, that fixes the issue :) I will request from them to cherry-pick it. > > Do you need support for sizes > ~4 GB? If so, then we can come up with > a solution for that in the LTS kernels. (Besides just doing a lot of > backports, one option would be to replace the call to > crypto_shash_digest() with a multi-step incremental computation.) No need, 4GB is way larger than our image size already. Thanks - Youssef