Re: [PATCH v10 2/3] of: factor arguments passed to of_map_id() into a struct

[kernel test robot <lkp@intel.com>]

Hi Vijayanand,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 3fa5e5702a82d259897bd7e209469bc06368bf31]

url:    https://github.com/intel-lab-lkp/linux/commits/Vijayanand-Jitta/of-Add-convenience-wrappers-for-of_map_id/20260309-033633
base:   3fa5e5702a82d259897bd7e209469bc06368bf31
patch link:    https://lore.kernel.org/r/20260309-parse_iommu_cells-v10-2-c62fcaa5a1d8%40oss.qualcomm.com
patch subject: [PATCH v10 2/3] of: factor arguments passed to of_map_id() into a struct
config: i386-buildonly-randconfig-005-20260310 (https://download.01.org/0day-ci/archive/20260310/202603101641.aPJli6Zx-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260310/202603101641.aPJli6Zx-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603101641.aPJli6Zx-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/cdx/cdx_msi.c: In function 'cdx_msi_prepare':
>> drivers/cdx/cdx_msi.c:128:13: warning: variable 'dev_id' set but not used [-Wunused-but-set-variable]
     128 |         u32 dev_id;
         |             ^~~~~~


vim +/dev_id +128 drivers/cdx/cdx_msi.c

0e439ba38e615e Nipun Gupta       2024-02-26  119  
0e439ba38e615e Nipun Gupta       2024-02-26  120  static int cdx_msi_prepare(struct irq_domain *msi_domain,
0e439ba38e615e Nipun Gupta       2024-02-26  121  			   struct device *dev,
0e439ba38e615e Nipun Gupta       2024-02-26  122  			   int nvec, msi_alloc_info_t *info)
0e439ba38e615e Nipun Gupta       2024-02-26  123  {
ab5be96a55e45e Charan Teja Kalla 2026-03-09  124  	struct of_phandle_args msi_spec = { .np = NULL };
0e439ba38e615e Nipun Gupta       2024-02-26  125  	struct cdx_device *cdx_dev = to_cdx_device(dev);
0e439ba38e615e Nipun Gupta       2024-02-26  126  	struct device *parent = cdx_dev->cdx->dev;
0e439ba38e615e Nipun Gupta       2024-02-26  127  	struct msi_domain_info *msi_info;
0e439ba38e615e Nipun Gupta       2024-02-26 @128  	u32 dev_id;
0e439ba38e615e Nipun Gupta       2024-02-26  129  	int ret;
0e439ba38e615e Nipun Gupta       2024-02-26  130  
0e439ba38e615e Nipun Gupta       2024-02-26  131  	/* Retrieve device ID from requestor ID using parent device */
ab5be96a55e45e Charan Teja Kalla 2026-03-09  132  	ret = of_map_msi_id(parent->of_node, cdx_dev->msi_dev_id, &msi_spec);
0e439ba38e615e Nipun Gupta       2024-02-26  133  	if (ret) {
0e439ba38e615e Nipun Gupta       2024-02-26  134  		dev_err(dev, "of_map_id failed for MSI: %d\n", ret);
0e439ba38e615e Nipun Gupta       2024-02-26  135  		return ret;
0e439ba38e615e Nipun Gupta       2024-02-26  136  	}
ab5be96a55e45e Charan Teja Kalla 2026-03-09  137  	of_node_put(msi_spec.np);
ab5be96a55e45e Charan Teja Kalla 2026-03-09  138  	dev_id = msi_spec.args[0];
0e439ba38e615e Nipun Gupta       2024-02-26  139  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki