From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 690973C9ECC; Wed, 11 Mar 2026 10:18:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773224292; cv=none; b=mKhOue6MNjyOHE9zmMd7LaUsOvGJNEoqOK3UTtuFXcVnMmYOPq6eTqhGyMvFtivJvwrgbsJQORIt++AFtIp3hMfp5Js7aJdtmyGtDaQ2s7CCwqs3C8aaImejC4XJoJyavOBWeuAhRpY3jAa+8yczFbm/50XeI9eSO0rOFp/5nLg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773224292; c=relaxed/simple; bh=Hicf9XQr1VM3rKrvaseGCP1p6RgZxal1WiVh3tjqMqU=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=cqPSPV2JOCEB4xYzw7rvZQfzOpQBCh9sOqw5t09bWicEoEfHbiOF2gd1CIJFoy/bilHb+smxMdeMemnqw9kTxUAMk6K6rnjcZpijB4PG13WSu0B2SIhjsJPktHCsaE2oKaIhEqMuKaB6PyYG+crhGkbsHztRfxxGX2cdpUFJv5c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=up0mfz66; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="up0mfz66" Received: by smtp.kernel.org (Postfix) with ESMTPS id ED416C2BC86; Wed, 11 Mar 2026 10:18:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773224292; bh=Hicf9XQr1VM3rKrvaseGCP1p6RgZxal1WiVh3tjqMqU=; h=From:Subject:Date:To:Cc:Reply-To:From; b=up0mfz66SzSTWbt72UdQ419+7BArGOpvZnTkJE1Z2munD4z6s+BwQckqMw4oL2jhq iTaCB+VVvcgeXvJllZpd0kfkCUfDJn16rxLjsxcZfrlSI2wJJRbXk89B9b6hnfBjI3 R5uJ59KqA8n6pSoLwJShE+yevgc5nVYr6HchNhqt7V9AqMlY6zUM2zjPARn8BD5bAO ao0wEwsawnXnBw9/PLxF7TS2Hv9ia6Jhvrw88hQuVCOYl99TqdJMmhNl3eJ4K7y9Ii ME9MTQDEEana55hjLcHF3OSrlTTa+2Za9w5ojlbNYlus44PN0F7Lonp7IlzV67Resu qfdWLFHFVHonA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB74D1049515; Wed, 11 Mar 2026 10:18:11 +0000 (UTC) From: Jan Petrous via B4 Relay Subject: [PATCH v10 0/5] Support multi-channel IRQs in stmmac platform drivers Date: Wed, 11 Mar 2026 11:17:57 +0100 Message-Id: <20260311-dwmac_multi_irq-v10-0-7ab1669759b5@oss.nxp.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAFVBsWkC/23SzU7DMAwA4FeZcqZT7Pw04cR7IDQlacwi0Xa0o wxNfXfSAVpRerQlf7ZsX9kYhxRH9ri7siFOaUx9lwPgDzsWjq57jVVqcoIhRwXIbdV8ti4c2o+ 3czqk4b2yjSHNpcYQgOWq0xApXW7k80uOj2k898PXrcMES/bXAllYE1S8ElppdJ5HS/VTP4777 nLah75lizbhn6B5JkoBF8EbtCh4w2soBbEWRCmILISgBKGPxuoNQa4FUwoyCwbJCUmBkLAU1F3 ArRnUIlDQ1jpFLshS0GtBlYLOAkrlCZoagIdSqNeCLoU6C2QoCm+z4zdmMHdBbHzGZBaB5136Y ADcxjXtSoCNa9ofgYtIpuFA/4V5nr8BuZSrXsECAAA= To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Chester Lin , Matthias Brugger , Ghennadi Procopciuc , NXP S32 Linux Team , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Li Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, devicetree@vger.kernel.org, rmk+kernel@armlinux.org.uk, vladimir.oltean@nxp.com, boon.khai.ng@altera.com, "Jan Petrous (OSS)" X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773224290; l=4792; i=jan.petrous@oss.nxp.com; s=20240922; h=from:subject:message-id; bh=Hicf9XQr1VM3rKrvaseGCP1p6RgZxal1WiVh3tjqMqU=; b=xlnICUKnVumeJjPG6VajLwl7SIOUWEWDx+liXIWqpzOHTDlUmge9ojm7sM6dRgcWCSEqffruO B1EpOLRO8lgAMSEMgL2tv3BF/OkSA+7b5//qKE2x6zKhCLPpQiIkmTj X-Developer-Key: i=jan.petrous@oss.nxp.com; a=ed25519; pk=Ke3wwK7rb2Me9UQRf6vR8AsfJZfhTyoDaxkUCqmSWYY= X-Endpoint-Received: by B4 Relay for jan.petrous@oss.nxp.com/20240922 with auth_id=217 X-Original-From: "Jan Petrous (OSS)" Reply-To: jan.petrous@oss.nxp.com The stmmac core supports two interrupt modes, controlled by the flag STMMAC_FLAG_MULTI_MSI_EN: - When the flag is set, the driver uses multi-channel IRQ mode (Multi-IRQ). - Otherwise, a single IRQ line is requested (aka MAC-IRQ): static int stmmac_request_irq(struct net_device *dev) { /* Request the IRQ lines */ if (priv->plat->flags & STMMAC_FLAG_MULTI_MSI_EN) ret = stmmac_request_irq_multi_msi(dev); else ret = stmmac_request_irq_single(dev); } At present, only PCI drivers (Intel and Loongson) make use of the Multi-IRQ mode. This concept can be extended to DT-based embedded glue drivers (dwmac-xxx.c). This series adds support for reading per-channel IRQs from the DT node and reuses the existing STMMAC_FLAG_MULTI_MSI_EN flag to enable multi-IRQ operation in platform drivers. The final decision if Multi-IRQ gets enabled remains on glue driver to allow implementing any reguirements/limitions the focused platform needs. NXP S32G2/S32G3/S32R SoCs integrate the DWMAC IP with multi-channel interrupt support. The dwmac-s32.c driver change is provided as an example of enabling multi-IRQ mode for non-PCI drivers. Signed-off-by: Jan Petrous (OSS) --- Changes in v10: - Fixed yaml issue - Link to v9: https://lore.kernel.org/r/20260311-dwmac_multi_irq-v9-0-f0c03ef8d01f@oss.nxp.com Changes in v9: - Changed interrupt minItems from 11 to 1 to support backward compatibility and removed the 'Reviewed-by' accordingly for patch 4 - Link to v8: https://lore.kernel.org/r/20260309-dwmac_multi_irq-v8-0-f0cc5bc811a7@oss.nxp.com Changes in v8: - Rewritten queue irq getter, based on Russell's (ready-to-use) hint - Renamed s32_gmac_validate_multi_irq() to s32_gmac_setup_multi_irq() to better describe the functionality - Fixed typo in commit message for patch 5 - Renamed label in patch 5 to make it more descriptive - Link to v7: https://lore.kernel.org/r/20260226-dwmac_multi_irq-v7-0-f8fe3b945bb4@oss.nxp.com Changes in v7: - Optimized 2 similar loops on queue rx/tx irq reading - Swap the yaml and dts patches with hope it fix dt_binding_check failing - Link to v6: https://lore.kernel.org/r/20260225-dwmac_multi_irq-v6-0-245bf1d7110c@oss.nxp.com Changes in v6: - Added 2 mintainers which were not covered by 'b4 prep --auto-to-cc' but complained on patchwork check - Added helper macro for loop over queue-based arrays (inspired by AI review) - Added full validation on all channel IRQs - Link to v5: https://lore.kernel.org/r/20260223-dwmac_multi_irq-v5-0-8fc699a5fac4@oss.nxp.com Changes in v5: - fixed typo in "symetrical" - cleaned negative return value on platform_get_irq_byname_optional() in stmmac_get_platform_resources() - rebased on v7.0-rc1 - Link to v4: https://lore.kernel.org/r/20260128-dwmac_multi_irq-v4-0-82fa34fcf2f2@oss.nxp.com Changes in v4: - Fixed IRQ reading check - Made cleaner the IRQ validity (to get AI reviewer happy) - Fixed minItems of interrupts property in yaml - Link to v3: https://lore.kernel.org/r/20260123-dwmac_multi_irq-v3-0-cc53f2be8961@oss.nxp.com Changes in v3: - removed RFC prefix - rebased on v6.19-rc6 - fixed forgotten extra line setting to Multi-IRQ unconditionally - fixed yaml - Link to v2: https://lore.kernel.org/r/20260121-dwmac_multi_irq-v2-0-3b829230d071@oss.nxp.com Changes in v2: - Fixed incorrect buffer len for 'rx-queue-%d' property check - Added backward compatibility to not break old settings - Fixed DT example in yaml - Link to v1: https://lore.kernel.org/r/20251214-dwmac_multi_irq-v1-0-36562ab0e9f7@oss.nxp.com --- Jan Petrous (OSS) (5): net: stmmac: Use helper macro for loop over queue-based arrays net: stmmac: platform: read channels irq arm64: dts: s32: set Ethernet channel irqs dt-bindings: net: nxp,s32-dwmac: Declare per-queue interrupts stmmac: s32: enable support for Multi-IRQ mode .../devicetree/bindings/net/nxp,s32-dwmac.yaml | 47 ++++++++++++++++-- arch/arm64/boot/dts/freescale/s32g2.dtsi | 26 ++++++++-- arch/arm64/boot/dts/freescale/s32g3.dtsi | 26 ++++++++-- drivers/net/ethernet/stmicro/stmmac/dwmac-s32.c | 36 +++++++++++++- .../net/ethernet/stmicro/stmmac/dwxgmac2_core.c | 2 +- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 3 ++ drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 16 +++--- .../net/ethernet/stmicro/stmmac/stmmac_platform.c | 57 +++++++++++++++++++++- 8 files changed, 191 insertions(+), 22 deletions(-) --- base-commit: 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f change-id: 20251209-dwmac_multi_irq-9d8f60462cc1 Best regards, -- Jan Petrous (OSS)